From patchwork Sat Nov 12 20:16:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 81931 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp369335qge; Sat, 12 Nov 2016 12:16:53 -0800 (PST) X-Received: by 10.99.137.66 with SMTP id v63mr55904495pgd.117.1478981813571; Sat, 12 Nov 2016 12:16:53 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id i10si13597719pai.144.2016.11.12.12.16.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 12:16:53 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-441236-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-441236-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-441236-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=yVo+QG51OdRqOI8yW WapfxDQlIXMzinAOyl5cy/Y+G+KksM833333S9M5B/XNbWXW6PbetUdYIOhbO89V NZ4BI0ukTDwmBByq7e9PsAparKhCxlXfcO/uML5AhljfcSXM9tjkn8/cjHlF5CZj ashI0sWM9Jf/bd0jjzZAsEbdpg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=PJAEp43cX0quL7hdlYXdQhN up1o=; b=Bn9PbtC4tCS/FNv8MSaoMVNMV5GdanxrqIolGoBXXvrNCHsitdrb0/t V5mJ+KzWcSVc6lMyYf6TAnuGrbMfd9NEdE25Ouo8qWRsh8rLYRyC9UpOLPlb1OE0 88Ig+WuHObaVkOWiohrF8z8axmny4dzjv3atclh92B4x/7oPVEzs= Received: (qmail 112848 invoked by alias); 12 Nov 2016 20:16:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 112759 invoked by uid 89); 12 Nov 2016 20:16:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Five, *if, five X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Nov 2016 20:16:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33113C056800; Sat, 12 Nov 2016 20:16:25 +0000 (UTC) Received: from localhost (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uACKGNvg017604; Sat, 12 Nov 2016 15:16:24 -0500 Date: Sat, 12 Nov 2016 20:16:22 +0000 From: Jonathan Wakely To: Chris Fairles Cc: Christophe Lyon , "libstdc++@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Five patches for std::experimental::filesystem Message-ID: <20161112201537.GE21992@redhat.com> References: <20161024165010.GL2922@redhat.com> <20161025153232.GN2922@redhat.com> <20161027110139.GY2922@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.1 (2016-10-04) On 10/11/16 17:29 +0000, Chris Fairles wrote: >"cannot check is file is empty" -> *if This patch fixes the typo. I haven't looked at the failure yet. Will commit to trunk shortly. commit 9882c567342019c9561b44e611af9d42cdf23f3b Author: Jonathan Wakely Date: Sat Nov 12 20:14:07 2016 +0000 * src/filesystem/ops.cc (is_empty): Fix typo in exception message. diff --git a/libstdc++-v3/src/filesystem/ops.cc b/libstdc++-v3/src/filesystem/ops.cc index 8ed0a10..0dcb1b4 100644 --- a/libstdc++-v3/src/filesystem/ops.cc +++ b/libstdc++-v3/src/filesystem/ops.cc @@ -1054,7 +1054,7 @@ fs::is_empty(const path& p) error_code ec; bool e = is_empty(p, ec); if (ec) - _GLIBCXX_THROW_OR_ABORT(filesystem_error("cannot check is file is empty", + _GLIBCXX_THROW_OR_ABORT(filesystem_error("cannot check if file is empty", p, ec)); return e; }