From patchwork Thu Oct 20 10:51:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Vehreschild X-Patchwork-Id: 78477 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp711843qge; Thu, 20 Oct 2016 03:51:42 -0700 (PDT) X-Received: by 10.99.145.193 with SMTP id l184mr12245pge.99.1476960702751; Thu, 20 Oct 2016 03:51:42 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id d5si41096726pgh.128.2016.10.20.03.51.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 03:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-439105-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-439105-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-439105-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; q=dns; s=default; b=H0ZveYTiJytKpP4s I6BMKz8d+GLLcBCDxyVc8RGCMRjnkuNpyMOkCyoRF7S5PnlfEtTsQ86OUKJh+GlR pXjAGl0RGsr9G6OeKh8bJyg7bh8BTP69KlTwtqxXMAIfXuoWux/0anGn3zb3RpvQ r/1K9rzCAPH0s46Y3dzIw/rlC0I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; s=default; bh=T3Ddlz64dGCjls0qzXNDXV bmyco=; b=w8u5NqXFn7/qw7F9uXbDwFqWmf7v4ay2mofu3s5RX08CDBsDLYTu6w hwI19ZDRvFPLKHFcGSOx2xdpJCez4JFpn7UHN7F1aUWxvDiVKRImhmb8rK3aYgHG dhZ+1XEiM5K9MuOxUzaOc3vrAlPRhDsbEaAyk+xvzrXjNmIZiLg68= Received: (qmail 115532 invoked by alias); 20 Oct 2016 10:51:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 115409 invoked by uid 89); 20 Oct 2016 10:51:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=charlen, Hx-languages-length:2271, crab, sk:blomqvi X-Spam-User: qpsmtpd, 2 recipients X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 10:51:05 +0000 Received: from vepi2 ([84.63.206.51]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LaGfK-1ceSuu1b4g-00m5qt; Thu, 20 Oct 2016 12:51:02 +0200 Date: Thu, 20 Oct 2016 12:51:01 +0200 From: Andre Vehreschild To: Janne Blomqvist Cc: GCC-Patches-ML , GCC-Fortran-ML Subject: Re: [Patch, Fortran] Preparatory patch to change charlen's kind type Message-ID: <20161020125101.5b7cd1f2@vepi2> In-Reply-To: References: <20161020103735.39f3d520@vepi2> MIME-Version: 1.0 X-UI-Out-Filterresults: notjunk:1; V01:K0:bvDTf80Hs2w=:YQV280oFc2dSPp9zv1BCsn qC2xDOgTqlt4ynv1NDz6S8vNTOtt9aBCmiq/2SN+AD6J0Nm+0famaPNjTuMdqWStMZTYweYat AiYtBiPUIm3/wWNux+Y93/duWRT7Af9jFvDNVZ1OHjdAsxwcI3GTNz+JRlvwmKF9NozhfZ8aa LNnq4Li/EMZX5PoyoViXps6+vx0x+Zogmb3X0aY8RU+zlARb1K9NK+3frLmkOwSQeG5/RInlE OquaiyBlrvaRpyRwEVcA/MuHfNbxHXYIEO5MO63elqyUf0coQelwniwNVNudofxdCUZuclWtn RDKnMcowf26uPF5Gt5fPodBIz+nhcARFEi4cjf/y6Lv09m5HvwDQVlBbsB2Ff/Ou0NAS/VLxo TErhedlL7y/hdDupGIBiDkLhw47W37zyGMf6jyM6R9KI45sPOil7E/kHYGDxI3Munxq9GgiOc QR2GJvZFSEhltQ2eZvtKK6iE3BOUkzlpsyWCn86xKEYPbC1FInschnyyaHZlMqVDqQv0xC2uU DJzCM5zSoYrpjT+IybK/9YMnxpvGhJ0YsDo4Ht7GcCyENSnQWU/mdPL/qaV/U8uAIonIMh7cn DUF96jv3TZ/J4qw0sgwZXfiJ8ZNjaOlCFaFtkREWPs112EdDAiGueZ5T2Q3JtDqgpsgJ8m/y/ CwfdQqwSwkXsyUsRkNt6zqgPgJrgoXEzGNQLO1d/WsAiY+GH2yIY0nMleqvd9xQwQm7+Or2Du uLaaFR+bjPt6lz3WEFnmJLO3tQpjjo/AyroH6lCJlJHjKPXicH8l9P+Qv+I= Hi Janne, thanks for the fast review. > Ok, thanks for catching this! Well, I am quite sure, that I wrote this crab initially. Committed as r241367. Regards, Andre On Thu, 20 Oct 2016 12:57:38 +0300 Janne Blomqvist wrote: > On Thu, Oct 20, 2016 at 11:37 AM, Andre Vehreschild wrote: > > Hi all, > > > > during hacking in gfortran I found, that for unlimited polymorphic types the > > size type of a char array stored is hard coded to be 4. This small patch > > resolves this by using the better suited constant: gfc_charlen_int_kind. > > This will make the move to larger strings easier. > > > > Bootstrapped and regtested on x86_64-linux/F23. Ok for trunk? > > > > Regards, > > Andre > > > > diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c > > index 6d324a6..e110f2c 100644 > > --- a/gcc/fortran/class.c > > +++ b/gcc/fortran/class.c > > @@ -707,7 +707,7 @@ gfc_build_class_symbol (gfc_typespec *ts, > > symbol_attribute *attr, if (!gfc_add_component (fclass, "_len", &c)) > > return false; > > c->ts.type = BT_INTEGER; > > - c->ts.kind = 4; > > + c->ts.kind = gfc_charlen_int_kind; > > c->attr.access = ACCESS_PRIVATE; > > c->attr.artificial = 1; > > } > > > > -- > > Andre Vehreschild * Email: vehre ad gmx dot de > > Ok, thanks for catching this! > > -- Andre Vehreschild * Email: vehre ad gmx dot de Index: gcc/fortran/ChangeLog =================================================================== --- gcc/fortran/ChangeLog (Revision 241365) +++ gcc/fortran/ChangeLog (Arbeitskopie) @@ -1,3 +1,8 @@ +2016-10-20 Andre Vehreschild + + * class.c (gfc_build_class_symbol): Set the kind of _len to + gfc_charlen_int_kind to catch changes of the charlen kind. + 2016-10-17 Steven G. Kargl PR fortran/77978 Index: gcc/fortran/class.c =================================================================== --- gcc/fortran/class.c (Revision 241365) +++ gcc/fortran/class.c (Arbeitskopie) @@ -707,7 +707,7 @@ if (!gfc_add_component (fclass, "_len", &c)) return false; c->ts.type = BT_INTEGER; - c->ts.kind = 4; + c->ts.kind = gfc_charlen_int_kind; c->attr.access = ACCESS_PRIVATE; c->attr.artificial = 1; }