From patchwork Mon Apr 16 15:52:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Weigand X-Patchwork-Id: 7876 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id DA6F223E49 for ; Mon, 16 Apr 2012 15:52:33 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 910F5A1867B for ; Mon, 16 Apr 2012 15:52:33 +0000 (UTC) Received: by iage36 with SMTP id e36so10389029iag.11 for ; Mon, 16 Apr 2012 08:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:message-id :subject:to:date:from:cc:in-reply-to:x-mailer:mime-version :content-type:content-transfer-encoding:x-cbid:x-gm-message-state; bh=m7MdkfEpQAYf5+1z1NwEw/9upf6EUuqg+AcyeVcbcBk=; b=FUZZNN0ypOmP06EijxrMtpHG1HOqggaJS+cBzR8byaSUFmpgeGtkK53F+eJDcvgODa iUc/fyPqSmZuEIgjL+UeOu+eWtslfVkZZNenun39auHBki+UHa3Mrhr+cVWAWI5eFqof GOJeO26Zej/BlN5mLRMl//wR2u6ABE93h2kb4REVNLWePUlbU9JDyrQwdMYDmo15NGQB VJV9corjE/VmBKqh59vPIbR+QjZeeqJN6HtDgle0PFfZ/SFKK5zrCHz+nSvqRBM+7Rrf Wa/Qud28/3BT2r0QI4BJuRuRp4+aTJUb/UzpXKinN6Py0bILj8VomrQ3RdIt284d5+T3 J2xA== Received: by 10.42.148.200 with SMTP id s8mr7473968icv.39.1334591552991; Mon, 16 Apr 2012 08:52:32 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.137.198 with SMTP id x6csp85462ibt; Mon, 16 Apr 2012 08:52:31 -0700 (PDT) Received: by 10.180.81.37 with SMTP id w5mr7774887wix.16.1334591550901; Mon, 16 Apr 2012 08:52:30 -0700 (PDT) Received: from e06smtp17.uk.ibm.com (e06smtp17.uk.ibm.com. [195.75.94.113]) by mx.google.com with ESMTPS id r80si18771501weq.134.2012.04.16.08.52.30 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Apr 2012 08:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of uweigand@de.ibm.com designates 195.75.94.113 as permitted sender) client-ip=195.75.94.113; Authentication-Results: mx.google.com; spf=pass (google.com: domain of uweigand@de.ibm.com designates 195.75.94.113 as permitted sender) smtp.mail=uweigand@de.ibm.com Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2012 16:52:27 +0100 Received: from d06nrmr1407.portsmouth.uk.ibm.com (9.149.38.185) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Apr 2012 16:52:02 +0100 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3GFq3062228382; Mon, 16 Apr 2012 16:52:03 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3GFq3JD010380; Mon, 16 Apr 2012 09:52:03 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q3GFq1Jv010362; Mon, 16 Apr 2012 09:52:01 -0600 Message-Id: <201204161552.q3GFq1Jv010362@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 16 Apr 2012 17:52:01 +0200 Subject: Re: [Patch ARM] Fix PR51819. To: ramana.radhakrishnan@linaro.org (Ramana Radhakrishnan) Date: Mon, 16 Apr 2012 17:52:01 +0200 (CEST) From: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org (gcc-patches), patches@linaro.org (Patch Tracking) In-Reply-To: from "Ramana Radhakrishnan" at Apr 16, 2012 02:47:43 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 x-cbid: 12041615-0542-0000-0000-0000018E87DD X-Gm-Message-State: ALoCoQkbBizHy644yzJbR5dqpro6MJN50KGr1dOhRWdBsPiYGUJSGg+T4Wys6lopqQCp/sd5nBgy Ramana Radhakrishnan wrote: > This looks OK to me. Looking at the ISA documents and the variants of > the vldn instructions your summary is correct. The alignment specifier > should not be greater than the memory size being transferred and > checking this in this form is OK . Thanks, Ramana! I've checked in the following patch. Bye, Ulrich 2012-04-16 Ulrich Weigand * config/arm/arm.c (arm_print_operand): Fix invalid alignment hints for 'A' operand types. === modified file 'gcc/config/arm/arm.c' --- gcc/config/arm/arm.c 2012-03-29 10:35:24 +0000 +++ gcc/config/arm/arm.c 2012-03-31 15:29:54 +0000 @@ -17880,9 +17880,9 @@ memsize = MEM_SIZE (x); /* Only certain alignment specifiers are supported by the hardware. */ - if (memsize == 16 && (align % 32) == 0) + if (memsize == 32 && (align % 32) == 0) align_bits = 256; - else if (memsize == 16 && (align % 16) == 0) + else if ((memsize == 16 || memsize == 32) && (align % 16) == 0) align_bits = 128; else if (memsize >= 8 && (align % 8) == 0) align_bits = 64;