From patchwork Sun Nov 13 18:30:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 81967 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp694832qge; Sun, 13 Nov 2016 10:31:34 -0800 (PST) X-Received: by 10.98.34.218 with SMTP id p87mr28109655pfj.97.1479061894298; Sun, 13 Nov 2016 10:31:34 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id j68si19271212pfj.291.2016.11.13.10.31.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Nov 2016 10:31:34 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-441257-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-441257-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-441257-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=mT+Dgs/rj8fW8DzD nDt9K6UUf+bjWRaE3hFK3ijnP611uJE9B5q0PmLnX1VLj1hlKTUlc8v7VSSYLDcC OiForpMEHWT2uiUL54XKESHH+0/KhnwfWIMACN7KC+wc3iL4hQn3zSDjVWE1FLv+ fhyilrelMdGQGeT9C5fjy1H6kZo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=RDZ/ENsiBKdG9R8u1RRb7E PL6fI=; b=fRA4+hOcI26cao7JBfGwXvrAG9RDxbKm8QGT+31h2+fE/uDDe23TZi gDlbQe5LVCV6XcIxJmdn5C6ofgcNi8S0E2ZgvOXqTdb1wrnMEMkod9C5GLZYqH4w 63J5eC20IFzgRCCMu3Fa+YVWgI40UjjEmcb4gZXvirKUgZCVilAtw= Received: (qmail 79275 invoked by alias); 13 Nov 2016 18:31:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 79257 invoked by uid 89); 13 Nov 2016 18:31:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Nov 2016 18:31:12 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 7A21C812EB for ; Sun, 13 Nov 2016 19:31:10 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jr-D3OITPTeT for ; Sun, 13 Nov 2016 19:31:10 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 54C07812EA for ; Sun, 13 Nov 2016 19:31:10 +0100 (CET) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [Ada] Fix bogus warning on address conversion Date: Sun, 13 Nov 2016 19:30:50 +0100 Message-ID: <1502340.pf9qsBsV2P@polaris> User-Agent: KMail/4.14.10 (Linux/3.16.7-48-desktop; KDE/4.14.9; x86_64; ; ) MIME-Version: 1.0 This occurs because System.Address is a private type so you need to invoke Underlying_Type before testing whether it is unsigned. Fixed thusly, tested on x86_64-suse-linux, applied on the mainline. 2016-11-13 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity): Look at the underlying type for the signedness of the type. 2016-11-13 Eric Botcazou * gnat.dg/address_conv.adb: New test. -- Eric Botcazou Index: gcc-interface/decl.c =================================================================== --- gcc-interface/decl.c (revision 242360) +++ gcc-interface/decl.c (working copy) @@ -1836,7 +1836,7 @@ gnat_to_gnu_entity (Entity_Id gnat_entit && esize == CHAR_TYPE_SIZE && flag_signed_char) gnu_type = make_signed_type (CHAR_TYPE_SIZE); - else if (Is_Unsigned_Type (Etype (gnat_entity)) + else if (Is_Unsigned_Type (Underlying_Type (Etype (gnat_entity))) || (Esize (Etype (gnat_entity)) != Esize (gnat_entity) && Is_Unsigned_Type (gnat_entity)) || Has_Biased_Representation (gnat_entity))