From patchwork Tue Feb 9 11:24:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 61516 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1982739lbl; Tue, 9 Feb 2016 03:25:35 -0800 (PST) X-Received: by 10.66.141.79 with SMTP id rm15mr48787198pab.77.1455017135329; Tue, 09 Feb 2016 03:25:35 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 82si53538399pfn.23.2016.02.09.03.25.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2016 03:25:35 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-421063-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-421063-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-421063-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; q=dns; s=default; b=h3vCbS3QSH2p4ymv dMaiGKcCf1htn9CC3g9uXV3G3+ZOg1bVeYZfESyBn3nCoSUKFaSO9Y4DBnfdnSjW b6Au79xUwRTSqToGB3fe8vBtFzVOHN2JeUlLQohzqD6Vuu/miSVr9eUp9dSSfBjl F4CeIkxpwXQb8wW1P8dfT61WUjY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; s=default; bh=AC3zG+FJLYS1cxdetrQiOG oCoMM=; b=cYDhUuWqt4oGZf/NWi2ccu8MmJ9nyeYLp+tSk5v3W8Ib5d08JU5xTT /jMAQG0Ub22mHWFOIH8ApZljFZl9tm5VCPryVklX9hGXQrQweO4tFvszEeqQzJoP CqZHKQB2erkZVwVSU1lqhQDTsnUs2UP8CA6THLEZUZU4DfYkzSgEk= Received: (qmail 10083 invoked by alias); 9 Feb 2016 11:25:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10015 invoked by uid 89); 9 Feb 2016 11:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=Drop, H*r:Tue, directive, HX-Exchange-Antispam-Report-CFA-Test:102415293 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Feb 2016 11:25:19 +0000 Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3lrp0080.outbound.protection.outlook.com [213.199.154.80]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-14-jI2TOk5jQyqU9Jf4z-HlOw-1; Tue, 09 Feb 2016 11:25:13 +0000 Received: from AM2PR08CA0017.eurprd08.prod.outlook.com (10.162.32.27) by AM2PR08MB0340.eurprd08.prod.outlook.com (10.161.235.152) with Microsoft SMTP Server (TLS) id 15.1.403.16; Tue, 9 Feb 2016 11:25:12 +0000 Received: from DB3FFO11FD056.protection.gbl (2a01:111:f400:7e04::194) by AM2PR08CA0017.outlook.office365.com (2a01:111:e400:843e::27) with Microsoft SMTP Server (TLS) id 15.1.403.16 via Frontend Transport; Tue, 9 Feb 2016 11:25:11 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD056.mail.protection.outlook.com (10.47.217.128) with Microsoft SMTP Server (TLS) id 15.1.409.7 via Frontend Transport; Tue, 9 Feb 2016 11:25:11 +0000 Received: from e107456-lin.cambridge.arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.266.1; Tue, 9 Feb 2016 11:24:59 +0000 From: James Greenhalgh To: CC: , , , , , Subject: Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump Date: Tue, 9 Feb 2016 11:24:57 +0000 Message-ID: <1455017097-24724-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; DB3FFO11FD056; 1:ZyqwwcTZyIo6WAlwwykcnQIU5wEGdsLFuV9usHjd7e9XZn16OFyA14P3kaAFLa13L2ep5mpBKAOUvn4qt4Ts05u6elAMYQMTbL0PHwj9sHefJtrBFTHBQoFGlGO7PV+UTkC+1AxOe/4yTFL0G1R4wSuKNO4bKowrtJjXX+qQdYGZCgIbpMEs4Iwu847b20OkvjPC1XXY0dAmWjXyDZzG1YwOXesTbJqfkcWy4JooI5C3xTpRFE8ksTYtrIg6inQ9MWaHzT4RYYN4OJxJOfxeU04np7DXLEschOmpysZUqJiZXKviloUDx7Kr8D+ytb7XaEnJVr6rlr7aEpspsb1gU12pZ6+yqBFgZ5ZQO1tuOoQUFggrsstUYyaXXYrHnoxLOj8ED6pgc13RUeYO0m6ZSTzj1uOwdwFPcA/nmZEqk/L/dhAecrQ78tb/9Ud3zj9TVCdObgiIxHwoFa6OOVtxCQ== X-Forefront-Antispam-Report: CIP:217.140.96.140; CTRY:GB; IPV:CAL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(189002)(24454002)(164054003)(377424004)(52604005)(377454003)(199003)(1096002)(1220700001)(104016004)(5008740100001)(2476003)(11100500001)(568964002)(586003)(2950100001)(230783001)(33646002)(189998001)(2906002)(6806005)(77096005)(4326007)(36756003)(4610100001)(5890100001)(50986999)(84326002)(76176999)(512874002)(50226001)(87936001)(86362001)(19580405001)(106466001)(92566002)(110136002)(5003600100002)(19580395003)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR08MB0340; H:nebula.arm.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0340; 2:pjg6wrgnnlQJqx9yKB2Ck8itahwJzL+U40rNTGsxkYvJHXePJ8RrloC2vX1T0LNM4vzZrwXueA1Apw1EJaCBnfvKJxBPpq1YNrzGRuC03OSoihclbL7S67WXdhw8pyy56zTSo9h5+4zSWyDu1hOZPA==; 3:2H7NrYLKFrTJsHq/9dKnj0U5bZ/ia6rAniN24Mf1bL+jR9q3bOJjq0HHP8PCM1g6eYNsd7WuUTxwAAT4HY5vzBNMaI6OYD6JgaXaBhr8uAUNuT0HIno/4LxLUaF3fl7ha1yu07G0Ba8OYcAVipMch0SnNwLpqGpNyg8fJS48A+L/FzYIh9n9RxGP05hXstVUOJURAjVXESq4Aj84PEZfRDRvO/fS87DTOWdt11HyzMrNSuX+OVAYfxOY6vUluMmNtSfNu5LBbVE49TG00C+e3w==; 25:IB1jbgBAZQpnMHNW9ZtL+Zk4ug9OFk1nwkw0/qqaiLJMjt/25eCy1zyWGGP5Iy7FSO1rUgB4YQuB83/9OhfbW+XleGmGYSnz8cw6vB6kSGq5XTYmeLRyOiKXAej6TzUtzcRtb7xbOvge2MFANXhKwZgH9G3a4PkYuQJfEuI8uYueZQpulzgPkXNE0j0lfdh9x/l51WSYU9MeX4fhJJE8ZwJ9oYFp4G/1jT0wwFO3ikFpNKmHHv89Gi3Xr2I1j2JeTWIE71mj0Zs/5OT4VfF+pKBKQ7QQhy9/cPwk7qJgA3AiWM+zw/MT5jwEU+A8Mv1r; 20:/b4p3DjizaucWay7yhYv0vZXB5KexbSdWmqjrwqcE4X//+jawl7mzshIW+0FNlUPk/w/xJGlAZv6Ctqg3dD6vHKZOxxsafgcskwNBH4mrMUWamVzutPBnRDYtdTVtVpGPre0ltCZ6Q5s79Gfz0l8jDYe4EkF2q6E2fWYmXpGSg4= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501001); SRVR:AM2PR08MB0340; X-MS-Office365-Filtering-Correlation-Id: 87034e6e-7798-4633-cdba-08d33143acbb NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415293)(102615271)(601004)(2401047)(13023025)(13018025)(13020025)(13016025)(13013025)(5005006)(13024025)(8121501046)(10201501046)(3002001); SRVR:AM2PR08MB0340; BCL:0; PCL:0; RULEID:; SRVR:AM2PR08MB0340; X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0340; 4:8tk5kG+b6IJT0PkdYUS+JdjKjj8HHmcbYuPGAce03Mv0f7MgHb2P8a3Ukvm3F3Rpego9ywAcoY3UfxrgoMdg3V7G1lKQo+oKMrSjdgYaPR/gk4DV+MupACWMLmFUEZ5kLmRk4T/06Ypcu9QGftx8uPhmpL4R5DO2Ns7yBIAaitnB1kNePuDjiE1wk1rKVntIjOi0RHU6t5pbjxouQW8BspKIV+A/a3vsBIn6BFDvo7UU1aVaekJ4PaBVKp2IgYNRsB+AVHApE7PeG7TtUR9KmTMxzQqD0KV0L2dwtZF0eUzwfBC8olJPHfwF1z8Bao9AUxctzE52/jh9YuwuwUAOh3tgZLKT/2z66enghW35MBOeulWsGlLNUKTg36tyekb8GXoB5MIvIYPhBdlpVsQa9EWRChJksPWF1+82mEj5dIq+lTrVPRIH8LVkMpsm5Y11eqsMm36+r1mpgvF/Stms1tyc9B9BGTCwAf9YGcNPP/fY1r0n9qX7bsvPzzIWvrisUy8loR4qtwbplW7cVOwSjuNLYJUZrLXN5+GYL3rIJWn96gW1jp4jy8d4qy1xFrU4 X-Forefront-PRVS: 08476BC6EF X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR08MB0340; 23:cNcLUwZyRAWLrxpxadrL1IawoFTQj3/Cj8bq2T+kS?= =?us-ascii?Q?WGYAJWx0J5J+Wy4JxrN8yR48QS2LLvvB33qIum6UiBplP8J420UgFKDzHJZk?= =?us-ascii?Q?y0eqPpSWwL3zmI8u3HWOxjJpZR5WgVoklNAYPhdJfy6xEdK+akkU/BeGxoIm?= =?us-ascii?Q?la4QpvpjsceY/VCLGyzfHj5OY8JbWplUbQIMmohTAioLvA2TTVD7DNST5jcG?= =?us-ascii?Q?zbsKC9s/Z+JusgbSi0oTJrUySa3IuYsWYxFUtUAC2ruiHj1RI0Ka1lCg8rlu?= =?us-ascii?Q?pxu24nzF4T7vCgx09DzGUH4OMUKiiNuew9YbKgSjD1qw1mXxU9gzdXLOMXZc?= =?us-ascii?Q?6LM8+awqUSpPXeq2mzQ7eGuL1Shx/V5XXMs6UGeQZF+jWjx7PrrrHvY5DnXp?= =?us-ascii?Q?YORBwUfLR3tPmGnjTzJYRj97MvnVWZEZHIvvArv/HptjcYQRkAyXpwJBOYxG?= =?us-ascii?Q?MKh5TPjSWLdsyrlNzERjtmLtzVvMAVYYJAC83z0G6+TzOytVhbdgY3MdeuTB?= =?us-ascii?Q?wUFzTX4UUd4o50TPaS7TAbxeKEDqIjQ0O+jGkuOGMXU0zKi2MZCjsrSLSvUx?= =?us-ascii?Q?liYeKysqTfur+8yVV57ZOIeJIAsJLcoirPrEvILLwN8xiy5cTzIeDYfFx3Uf?= =?us-ascii?Q?7a58bn3ezt51jUlwFhXKjO/ASLyLP6zdsWtG1XZdnPL0Ra0maxxW9HGgfTj5?= =?us-ascii?Q?4E1jGrcFdbpcgxn8FZQ8moP4By7jNe5zTQrCyIQtN6XOeiwiGqPClE4hphL9?= =?us-ascii?Q?0RBixTeRpI2TUpVX8aSslBThe3UvehewYJ9Ar1nMlxa5U4nyyw++bL9Ehnsp?= =?us-ascii?Q?8rEmJ0zw4IPAy5hqhiBA7RSFciGNnkraVhpx8h9XeLHTVe/aruyg1xA42KBY?= =?us-ascii?Q?0qcmeBD781FWXV9P4ri6BVln713h33SbYlpSCfSBX6jyEH/qnO6zuujsx5Og?= =?us-ascii?Q?3b7/exA/mFQfhCf0a/nAx74pllsSuzeUkZzhrkab0UNKRfvJnrPRUk4OAQ2U?= =?us-ascii?Q?ejZZOhFpmVF+BOeQRKlkWySdgzrXBQPAIy0a/YAmronK2ib2AY4J1WLaM2+P?= =?us-ascii?Q?UOHikMPLP4jT0dk1k0OSxUgF6jmaPJNsg+3W+IHcjiy9bWEuAcW7xoPyK2Ep?= =?us-ascii?Q?n/200jNWUA=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0340; 5:YOE4VnYt2n+JhFoE+pscp80X1Rbo2hYgj0ylQXM8HZfSMIY3EvnLQJrqB9A6N2Vdx1y4V01pYb0SZku3vcoU/mdQApvZclzVycv8xSj3gnCb4cPBFKhOqczgOi14GdYHT/NEdt5tNuX/YCNV51caDA==; 24:bGAL0eI2iDjyztpseXA+5Tn65pOQjE4teW3JAxRUe+V40LqrOFnkqkZWtxNytXMKIsB0tiRSZ9VlBLqNgFB9DPhJhMTjxAN4NBsg9JLqXEQ=; 20:andtrucjdXdmZf8Zs+9JNSJaANPYfRHG9e6KS4Z+z7q7i1kb2O9DR5KIJSmQ0Pdvy4ouif77MLOFJehG6EHEXKIyogBPVHH9/2cgtBuPMy48wlHr0FW03aZ52vPykU8HrQCF011WwKhlgYMZG97ea4K2U9H7JsYixm0tYM8vvGI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2016 11:25:11.7434 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0340 X-MC-Unique: jI2TOk5jQyqU9Jf4z-HlOw-1 X-IsSubscribed: yes On Mon, Feb 08, 2016 at 03:24:14PM +0100, Richard Biener wrote: > On Mon, Feb 8, 2016 at 2:40 PM, James Greenhalgh > wrote: > > On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: > >> Hi James, > >> > >> Thanks for reporting this issue. > >> I prepared slightly different patch since we don't need to add > >> tree-vect dump option - it is on by default for all tests in /vect > >> directory. > > > > Hm, I added that line as my test runs were showing: > > > > UNRESOLVED: gcc.dg/vect/vect-mask-store-move-1.c: dump file does not exist > > > > I would guess the explicit > > > > /* { dg-options "-O3" } */ > > > > is clobbering the vect.exp setup of flags? > > Yes. Use { dg-additional-options "-O3" } instead. I don't see why this test needs anything more than the default vect options anyway... In which case, the patch would look like this. Tested on x86-64 where the test passes, and on AArch64 where it is correctly skipped. OK? Thanks, James --- 2016-02-09 James Greenhalgh * gcc.dg/vect/vect-mask-store-move-1.c: Drop dg-options directive, gate check on x86_64/i?86. diff --git a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c index e575f6d..f5cae4f 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c +++ b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c @@ -1,5 +1,4 @@ /* { dg-do compile } */ -/* { dg-options "-O3" } */ /* { dg-additional-options "-mavx2" { target { i?86-*-* x86_64-*-* } } } */ #define N 256 @@ -16,4 +15,4 @@ void foo (int n) } } -/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" } } */ +/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" { target { i?86-*-* x86_64-*-* } } } } */