From patchwork Mon Jan 11 12:04:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 59458 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp2065221lbb; Mon, 11 Jan 2016 04:05:14 -0800 (PST) X-Received: by 10.98.7.79 with SMTP id b76mr25898732pfd.40.1452513914556; Mon, 11 Jan 2016 04:05:14 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id r81si26044944pfi.191.2016.01.11.04.05.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2016 04:05:14 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-418644-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-418644-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-418644-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; q=dns; s=default; b=wu3hesSQBYfV3xYc z3tgFoWn7AoTwrfMJozCZbLm5XvpucwVcK/byuj6n4ZIylR29W9IuvtT/yEwKpHt oCr5KKhUeM0bAjXkKTHP1rLa4kir0S0zUJe+uH+CkntIzL4bM+wmPP56OewxWVk2 cJ1sav6uqJ9pzqulKb87BEgE2UA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; s=default; bh=yu0qVu2JEIi90kyMoCSA5V ngBYg=; b=RPdkX1eUNnXmNSi1pyCQGzlyrccPiN4C8SS+NwI/qTbs4iGFzqmxZ7 UIJHBm9PaoehWWW9BmI7RkN8Mdz9h012+6TsZQsfXmNqPc6SgGQoJnI3AXBKTFvj x+kHM/5xz/gNpGns0chxG5NrvPDlA079lCDFxoR+7+GgBvU1bcIsU= Received: (qmail 71176 invoked by alias); 11 Jan 2016 12:05:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 71157 invoked by uid 89); 11 Jan 2016 12:05:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1354, HX-Exchange-Antispam-Report-CFA-Test:102615245, art, HX-MS-Exchange-CrossTenant-OriginalArrivalTime:Jan X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jan 2016 12:04:58 +0000 Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1lrp0012.outbound.protection.outlook.com [213.199.154.12]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-30-EPoBDq8IR1SFE3iZf345gg-1; Mon, 11 Jan 2016 12:04:53 +0000 Received: from DB4PR08CA0001.eurprd08.prod.outlook.com (10.161.12.11) by DB5PR08MB0887.eurprd08.prod.outlook.com (10.164.43.29) with Microsoft SMTP Server (TLS) id 15.1.365.19; Mon, 11 Jan 2016 12:04:51 +0000 Received: from AM1FFO11OLC008.protection.gbl (2a01:111:f400:7e00::159) by DB4PR08CA0001.outlook.office365.com (2a01:111:e400:9853::11) with Microsoft SMTP Server (TLS) id 15.1.365.19 via Frontend Transport; Mon, 11 Jan 2016 12:04:51 +0000 Received: from nebula.arm.com (217.140.96.140) by AM1FFO11OLC008.mail.protection.outlook.com (10.174.65.109) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Mon, 11 Jan 2016 12:04:50 +0000 Received: from e107456-lin.cambridge.arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.266.1; Mon, 11 Jan 2016 12:04:47 +0000 From: James Greenhalgh To: CC: , , , , , , , Subject: [AArch64] Remove AARCH64_EXTRA_TUNE_RECIP_SQRT from Cortex-A57 tuning Date: Mon, 11 Jan 2016 12:04:43 +0000 Message-ID: <1452513883-25826-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <1452513219-25168-1-git-send-email-james.greenhalgh@arm.com> References: <1452513219-25168-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11OLC008; 1:bt/tws1Zu6VAEZdtEzLnMeeNyxoz1xSiwWOHNd4uniaoTTxbMmL33Te+xPkBFNt1n/O93oI279sfEsaY5bdPSfNRn0a+MdKOV4r/crormAT7+GCiQHX3DoTH3T4No8ssEVbqN5bYuMRxbhY/uGq+GMhG7TZtgi3VMv2T0TMwrnUXOUb1snzAqPaTlJGieT/G0UdVY2Cd+UWe8zFsHYUyZhW4VEB5ynRk4nm9VlHvfHD86vKmVshZx+XumbVjR3HWA7whbmq+eU7r6airFsKG7xOvdoKok2zo8uOPit9//GGrpgMF/ah1jbSYFEvIGvmDUdvTnwqmztdX6P+Huh/Pj0QCRSFqug5/7TB8bzHSBqNnbALkavKYhLkbamY/LZcPXmvJgwgoNd9p6fEfhxRfcMrArR8hKDijJgjb6uTv9ys= X-Forefront-Antispam-Report: CIP:217.140.96.140; CTRY:GB; IPV:CAL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(164054003)(377424004)(189002)(199003)(19580395003)(586003)(6806005)(104016004)(2476003)(4001150100001)(5890100001)(1096002)(110136002)(4610100001)(4326007)(5000100001)(36756003)(5008740100001)(189998001)(106466001)(11100500001)(568964002)(84326002)(33646002)(2351001)(87936001)(92566002)(1220700001)(50226001)(86362001)(26826002)(2950100001)(77096005)(2906002)(76176999)(50986999)(19580405001)(229853001)(5003600100002)(512874002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR08MB0887; H:nebula.arm.com; FPR:; SPF:Pass; PTR:fw-tnat.cambridge.arm.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0887; 2:X/VoNl7/UZJkZNfLOyBvaBcQCHOqc/1iDVXbKVkA5DcD12Tx0ZDMAm9eCNO2u+HLqVmNgODx0zQ94EKVRm4dtp14sscFloW1YoD/IFbHjP9pHSIstOJALEWZ3nZxnXfonpdZ9yMuQVuBNwwjyVMktg==; 3:m3W04GoiVp9XlefaJn4os/nxb8gy7dYem7dQ0U0oiHCzqep4p/2RufJPc2D7AsmvbJVHrPfr5ovKHAVforYK09MHLE7JkiURMkwSp+jN70QZ661qSl1+kIKDlDt7d2KdTMHlOg8U2bMrxt0zzW7sul/NCCcoKFUG3h8aXxU9WKr6Jh1MwFtRw9dJfL8J7zWpEbxcF72SoSwgTG3bK7KrxQth0+Dt6bYZveHdJhOvm1WygdtjOxh466h7SXQdy+seIT8zw9459hMM5x3JO7dpKg==; 25:wMprEJBJXxM/gVvq8llbfZxfM3oVFJ9i6BCShuk1rFXZy59Yoys0FY5Aufia0M4d9UvpRKd7qBhFGqaBPnAgwxq6WIK9ov+9YSf90p1GgyNrSnN15SS6sl1tL9ZLtNz47LTkmiexRQH26MMrkdqOqbNltdP9ibKrttv3mxw/Wfz4VPY1sjI0YKYRytJU0dZj3i2Q0mbKpDoFN2uOTObHuReRjqJiGP4iMOwANxi0i3v/hVM5wBfnGLJsuR63OBRI; 20:q6D9+1cz6+oXdtOGNPVOYg6EBSj9jmz1cX3/cxrvZO1nLDkf6yQ49JUxBJAvWjqSRc0gxhykqNfnH8JnJvWFppG9XSXzlyPy0utEMoyUTLzln1bR9HNeJN6vCPqt5cd28iN2lBTOc1qljQ2zD6ZcxVlqMHWvki+F3BcfvJGi9Wo= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501001); SRVR:DB5PR08MB0887; X-MS-Office365-Filtering-Correlation-Id: 7c1d4900-92a4-458b-e2c1-08d31a7f689b X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102615245)(601004)(2401047)(5005006)(13018025)(13016025)(8121501046)(520078)(13013025)(3002001)(10201501046); SRVR:DB5PR08MB0887; BCL:0; PCL:0; RULEID:; SRVR:DB5PR08MB0887; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0887; 4:xXhkhdqxEHbecWO7GDt1F1lrhD0jgffa++LiR/pQjdcqI+k6uiw6iVYoPKtDxuCcL9Mv51bbDEgN7rmownzu1BkcH8Sr55Ms9yuPsYgkZxN3Civ6XSVnGfHGlDg2iKYDTOYU/7PqKF0QsK7YFXeK9Pgh06/cNG3/W0laBrvGqY8ifgpBvndpeh2YhwI0wNsDHIOAPQSZH5lIDfKUjF65lMIyYOUiCTsMkBgzKMmp4IJR6lk6A6FojcmsszcPPRfOcd10uAdK4ZCvdiXNo1uYOMH0x0qMhD/5r7ZZJ/zavNcu+7TNne+BcoSlU/fva9cqHBinj3wtnjxUozmEvUtNB8LqKtDM6as7W8pFWIqqKJKBhXk6HiAeFqfCFVMbQ6AYL5hsHuTGEmbN3MqPlnnbGpXD8f3RyYsPjVJdsArg9bzlwrcqmYBhveSz4j1B/YYnO//HIyToA+Sc5pCzkVftWtB1asuxdKoX0HP3bMWu5zWoYMC4AgOLmuueT8sIK5Z8 X-Forefront-PRVS: 0818724663 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB5PR08MB0887; 23:rLAfokCXxAdBclqTJ5eYQuRXoxwWUgqnze9/W3dL7?= =?us-ascii?Q?dWzWP767qNCFAv2ZuphwyNrCIDB+bPw1zPTHmT/3UTjYBmx0j0zZrDHFrMxH?= =?us-ascii?Q?RHP77wOFN9jJlhiMXzwj6Gg98GTH7OfiiMksJ4SSyK6+M+Us+C/rkCGBnriF?= =?us-ascii?Q?SGST7PT3L6Sb/DgKem27fLjiRM2aPogiipjLOX5RG+MGc8paGsLWcxbKs3XC?= =?us-ascii?Q?zxsU3cbzJJlwl6MAc+vVPUZu+mrvv4kMt6Mv795NyZn0zifFjKKz+J3rOh5U?= =?us-ascii?Q?RZGneGL7zwk1pcl0KrwcebWF9clLel5q7EtzAx/DzOdG8lgM5c7U3rHTR343?= =?us-ascii?Q?k00GDHFsLTxCKMGuYw5ULDfJ+iqgmNf/Azwm34VCI0RfiurSygxUvrLrzUFl?= =?us-ascii?Q?gY6c5BjmIyP/cUkaXq7r3doIsOGPTknqkwPLDqlQLMRHJpFOqjhio0p0rve6?= =?us-ascii?Q?wH/feg18QoAehQBTOVLrKaMa4BncPOVyoteoLYBtgiJdsBOUQxWscVzb77CK?= =?us-ascii?Q?lYc00g6IRpevyB+BNFSZc9J8I1iBYKa48f+R08rBpe6TGILQlo70DKCSlOHN?= =?us-ascii?Q?Sa30UAsB3T9ovm7kqaFCWSosqn6mze4+lnCbgMv/GOoiOhgYLNyChbXMJLAO?= =?us-ascii?Q?X8IlnoKQIewweMdFoK5BmvShM59+Gub7Rxd4tlY5v/9tOvaCYl4rYjfDGXQM?= =?us-ascii?Q?x3TahxmgmFKY+AqrxeXszyTz0xCBcUGslVlPjw6IBPvM2XzRo/7x0szUDsGH?= =?us-ascii?Q?SOxRlUlwGn4S8CBJkeaxPoOJwJL9zYt6pv4oDabULJfOUUfleS7cD0n9YWnl?= =?us-ascii?Q?s5tUezBV347oM0MgIPdnO/WKSwXZw5OlqMRcerndB1JlrO9YK2aJ+n86EJNc?= =?us-ascii?Q?KDVgyAio0kBvJAUiQP65LVMp7DDKiLozBt03rxFB/PoDTP5MGaoHYmwhqQ6x?= =?us-ascii?Q?YDZG+Iaatfy5cGogyEs+1ESOXFN8rCmI7sK5id+yBmM8CJsOw85wzLF7rZ0T?= =?us-ascii?Q?z0hayquY0zhROoijHfwlxmEZy3jn9BpLpYf17JjnYMAORhdfS6rt5OyQGMJs?= =?us-ascii?Q?Qtuj8JZFaP+Ro61j2ZQm7NHn3DNAcSUDsHDPSKr5eaYT+esaHhSdCn63QfIO?= =?us-ascii?Q?uJguRRtFAbRnsNifhcngbkx3/TjbtULgEr0Ezvq+aB2L9xYS+2D6Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0887; 5:8QizfLZyzV9ApfCvJwBnnj65IIVKfWpybYMdemmCRnlppFfokYGmYnBUvkIcBFGBar5qZOwrCCKyqHbrUpUz8eFU7yVXvJz9hDKiyVp8D78jsa22SY/hI7Gpat9VMFnsNX7400aqIihA9/cmIjDweA==; 24:H5mBoVKUhK6iq7Crc+dkI1LdC2oRGJh1K4GcwX28m3XDoYnJC0TSNpxryEkzWmkFk0YZ6PSBqFAxtYvOc6cIVoskwkJArEraf/3zABUurbI=; 20:zwrurdFz+GYtUEsAWZWpgUfg5/mCjKXLkAqEv1owv8rYl98i015dlNw7b1Q3JBt0x3Vyg0pC9MqdH6yFJ0DEPPe3wl2CPT+3OXrsnAkpw3Wu2Qf4a0vkSfKn5qQC1btmJAeCiY29BR+e+JhZSCaRNoI1Ux4CgP5EVAioyXJal+8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2016 12:04:50.5247 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0887 X-MC-Unique: EPoBDq8IR1SFE3iZf345gg-1 X-IsSubscribed: yes Hi, I've seen a couple of large performance issues caused by expanding the high-precision reciprocal square root for Cortex-A57, so I'd like to turn it off by default. This is good for art (~2%) from Spec2000, bad (~3.5%) for fma3d from Spec2000, good (~5.5%) for gromcas from Spec2006, and very good (>10%) for some private microbenchmark kernels which stress the divide/sqrt/multiply units. It therefore seems to me to be the correct choice to make across a number of workloads. Bootstrapped and tested on aarch64-none-linux-gnu with no issues. OK? Thanks, James --- 2015-12-11 James Greenhalgh * config/aarch64/aarch64.c (cortexa57_tunings): Remove AARCH64_EXTRA_TUNE_RECIP_SQRT. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 1d5d898..999c9fc 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -484,8 +484,7 @@ static const struct tune_params cortexa57_tunings = 0, /* max_case_values. */ 0, /* cache_line_size. */ tune_params::AUTOPREFETCHER_WEAK, /* autoprefetcher_model. */ - (AARCH64_EXTRA_TUNE_RENAME_FMA_REGS - | AARCH64_EXTRA_TUNE_RECIP_SQRT) /* tune_flags. */ + (AARCH64_EXTRA_TUNE_RENAME_FMA_REGS) /* tune_flags. */ }; static const struct tune_params cortexa72_tunings =