From patchwork Fri Nov 11 15:07:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 81848 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp1313554qge; Fri, 11 Nov 2016 07:07:39 -0800 (PST) X-Received: by 10.98.196.199 with SMTP id h68mr7714563pfk.120.1478876859228; Fri, 11 Nov 2016 07:07:39 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id a17si10637261pgh.22.2016.11.11.07.07.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 07:07:39 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-441113-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-441113-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-441113-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=AorL8BNhA4eBaeaq+ kR+u7nzv3YdBICqDNALEgQ0iE/hS4HD/ubjb5dmngHd3acmjKYqtMvXQrUiufDte VMPPPiEdJA0cau/b8MyZO26H7m4AuilDTJZvOTzfOApuDhoZVKkCsPDQYQ7FDDb6 AHnlcI5cJM5v+ErMYBZxTSyD/k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=4H6Y9LjKUdOHF0Lhf3OnbCU 6wEQ=; b=Cgxp4PS+nJUdEiPWACcqpF6jrLOAWIGwDl7GFM33lLRFtfPLzBzXODY n0eSXvAlnIIXaYDR5InF9/hH3l2iHvwvQzrLHc6ZqGoooAWl7GlQ/1sor2ROu++u /8ogXcWe4trqG2wQQQKGSUDp8Ndc2YgdxPOqdc+CsYSoetSalHPA= Received: (qmail 126553 invoked by alias); 11 Nov 2016 15:07:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 126542 invoked by uid 89); 11 Nov 2016 15:07:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=newlines, Hx-languages-length:2177, 2369, 20161111 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 15:07:13 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B11A0AAD1; Fri, 11 Nov 2016 15:07:11 +0000 (UTC) Subject: Re: [PATCH] Support no newline in print_gimple_stmt To: Richard Biener References: <56f3378c-e4ed-6120-4057-fdc2c2d9428d@suse.cz> Cc: GCC Patches From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <0c1c1737-52d1-61dc-f088-7f62c5dad894@suse.cz> Date: Fri, 11 Nov 2016 16:07:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-IsSubscribed: yes On 11/11/2016 01:10 PM, Richard Biener wrote: > On Thu, Nov 10, 2016 at 4:36 PM, Martin Liška wrote: >> I've just noticed that tree-ssa-dse wrongly prints a new line to dump file. >> For the next stage1, I'll go through usages of print_gimple_stmt and remove >> extra new lines like: >> >> gcc/auto-profile.c: print_gimple_stmt (dump_file, stmt, 0, TDF_SLIM); >> gcc/auto-profile.c- fprintf (dump_file, "\n"); >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> >> Ready to be installed? > > Err, why not just remove the excess newlines (and drop the ' quotes)? OK, let's do it simple ;) There's a new output: Deleted dead store: *p_2(D) = 0; Ready to install the patch after it finishes regression tests? Thanks, Martin > > Richard. > >> Martin >From c781ca49f502b205d55f411051a3e9881d2c9d7b Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 11 Nov 2016 15:51:22 +0100 Subject: [PATCH] Fix dump output in dse_optimize_stmt gcc/ChangeLog: 2016-11-11 Martin Liska * tree-ssa-dse.c (dse_optimize_stmt): Remove quotes and extra new line. --- gcc/tree-ssa-dse.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/tree-ssa-dse.c b/gcc/tree-ssa-dse.c index 372a0be..778b363 100644 --- a/gcc/tree-ssa-dse.c +++ b/gcc/tree-ssa-dse.c @@ -236,9 +236,9 @@ dse_optimize_stmt (gimple_stmt_iterator *gsi) if (dump_file && (dump_flags & TDF_DETAILS)) { - fprintf (dump_file, " Deleted dead call '"); + fprintf (dump_file, " Deleted dead call: "); print_gimple_stmt (dump_file, gsi_stmt (*gsi), dump_flags, 0); - fprintf (dump_file, "'\n"); + fprintf (dump_file, "\n"); } tree lhs = gimple_call_lhs (stmt); @@ -292,9 +292,9 @@ dse_optimize_stmt (gimple_stmt_iterator *gsi) if (dump_file && (dump_flags & TDF_DETAILS)) { - fprintf (dump_file, " Deleted dead store '"); + fprintf (dump_file, " Deleted dead store: "); print_gimple_stmt (dump_file, gsi_stmt (*gsi), dump_flags, 0); - fprintf (dump_file, "'\n"); + fprintf (dump_file, "\n"); } /* Then we need to fix the operand of the consuming stmt. */ -- 2.10.1