From patchwork Wed Apr 16 07:46:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Ye X-Patchwork-Id: 28451 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f70.google.com (mail-qg0-f70.google.com [209.85.192.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 252D52036A for ; Wed, 16 Apr 2014 07:46:52 +0000 (UTC) Received: by mail-qg0-f70.google.com with SMTP id i50sf6014368qgf.1 for ; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:x-original-sender :x-original-authentication-results:content-type :content-transfer-encoding; bh=VTBRAl2sOkJ6FfHQiTlz2okyQKzanpZ+5hwZFRPk0a8=; b=BQ+dSWhWsWwJlHyaFQUnxp2b/XMFc9bUGLnKegz6z0D+ASb/HehkIdX5opaK3nmCpJ SQXh05fXqKRE1bnag3rP2c4uyZddfFTCRkbtOdjGj+QcPp8vIxTdZ/aLt02ksk9TEd9+ F9GiaQaO0HjiyBNoh6jXiVKa1RKwNDoX8hLvx7mqixfKVmlQr9UdOm39ikocAwqjCFmt D2PZ4WW42ArnAyO7sKSMgDnOwt84fMuVUr1pQnrkEIQMwV1lGqf1UO/JEmAUgFX1lHmX ArNzL4WJCkFUUCeM1MAf9hCzvKKaUkwf74/+A/Jums8SOedB6QDTymPuFSDi/xXYMRS6 MPlw== X-Gm-Message-State: ALoCoQlEePnvcDAtcNxv8YJWrEnHGcchtT6OpjCBRK0Rn0aPqSL9j29vLuGzATS7hA/aOMIqrnTk X-Received: by 10.58.248.99 with SMTP id yl3mr3509275vec.9.1397634411927; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.100 with SMTP id u91ls485578qgu.74.gmail; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-Received: by 10.52.191.100 with SMTP id gx4mr1399079vdc.4.1397634411866; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) Received: from mail-vc0-x235.google.com (mail-vc0-x235.google.com [2607:f8b0:400c:c03::235]) by mx.google.com with ESMTPS id cx1si2424585vdb.182.2014.04.16.00.46.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Apr 2014 00:46:51 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c03::235 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c03::235; Received: by mail-vc0-f181.google.com with SMTP id id10so10120233vcb.26 for ; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-Received: by 10.58.96.36 with SMTP id dp4mr791608veb.21.1397634411586; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp292081vcb; Wed, 16 Apr 2014 00:46:51 -0700 (PDT) X-Received: by 10.66.142.73 with SMTP id ru9mr6849652pab.41.1397634410862; Wed, 16 Apr 2014 00:46:50 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id tk5si12226283pbc.295.2014.04.16.00.46.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Apr 2014 00:46:50 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-365142-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 28515 invoked by alias); 16 Apr 2014 07:46:39 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28505 invoked by uid 89); 16 Apr 2014 07:46:38 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Apr 2014 07:46:36 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 16 Apr 2014 08:46:33 +0100 Received: from SHAWIN205 ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 16 Apr 2014 08:46:47 +0100 From: "Joey Ye" To: "'Richard Biener'" Cc: "'GCC Patches'" References: <000001cf584e$66102060$32306120$@arm.com> In-Reply-To: Subject: RE: [patch] Disable if_conversion2 for Og Date: Wed, 16 Apr 2014 15:46:44 +0800 Message-ID: <000301cf5948$05399190$0facb4b0$@arm.com> MIME-Version: 1.0 X-MC-Unique: 114041608463310801 X-Original-Sender: joey.ye@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c03::235 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 > -----Original Message----- > From: Joey Ye [mailto:joey.ye@arm.com] > Sent: Tuesday, April 15, 2014 6:37 PM > To: 'Richard Biener' > Cc: GCC Patches > Subject: RE: [patch] Disable if_conversion2 for Og > > > Ok for trunk and branches after a while. Why does if-conversion not have > > the same problem? On the GIMPLE part we avoid all kinds of if-conversion > > with -Og. > I think if-conversion should be disabled for Og too, but I don't have a case to > show that it is harmful. If GIMPLE avoids all if-conversion, it is nature to do > the same for RTL. I'll test and send another patch to also disable if-conversion. New patch tested with more regressions with -Og, which are expected. FAIL: gcc.target/arm/its.c scan-assembler-times \\tit 2 FAIL: gcc.target/arm/pr40956.c scan-assembler-times mov[\\\\t ]*r., #0 1 FAIL: gcc.target/arm/pr42835.c scan-assembler-times moveq[\\\\t ]*r.,[\\\\t ]*# 1 FAIL: gcc.target/arm/pr42835.c scan-assembler-times movne[\\\\t ]*r.,[\\\\t ]*# 1 FAIL: gcc.target/arm/shiftable.c scan-assembler sub.*[al]sl #6 FAIL: gcc.target/arm/thumb-ifcvt-2.c scan-assembler asreq FAIL: gcc.target/arm/thumb-ifcvt-2.c scan-assembler lslne FAIL: gcc.target/arm/thumb-ifcvt.c scan-assembler asrne FAIL: gcc.target/arm/thumb-ifcvt.c scan-assembler lslne FAIL: gcc.target/arm/vseleqdf.c scan-assembler-times vseleq.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vseleqsf.c scan-assembler-times vseleq.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselgedf.c scan-assembler-times vselge.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselgesf.c scan-assembler-times vselge.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselgtdf.c scan-assembler-times vselgt.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselgtsf.c scan-assembler-times vselgt.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselledf.c scan-assembler-times vselgt.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vsellesf.c scan-assembler-times vselgt.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselltdf.c scan-assembler-times vselge.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselltsf.c scan-assembler-times vselge.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselnedf.c scan-assembler-times vseleq.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselnesf.c scan-assembler-times vseleq.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselvcdf.c scan-assembler-times vselvs.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselvcsf.c scan-assembler-times vselvs.f32\\ts[0-9]+ 1 FAIL: gcc.target/arm/vselvsdf.c scan-assembler-times vselvs.f64\\td[0-9]+ 1 FAIL: gcc.target/arm/vselvssf.c scan-assembler-times vselvs.f32\\ts[0-9]+ 1 OK? ChangeLog: * opts.c (OPT_fif_conversion, OPT_fif_conversion2): Disable for Og. diff --git a/gcc/opts.c b/gcc/opts.c index fdc903f..3f3db1a 100644 --- a/gcc/opts.c +++ b/gcc/opts.c @@ -431,8 +431,8 @@ static const struct default_options default_options_table[] = { OPT_LEVELS_1_PLUS, OPT_fguess_branch_probability, NULL, 1 }, { OPT_LEVELS_1_PLUS, OPT_fcprop_registers, NULL, 1 }, { OPT_LEVELS_1_PLUS, OPT_fforward_propagate, NULL, 1 }, - { OPT_LEVELS_1_PLUS, OPT_fif_conversion, NULL, 1 }, - { OPT_LEVELS_1_PLUS, OPT_fif_conversion2, NULL, 1 }, + { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fif_conversion, NULL, 1 }, + { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fif_conversion2, NULL, 1 }, { OPT_LEVELS_1_PLUS, OPT_fipa_pure_const, NULL, 1 }, { OPT_LEVELS_1_PLUS, OPT_fipa_reference, NULL, 1 }, { OPT_LEVELS_1_PLUS, OPT_fipa_profile, NULL, 1 },