From patchwork Mon Nov 27 15:41:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 119738 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp439054qgn; Mon, 27 Nov 2017 07:43:13 -0800 (PST) X-Google-Smtp-Source: AGs4zMaDNu9WMMDwrk1pQb+tGBQ9UFBtIUkrYPQZjUbmPwdUs6NtAo/ZT9UiAR4WOhtSE7ZVhbGf X-Received: by 10.101.100.65 with SMTP id s1mr37340351pgv.185.1511797393098; Mon, 27 Nov 2017 07:43:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511797393; cv=none; d=google.com; s=arc-20160816; b=xAGgGu8MpSdVoB8fGxe+WfHHHv8mRUnuWqiNEjRvs8CyLCNGjihm/VxaQI6Q5bMnH4 nsZ6Vxim/w1rSr7Tw6/l9uW4SXMxHdMTFaWz49J7WyDgs7lDSEIvsXQA1UOWpHxo0Dzh KYElnH3KVdRy4lezlpepo7I5tB9i4+hvWvZv4nARNg4Qx7c4cGOwG3XLtnwktbrbC7C6 vhwUuoWsyVwlINLGLS7fByBGQX5q8B1ic+w+gySXK+3DELAjw6SFBhDQrseVs8oCDN4J CaKW8sbgY/4AWJ+T2AQdff11uW3lYsb0F+A1ikZ9q4ahBvCVlR59eKwXJuyAkJuuPFPI PO3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:cc:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:delivered-to :arc-authentication-results; bh=nWIuQfRzPrwoV6uVxL4cQvc+H548EEwDWF9XnTafyhE=; b=N1FKVMzX4gmnejxh01oOjysWqBc6s1px0TsSyb/sswNprOXR8QGYOAtusnp57nY6lL N6fX5R4gMkAhad8z9nBWE63ne1Gp8wJyDVzbEbCMJ1L8EHAPdwlR4QwGsRKeRGbSvJti BBuWjfPMXXM9wvMJvZfeb1F/4zUj3z0+i8RFJY1w8eegzuOKk7/W5X5mXuhbd2oj3IrP zBqQkLCqlc3W4mALnTOzLN5w88QGHulY45lbNsyRW3kAKwgZyK1QqP6A8aZJkanbQxQ+ hHDDHIBdkae0eoSoQ4/d2rxp1bi4zrEnXnuCfcMfOdv98091pCBhB3tCinpC0PxRJ3Ix 9PfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w4si24056698plp.452.2017.11.27.07.43.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 07:43:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEAEF6E317; Mon, 27 Nov 2017 15:42:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 474EB6E305 for ; Mon, 27 Nov 2017 15:42:03 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 2B586213EE; Mon, 27 Nov 2017 16:42:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [185.94.189.187]) by mail.free-electrons.com (Postfix) with ESMTPSA id EECF2213EB; Mon, 27 Nov 2017 16:42:01 +0100 (CET) From: Maxime Ripard To: Daniel Vetter , David Airlie , Chen-Yu Tsai , Maxime Ripard Subject: [PATCH v2 05/18] drm/sun4i: Force the mixer rate at 150MHz Date: Mon, 27 Nov 2017 16:41:29 +0100 Message-Id: <55becb3a86a0a28ccca3f7c831ac6f6cf4854390.1511797218.git-series.maxime.ripard@free-electrons.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Cc: Mark Rutland , Thomas Petazzoni , jernej.skrabec@siol.net, plaes@plaes.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It seems like the mixer can only run properly when clocked at 150MHz. In order to have something more robust than simply a fire-and-forget assigned-clocks-rate, let's put that in the code. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c index cb193c5f1686..c0cdccf772a2 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c @@ -315,6 +315,13 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master, } clk_prepare_enable(mixer->mod_clk); + /* + * It seems that we need to enforce that rate for whatever + * reason for the mixer to be functional. Make sure it's the + * case. + */ + clk_set_rate(mixer->mod_clk, 150000000); + list_add_tail(&mixer->engine.list, &drv->engine_list); /* Reset the registers */