From patchwork Mon Jan 1 11:55:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 123053 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp7798164qgn; Mon, 1 Jan 2018 04:11:08 -0800 (PST) X-Google-Smtp-Source: ACJfBouXhIbnho5cGKUGAYFlcbR/vvjrchkLGECqdvoarppmG3lkggqokgqrRsYTOEKGjA2h5RXn X-Received: by 10.84.140.5 with SMTP id 5mr42326611pls.149.1514808668533; Mon, 01 Jan 2018 04:11:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514808668; cv=none; d=google.com; s=arc-20160816; b=Jl6K911klz6ptviL5/wtm0/aIevahPN1mt38G/gT2QhGgfoo/lt2hHQa8XvnO46ehs xZXN9/Tha4KHZO9QYL76yOS3YQsTO9B/uyMpEy4PPMhcWhdiU8XbcsBRrrqtTGJavbp1 uZCng+By7suGP0fKhpNG8yVsseCHGDxGPdXGh+33BOhmfuBJaxq2fVPW80Zgapo/+Fti bedpK3ElHkTx9WROHHiYkgFmVfeJ1P3QBlJEoMOi/cQUOEwTlp7WWA/U+1Fzy6JbwHjz 7t8a1vL3kkdVnynHcAOVUGfkC/R9BLCHrzH8grMFVU1rhjDZoqqAoGzz6uEeR62Q5Mxe Ktgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:cc :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=5HebNJdZ6+WoyKGuon7aFyEO6u2DbSWJJjXoV7bWFZo=; b=d9fvKVM72uqC/W0mSNj92QXlAANoUmkWVBcEmCWVWk/ixdyVYiGgGzDCy7tCGTEprw VepUZU518tSfYKkfe1/eli6FjLEOonsN+r7LpLJkr8iOKMuIym44wiZPimeGIQeJ5v4B 1rqs9104zO4oM6Nehw9gDYK9Aphoj2rEJfUhfPQ6mzv+5ay5AZO1nPF2dEG8nRMscvmD 0oUM8ESmj2Ct7WNM8bs1b9PgVkEfDLqmMFYl3hxXwxzWbKXJ3pycwriaf0ZyB9j5onWb mN6MAUQqzYsDj01aG0jrNamxXtRbK/1YXA2pDAZPB2AQOuHV2DFN3FV5HUFaQR0q9/h0 Zyog== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=tG97vG00; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id v201si22099379pgb.164.2018.01.01.04.11.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jan 2018 04:11:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=tG97vG00; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C9F7897FF; Mon, 1 Jan 2018 12:11:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 939 seconds by postgrey-1.35 at gabe; Mon, 01 Jan 2018 12:11:04 UTC Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41A9A897FF for ; Mon, 1 Jan 2018 12:11:04 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id w01BtKUR012564; Mon, 1 Jan 2018 05:55:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1514807720; bh=QZWnGoqy/jp4fcUlopL0BxWVxBvTjl0DMVaQd5iI8OY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=tG97vG008120vYUZi1FQyLK1A2ncBk0Vw8EmbcrMpCO0E7401BrrulS3J4s2iOmeP r7L6C7eFTkYq22KPs4FZ8xXpKNHFFz/UE+Ado5mVtjA5hCP4jeMR/4mm/hPM6r53KC 4o9LV4C0TUhS1EiyLAhoBCU5/1B63N/oop+jmA+U= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w01BtKFk019720; Mon, 1 Jan 2018 05:55:20 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Mon, 1 Jan 2018 05:55:20 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Mon, 1 Jan 2018 05:55:20 -0600 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w01BtGip019402; Mon, 1 Jan 2018 05:55:18 -0600 From: Jyri Sarha To: Subject: [PATCH v2 1/3] drm/omap: Fail probe if irq registration fails Date: Mon, 1 Jan 2018 13:55:10 +0200 Message-ID: <50a32bad6a2bf029100e00d06fa8d26805235213.1514807171.git.jsarha@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, Jyri Sarha X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Call to omap_drm_irq_install() may fail with an error code. In such a case the driver probe should fail. Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index dd68b25..5fe2fcb 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -321,9 +321,9 @@ static int omap_modeset_init(struct drm_device *dev) drm_mode_config_reset(dev); - omap_drm_irq_install(dev); + ret = omap_drm_irq_install(dev); - return 0; + return ret; } /*