From patchwork Wed Jun 2 14:32:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 452529 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp628656jao; Wed, 2 Jun 2021 07:33:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjqIu3zD0UzT72kzd+uSC2p74u/H4dpT0H9ojlDYFNIubSAIcK5x9Zis+UafqjBQuTK0+b X-Received: by 2002:a63:34d:: with SMTP id 74mr21951520pgd.128.1622644438383; Wed, 02 Jun 2021 07:33:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622644438; cv=none; d=google.com; s=arc-20160816; b=DiPWXzWjj2sJEBIs7XgEbt0ry2kaEys4oCGBS3WZgZGlsOT/EzJtF6MoHykJfSKjTV qFcdinY3GSG6kyXdy0iwPcISrCBrR3JVYToae17fj4i1VEuym7YBS0+IUTtlL+sLET5p 1jjg9pEjHLezqO9FP/3MaDLMMnAIKIfF85HhTYBjnXYV4kT/5Ae0qPvbALZ5/Rstz2OP nOxlyy227EJTwdjy0OgiC7P+xIga6XyW1LLMcWhQFMqpdk8d8UGiuDUQGaEJoQgi7skb jHFhs3GGA/G51HrZZbE5wVKr5M+MtrUhjhZtEUmi9rfTUBeZDrIBs7XePycCoBI0XeeL 6MVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=t1FEEZ6P0S4l/25hBadFVgOVdkrL3aHOBAeW0vMC5CA=; b=giQ7TGxw/SfYiUHi8/0JGCBqVKBOqlQF0ejsCBmlUZikBArGrP2JGjfgE3liZAAGPn aTnWnloItiG6mka+n/xgZLaGtZO8VLZ46x745WIz2TGSzLFM4zbEFGROFoLWWWenjUOx IOxA2ie3RLdyEqyFd1VO5NQm0NZQf3T0pwlxCpeo54jJ3kZ53pkVfO0/WgwGjjUyc3TC M7nn7fCym5f6+21p8OiZ/T+6vMG+IQh7RQAGeD/BnQtq2QUCEM8VjVklM9lTxyQ48Ivz kWacyf3tzo6xmUV6L52bz8KaIKGyTL0gkQPQS0jxV3byjKZgB8jxHB8fyGATY4WcWL9u ji0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nVd+6txb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id b15si12855241pft.5.2021.06.02.07.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 07:33:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nVd+6txb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 837576ECD3; Wed, 2 Jun 2021 14:33:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id E193E6ECCD for ; Wed, 2 Jun 2021 14:33:36 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id o127so1445757wmo.4 for ; Wed, 02 Jun 2021 07:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t1FEEZ6P0S4l/25hBadFVgOVdkrL3aHOBAeW0vMC5CA=; b=nVd+6txbGTkvd96oaTKfulBS8JwdcjwEWSIdrGauDfuARuO8ZRkTn5cTMhfdV6roe/ cwP6oO1NmBUt8tuY0zeyaNsQEFZqw1HpHYvfsM1GHddzEOe3Ks+SLzyV/BmZxgFR3Y/j adKn13qmTK8EYIIfEKpiTryxiYMPefvNxH1uQMoK7to9/l3I6opm9WKt8BYa5VzcxUug zt9Rl6tsSESUE5RozQ/us7RYglBBX9AXrcQRfvLqcAuM/cLbWyOB+grqCDYSNzwibxnO P8jt2qL3RrOVVj8Lyfq+0yrt4uigX2fLTFeIvrUrxuYmpvA8cjeygpsiaeCO9Hpg+t2y u+Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t1FEEZ6P0S4l/25hBadFVgOVdkrL3aHOBAeW0vMC5CA=; b=JFz6sLvtY8c0tOeNN8AJ+RLywEMCT0PEARgEoreCMuY42Wu47smXEy+mRJ1stndz3t kgk1lz2Jx/+IDDMZGCJX8zYUYrN4HhSi3ccfjHpAkmYor0o86jfBO50vdWDHggJl4/ot ti1tot5/FGgtT+5nhKz2KgIFUGfqrx/X5FMgyZKMvXLJYq+JffwWwQ6FM6dAajhtHhbv uCsNFlTHQlKHs5hZEb8BJbCGuZjHrExSUDP5dkU0CDr+XlfEWSvUO5YV/bi1mKSenvbG aW5kUYokjrZL2+oQmLEjAMP2p7WLj1SFrgphYVW41xr2ZGzWG6JfkWasEWVC8oFKH1hn UDrw== X-Gm-Message-State: AOAM533210m4me/M9ICQ1KJz/hIOQ3FbLfMSQLuhMvXTCHUeT2FQqXB0 rLAlVBKWHsFxxwEInyEHAE1btt6AcMwx6Q== X-Received: by 2002:a05:600c:22d7:: with SMTP id 23mr5327853wmg.119.1622644415687; Wed, 02 Jun 2021 07:33:35 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id o11sm132315wrq.93.2021.06.02.07.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 07:33:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers Date: Wed, 2 Jun 2021 15:32:59 +0100 Message-Id: <20210602143300.2330146-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602143300.2330146-1-lee.jones@linaro.org> References: <20210602143300.2330146-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Hans de Goede , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vboxvideo/hgsmi_base.c:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/vboxvideo/hgsmi_base.c:42: warning: expecting prototype for Notify the host of HGSMI(). Prototype was for hgsmi_send_caps_info() instead drivers/gpu/drm/vboxvideo/hgsmi_base.c:74: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/vboxvideo/hgsmi_base.c:102: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/vboxvideo/hgsmi_base.c:174: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Hans de Goede Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vboxvideo/hgsmi_base.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) -- 2.31.1 diff --git a/drivers/gpu/drm/vboxvideo/hgsmi_base.c b/drivers/gpu/drm/vboxvideo/hgsmi_base.c index 361d3193258ea..8c041d7ce4f1b 100644 --- a/drivers/gpu/drm/vboxvideo/hgsmi_base.c +++ b/drivers/gpu/drm/vboxvideo/hgsmi_base.c @@ -9,7 +9,8 @@ #include "hgsmi_ch_setup.h" /** - * Inform the host of the location of the host flags in VRAM via an HGSMI cmd. + * hgsmi_report_flags_location - Inform the host of the location of + * the host flags in VRAM via an HGSMI cmd. * Return: 0 or negative errno value. * @ctx: The context of the guest heap to use. * @location: The offset chosen for the flags within guest VRAM. @@ -33,7 +34,8 @@ int hgsmi_report_flags_location(struct gen_pool *ctx, u32 location) } /** - * Notify the host of HGSMI-related guest capabilities via an HGSMI command. + * hgsmi_send_caps_info - Notify the host of HGSMI-related guest capabilities + * via an HGSMI command. * Return: 0 or negative errno value. * @ctx: The context of the guest heap to use. * @caps: The capabilities to report, see vbva_caps. @@ -71,7 +73,8 @@ int hgsmi_test_query_conf(struct gen_pool *ctx) } /** - * Query the host for an HGSMI configuration parameter via an HGSMI command. + * hgsmi_query_conf - Query the host for an HGSMI configuration + * parameter via an HGSMI command. * Return: 0 or negative errno value. * @ctx: The context containing the heap used. * @index: The index of the parameter to query. @@ -99,7 +102,8 @@ int hgsmi_query_conf(struct gen_pool *ctx, u32 index, u32 *value_ret) } /** - * Pass the host a new mouse pointer shape via an HGSMI command. + * hgsmi_update_pointer_shape - Pass the host a new mouse pointer shape + * via an HGSMI command. * Return: 0 or negative errno value. * @ctx: The context containing the heap to be used. * @flags: Cursor flags. @@ -171,9 +175,10 @@ int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags, } /** - * Report the guest cursor position. The host may wish to use this information - * to re-position its own cursor (though this is currently unlikely). The - * current host cursor position is returned. + * hgsmi_cursor_position - Report the guest cursor position. The host may + * wish to use this information to re-position its + * own cursor (though this is currently unlikely). + * The current host cursor position is returned. * Return: 0 or negative errno value. * @ctx: The context containing the heap used. * @report_position: Are we reporting a position?