From patchwork Mon Mar 8 09:16:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395372 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1546270jai; Mon, 8 Mar 2021 01:17:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaL7lwSw14EWELCojmH7+1Y7N/qN6eT8Bq3pJjGY87Iqd15b1aXM0j7CTpBFb6yOfdcE0w X-Received: by 2002:a17:902:d481:b029:e4:8afa:8524 with SMTP id c1-20020a170902d481b02900e48afa8524mr20148417plg.52.1615195025993; Mon, 08 Mar 2021 01:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615195025; cv=none; d=google.com; s=arc-20160816; b=JqX9EiuT2fiEXwG1PEXVtJDCqNsJYX6zUhg7w2HWgdqjISiZdyxxojkYxixHXQGAtD 3ezAt+X3q76Wb9enQd8GFrwmvcXel6RArP4MbJVdtEwYNVUFk4fSSCssGfI+9894uubD 56EM2Zq+W3rOx0wyrSlhTpVPqSEhYgtsAFdMf6Ix0HeunhNVNwLoR+jpyU0DyfhDrHY5 1lMApByxY8CjDzixATM3O8PN05V13WCC9X8hEaIOqgMfpfo8zlrdYAWfu8JXDx13EA69 rjQLdA5LFX5TZ9XVzzTT86brpiDcOQaLEaKff+cwtZAtblaRoBNrKU6zRDiC0d4ajtXH 1kZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=OSH1tdk71siA+L8I4oWGHr7gNJCPHLxAbaOhafupgHc=; b=we5okHqnanYeWPyRVLEI8PlqD3AddAKIVFQWGiICAePIj38YAXrqs3ImU++3hMM0aq FOrQd8eEE3VWBE4NjmM1Ng00PRC0zoV6DM3vRXzpOaSTpo2dIi9LWqxhOC4wiWDmN4Zu 3A/v6yyFgCZy9lsl/n5cuuLpTqTa6cdxc5JauF3vTxo+Qbp5vNJRFNek+3GhfuGcOCbL hV0J5uYmHAECIq7r9qVgQUs2hru3KaxGrr9a/T/KWSsjkM0228XxfXrFwwC0aweP+oxa PZv9Dkl52DqFK41JFsrVuAblroDECGHp4QcuaTULcJixtcC1O8D2xIRiiFOM8OHpH/38 VjNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xJPJiPhL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id mu11si3480353pjb.68.2021.03.08.01.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 01:17:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xJPJiPhL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C7796E83F; Mon, 8 Mar 2021 09:16:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 643756E83B for ; Mon, 8 Mar 2021 09:16:58 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id l12so10609405wry.2 for ; Mon, 08 Mar 2021 01:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=xJPJiPhL2CvJWDgXMAAvBiTvcIxvXystP9YkIlHtva74Kx3KKrXMzr5ExU/2veL6gL JN0tiwqQkJZE+39MgAeg+OMCaGrK8S9+YOsDQDWd+3dTc2g301WBoII1352/ShtfExle I8X285pwmJ87QjUDuabk+LHDri4SK9gCM4d4FWGSbxLmNabTDCCbOJ7VDDWJcvzONPg+ GTa5resMnc34uJs35KxsGGVOTP1jPcf82BNAgk1ep7qrWnin5hljOJvwHYhTfXPo8NMC kc9OFA5NMopEHc1N0LYFDbP7CVmW4PVVBBE9rTuMk3CceWr7P4Tmd6BHvIh5c+x1JqKL Y8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=WJW9yoYkM48MKCqDWt6/hh4O2ic9Q1HZ7nKOMK9qATN2Tc9FrvHnqeO9o60FV7r/6D IzMmFWFCx3At542yvna1s6uNTcJaVLDtVXDFXjAQ+jP7hasVQqCz7R9IyS7bOqw78lxX ggxt6B8KM1x7V6qrlLq36LbbahNEQWkOa5Xo601Ynm6bXHazOHJ8xeYZ0SDmDfT6+aDk TFQtRjSQxd3ZcfQiGDyRtT2Vbu9GeVze76v94xgd6uc4dPz5uxTnsrAEZts6310hEkyu Mjj4FI2+OiCLiPm462gTNd2YbCd6cKjcUxiHj/ab3mqQFmVF6KEEQJO3F3tGGoR1Vl/V F4kg== X-Gm-Message-State: AOAM532b/wlXYQG0ic7IA7thYZ1gHT8QC3kBLj9ldTzZLB7RYDU6cQkV j3hV2kM/eGFvIAOXZJ+seflLyg== X-Received: by 2002:a05:6000:1107:: with SMTP id z7mr1424030wrw.415.1615195017010; Mon, 08 Mar 2021 01:16:57 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id i17sm6068135wrp.77.2021.03.08.01.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 01:16:56 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v5 4/4] PM / devfreq: lima: Use devfreq cooling device registration Date: Mon, 8 Mar 2021 10:16:45 +0100 Message-Id: <20210308091646.28096-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210308091646.28096-1-daniel.lezcano@linaro.org> References: <20210308091646.28096-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:DRM DRIVERS FOR LIMA" , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS FOR LIMA" , steven.price@arm.com, Qiang Yu , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/lima/lima_devfreq.c | 14 +------------- drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..86aea1bdc4f4 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -7,7 +7,6 @@ */ #include #include -#include #include #include #include @@ -84,17 +83,13 @@ static struct devfreq_dev_profile lima_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, + .is_cooling_device = true, }; void lima_devfreq_fini(struct lima_device *ldev) { struct lima_devfreq *devfreq = &ldev->devfreq; - if (devfreq->cooling) { - devfreq_cooling_unregister(devfreq->cooling); - devfreq->cooling = NULL; - } - if (devfreq->devfreq) { devm_devfreq_remove_device(ldev->dev, devfreq->devfreq); devfreq->devfreq = NULL; @@ -110,7 +105,6 @@ void lima_devfreq_fini(struct lima_device *ldev) int lima_devfreq_init(struct lima_device *ldev) { - struct thermal_cooling_device *cooling; struct device *dev = ldev->dev; struct opp_table *opp_table; struct devfreq *devfreq; @@ -173,12 +167,6 @@ int lima_devfreq_init(struct lima_device *ldev) ldevfreq->devfreq = devfreq; - cooling = of_devfreq_cooling_register(dev->of_node, devfreq); - if (IS_ERR(cooling)) - dev_info(dev, "Failed to register cooling device\n"); - else - ldevfreq->cooling = cooling; - return 0; err_fini: diff --git a/drivers/gpu/drm/lima/lima_devfreq.h b/drivers/gpu/drm/lima/lima_devfreq.h index 2d9b3008ce77..c43a2069e5d3 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.h +++ b/drivers/gpu/drm/lima/lima_devfreq.h @@ -9,7 +9,6 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; struct lima_device; @@ -17,7 +16,6 @@ struct lima_devfreq { struct devfreq *devfreq; struct opp_table *clkname_opp_table; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; ktime_t busy_time; ktime_t idle_time;