From patchwork Mon Mar 8 09:16:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395371 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1546245jai; Mon, 8 Mar 2021 01:17:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgWVYIbwnSzCw9IIOgCS1HYtSjZLutOcoyHjfiRLGDeNrXcy1EL3ZLHWxwJFBsvsAmmCKP X-Received: by 2002:a62:5e02:0:b029:1ed:8bee:6132 with SMTP id s2-20020a625e020000b02901ed8bee6132mr21019987pfb.48.1615195023569; Mon, 08 Mar 2021 01:17:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615195023; cv=none; d=google.com; s=arc-20160816; b=Uh/+jfTUT/OiRalYrPfUSZ9bV24wuRVRY2jUUv9IRO1eLKo1wr8kEUtTiB7Ms7hm/S OZhcNlu65//T3iqaRJq/YB2ucLBg4JFuOKZkSbna/AkobTFYX7tMUDJZ1OR71i9FfmtS +Fl/baHd/K7FLny0YrkW9HanN9yxl0NTXuA9RZTkOJe6z5FqXCp+I3QIOFIlMfWu1jGF 5Ad558YVmTgkaIwSskfGQk+hP8aFBG05C6QaUALuY9ZBn9kv5YwJMZpp/8beHZSwEuCS 5RBf7clWXo7Qb8Sm+M78P7tkGZjJ9vF2h4v5xiIkmitpAU87RU1F0HKWVuxjoPc1+6k0 LSIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=N+kS6nGilrRZWlxzLwj9S5TsHpH3UhA/Fid0a8fqpWM=; b=gfVxWGAlNnNExA7icnqSDLMmG0LA+pZb7ypEFCOxfQtob8D9Ft7U33M5xvjLk6qkge 6GMa4Gyh8nj6dM7jRQv59WQ3ogm7WirsN/STmJZB0/lt6tqBa7st1tYd/L3DlcWif/Vs dztPtoPwUhQqBOSLJrsJedK30YmaGGn7z1rkUTg4xaT0mDTtxekIxAGqdvO4ZUe8dRtW Hw6tpCd85auV4gFr8N7DDSX4Mj0o9QJg/ovvBJbDRHyHD2EsmJRr3n/EOTfU3Zsu0/GU AVUAMk2LIugmCbOpNN3n8jSfiEvPbyaejQfh/CMZ9T4C6bErbXuJXj86a7keYv3r2DVB Xzig== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=y5axN+ky; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id b6si5169111pgk.228.2021.03.08.01.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 01:17:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=y5axN+ky; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA84F6E83B; Mon, 8 Mar 2021 09:16:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED2546E83B for ; Mon, 8 Mar 2021 09:16:56 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id b18so10613473wrn.6 for ; Mon, 08 Mar 2021 01:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=y5axN+kyadsACGS9H0rIrwW2rocmwOJ8uPJYHgOeRJvnJKYfpYihv+L4gMntc6PGuG gZXlw67BU0r28fxfQFrGXjXQ/2dYuK9fF7Fgij3RACAVLYNEKjaSeaxs0jEpzIfMC42g uLMCCHKTrllVRFW+l2BbDPBet0E3UYCttsJaBHZCZaXLQ8HhN7GtXZZnqlJiOrVmi5NF ZSKjCDAd3Ha4LiVasrST5LhE3eY1fNfuWNjBDUpNrmhaXIdK+y4IxLf4RiKcN06gkbWW ATbU8HW/+gq7o0snmBZjuEBPtHGbUlBCin6C5lbv8SyFfIKAsHQrbASK8FyLfglge2oO CsgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=PlWhFZ++qid597CJAlsBBV0fJw6ttxWpjKKkc/MtN7tIHWwkG+6xo7cTePe7uPh4+8 7Vd1/35HTGRtJRNS+F5AzE9+omlMrEUSrKrJUNRqUQITmGk30F5NB1JDPvX6GfOvyRRi vjQ6wGJITEYpOz6DJA3xc8uZ7/bVTmjyYTk4weTWnXb8j24Aza9qumzJLWb2H6GcSByI zWURH90ZflT7s/yBmBDKOyzuvmMaLGu0yt/ac2WJjJhb7f2hbxR19+P+JYHOW+IEzu4R tji5rsvBiEuyLlSoYnTVPFEYxRLibPxyVIEzxq05VpwqXKUfkQmomXfdzgWE/9vAFkWK baUw== X-Gm-Message-State: AOAM5304xQl7tBZq3YiGkSc9UetFtBJH5P8WkFL7g2fbkk+taSeWJcJi TOMrwla1OIPdk85DoeTVehuEIA== X-Received: by 2002:adf:9bcf:: with SMTP id e15mr21168990wrc.276.1615195015567; Mon, 08 Mar 2021 01:16:55 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id i17sm6068135wrp.77.2021.03.08.01.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 01:16:55 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v5 3/4] PM / devfreq: panfrost: Use devfreq cooling device registration Date: Mon, 8 Mar 2021 10:16:44 +0100 Message-Id: <20210308091646.28096-3-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210308091646.28096-1-daniel.lezcano@linaro.org> References: <20210308091646.28096-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:ARM MALI PANFROST DRM DRIVER" , steven.price@arm.com, Alyssa Rosenzweig , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on rock960. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 14 +------------- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 3 --- 2 files changed, 1 insertion(+), 16 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Steven Price diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 56b3f5935703..4d96edf1bc54 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -3,7 +3,6 @@ #include #include -#include #include #include @@ -80,6 +79,7 @@ static struct devfreq_dev_profile panfrost_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = panfrost_devfreq_target, .get_dev_status = panfrost_devfreq_get_dev_status, + .is_cooling_device = true, }; int panfrost_devfreq_init(struct panfrost_device *pfdev) @@ -90,7 +90,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) struct device *dev = &pfdev->pdev->dev; struct devfreq *devfreq; struct opp_table *opp_table; - struct thermal_cooling_device *cooling; struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, @@ -139,12 +138,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) } pfdevfreq->devfreq = devfreq; - cooling = devfreq_cooling_em_register(devfreq, NULL); - if (IS_ERR(cooling)) - DRM_DEV_INFO(dev, "Failed to register cooling device\n"); - else - pfdevfreq->cooling = cooling; - return 0; err_fini: @@ -156,11 +149,6 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev) { struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; - if (pfdevfreq->cooling) { - devfreq_cooling_unregister(pfdevfreq->cooling); - pfdevfreq->cooling = NULL; - } - if (pfdevfreq->opp_of_table_added) { dev_pm_opp_of_remove_table(&pfdev->pdev->dev); pfdevfreq->opp_of_table_added = false; diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.h b/drivers/gpu/drm/panfrost/panfrost_devfreq.h index db6ea48e21f9..470f5c974703 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.h +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.h @@ -9,14 +9,11 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; - struct panfrost_device; struct panfrost_devfreq { struct devfreq *devfreq; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; bool opp_of_table_added; ktime_t busy_time;