From patchwork Sun Mar 7 18:51:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395147 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1142435jai; Sun, 7 Mar 2021 10:51:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxD+/SOWgHvsNwP0MKzied+wVNakzg5rv/VhGf39kuERKPRaQhqHoMyI5CkEPQ3RrrXJ70I X-Received: by 2002:a17:90a:ba8b:: with SMTP id t11mr21519652pjr.177.1615143110583; Sun, 07 Mar 2021 10:51:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615143110; cv=none; d=google.com; s=arc-20160816; b=KBrMXIpmLKKpMCOj8HzM5MPgavPJzFwvKMwx7nApqALfwdIjzxdDOTQCyMyJ7pdupf zEn7oRk5a/SqOAzZNNjnNJxnYMceDmxrpsF/ScC2RYz5rSLYi+Y2qKYz6GFGZRCvWLKl 5BBi0BKwVnypdj3AF3Te3o6QQXHf7DzI+RdsbngMCFFgmlvtxhO2dBMplrz491eL5WI9 fhDWoTCwcahQZpdJwiTfl3803TrXMGi9Ml0eIxJ/xyzxBB6ALoEchyO//tuWmWrQX5t/ QcoEWoiRPOQXq5ifZGsiZFXMW6n0Y2YKx3F0H121HmC+MxWBwMavyhf+9N0h4PWPRkCT +Xdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=7LEJW/C5E7y4xVwd66YXAzGRxCjBZYD4mQkAdnSSYdQ=; b=vEg67mdxsgGwG7e6zr5QdPCfZ8rxLAkNVF16npEjC+8TMbZDmBxIpKhgFNyYSngsCo 8fz84dhOrPhviDyRRNnCwh0x7eJGO20Lf6fLMCdJJcxQMFjSi2IUsaxQ+S1x4AkpPvzT kWQhdpASJGDFB2+miLvxNNtfY7rgEiktpTx4QXMdpJTLsPh8NGN+nkKA2b+jjHSgRcKJ uW3Jyh6w7wdwW6/1ZQoCwg4Rud8OZVGUGUF4sWqhRSI8dCubkO0+3yE8vwloCut5eabe EwVXjTi32lM8RBNISE8GUy60f/DJA9KwUfq805mgzQUlbw464fx4Y9niIocxXUsTOkrH kD/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oWBnZ4aS; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id m5si9298769pfd.105.2021.03.07.10.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 10:51:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oWBnZ4aS; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE86E6E21D; Sun, 7 Mar 2021 18:51:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CB9A6E21D for ; Sun, 7 Mar 2021 18:51:44 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so2129379wmq.1 for ; Sun, 07 Mar 2021 10:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=oWBnZ4aSczd7y5RxPFRzRlQVEwdtlC9a7PJ+FC4zThsk6IkpQmng+VE49/LomHtJMo KTXaLq3/6N4DkZfdmxylKLJBC9GmFaqke08d4pIGBWKxDWIz/16PL5zXFXcrBhi85x92 KrSgTVisjIQZRkKc6FnfU2NqKTyPV1RI4VtdCr9bhiIEBCv4u+OkZ4UEG7SyIhN22L7D 2InRHmS/NTCjCJ+uNOEcNKLnTrUYdn4vei5v2JFTFA6c0mJYcFPj/TUQgaJ6bc2cMxf7 bnrIhRfc8/EG7XJOp+tmPoVNBtn7WvepMRAfMS/xyy34bbLze1EvaURKwm++PtpDcIcS O6Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=Bgi0FanXNcXRfz9LAQ1UgUwGsuqzOyZshGY8ACgJrInB1GHEDEKz4VYAcfbtOJy/8s oftGNKZvruWsMfpkZfet/alGIb2cl7Tk68iqzl3o9yCuF7XfCit12fML/Zyscxba5QHx /DfVOqX7UvqEEHbLuJRoWf/ylnmw3RB4z2gY2gxh03JV4T3eyeCFIFlWUqBg3S6mSZCo 0ud0I7bphUWnZmJyOIkhIXGYij9Jww7gSNZlYQ+YwXn7t3YWsR3ZppFG60yk+dg3KcNB ylWimPqDNvCdwf7uhJJww4PAcfP1IurVrjYfYrUmZMPvdqISqa6t3PxeWy2o9A8MZdYr 3o3A== X-Gm-Message-State: AOAM530cwmDyMyCgcaXRwpdrZ5+irpG5/oGC2N8/Ojp+NAH6oUuypgHH 5Dl84kPGU93PjbY5DYqCt0IOzg== X-Received: by 2002:a1c:66c4:: with SMTP id a187mr18790206wmc.164.1615143102905; Sun, 07 Mar 2021 10:51:42 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id v5sm14842965wmh.2.2021.03.07.10.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 10:51:42 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v4 2/4] devfreq/drivers/msm: Use devfreq cooling device registration Date: Sun, 7 Mar 2021 19:51:35 +0100 Message-Id: <20210307185137.24925-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210307185137.24925-1-daniel.lezcano@linaro.org> References: <20210307185137.24925-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-kernel@vger.kernel.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" , steven.price@arm.com, Sean Paul , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on dragonboard 845c Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/msm/msm_gpu.c | 12 +----------- drivers/gpu/drm/msm/msm_gpu.h | 2 -- 2 files changed, 1 insertion(+), 13 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index ab7c167b0623..eade94271a60 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include @@ -82,6 +81,7 @@ static struct devfreq_dev_profile msm_devfreq_profile = { .target = msm_devfreq_target, .get_dev_status = msm_devfreq_get_dev_status, .get_cur_freq = msm_devfreq_get_cur_freq, + .is_cooling_device = true, }; static void msm_devfreq_init(struct msm_gpu *gpu) @@ -112,14 +112,6 @@ static void msm_devfreq_init(struct msm_gpu *gpu) } devfreq_suspend_device(gpu->devfreq.devfreq); - - gpu->cooling = of_devfreq_cooling_register(gpu->pdev->dev.of_node, - gpu->devfreq.devfreq); - if (IS_ERR(gpu->cooling)) { - DRM_DEV_ERROR(&gpu->pdev->dev, - "Couldn't register GPU cooling device\n"); - gpu->cooling = NULL; - } } static int enable_pwrrail(struct msm_gpu *gpu) @@ -1056,6 +1048,4 @@ void msm_gpu_cleanup(struct msm_gpu *gpu) if (gpu->worker) { kthread_destroy_worker(gpu->worker); } - - devfreq_cooling_unregister(gpu->cooling); } diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index d7cd02cd2109..93419368bac8 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -155,8 +155,6 @@ struct msm_gpu { struct msm_gpu_state *crashstate; /* True if the hardware supports expanded apriv (a650 and newer) */ bool hw_apriv; - - struct thermal_cooling_device *cooling; }; static inline struct msm_gpu *dev_to_gpu(struct device *dev)