From patchwork Fri Jan 15 18:15:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363708 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp91097jap; Fri, 15 Jan 2021 10:16:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzI3ltKz+kTg6lS0TNvXxHPkxspz82jd2Vn+5m6wzQO/SUoY1LIYKZpFDlm8rngb4PEO9Gi X-Received: by 2002:a62:3386:0:b029:1ae:8580:99da with SMTP id z128-20020a6233860000b02901ae858099damr13782729pfz.61.1610734584016; Fri, 15 Jan 2021 10:16:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734584; cv=none; d=google.com; s=arc-20160816; b=d+UPfpR3kAvrNW9OlkLF5W7jDm9WWEzcd53JMp30thJOSHh3L6II4X3upyT7KDEKOl 24z0tww2ttyMMOaKC+eP+kidCiFSPzUe/onQh/eED20SThWjwXUs0tB/DQsVUU6N/sc/ C1YPTfDpbaw32oLklLgRE8jpy2f8Ok1xMPlC9V6Qhuipr1nFglf+9/Hz9DEv6kp89NBg vh65NsNCrZLs8AmPH3TiWuc+xYjyqw5nTnH52xgPu+ijt4DQxsq8TAcHr1dItriUjxVM ddjzZ7JpHU23hN46PGAjWpA8qmjuaGIlaVvgA5GKHA8jF/A0/bJBwBLrGQ7IX++woP5T fQBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=HySDZ+I2pwGOMWb5E4Q1E5tV+3Htots8t1IDmcR31FQ=; b=N6mRRws0UA1hp/yJOw0J0hCUAutzN2W9BRSvp3t0heygr99oPdpFnNE7vmaqpL1CYf IoEKENs9kTws+9aBqkS3ADuWP172hNJiOK0l5m4WxtdKQdJ3VQzWEoKW9l+E47ZI4VGm tsgmQzmyS2ugh0pzUQ9XVU6QIrpG5Zl6hLGVgjVGTbQCvqoqZ7536OWWoFzGye4EIHax XfKIZCj72ur9M44DCBrW+uaSEkq2a/Bfm+zU6NSSY1VT98MYKYlD4amBVEmI2WB7yPrS 4DXeN/bXt7BK7taPb+8qUxbphAzc5EmhHhgw8KafnBdfv1LSYI/lmF6nYlloWripyy+8 1kPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgDPtz5O; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id m2si10720624pfd.222.2021.01.15.10.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgDPtz5O; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CAC06E4C5; Fri, 15 Jan 2021 18:16:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id D93766E4C9 for ; Fri, 15 Jan 2021 18:16:18 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id v184so4178220wma.1 for ; Fri, 15 Jan 2021 10:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JdzYhU96phNVr/cQmxntosfoEfrUPlI8/6w18TG83mk=; b=TgDPtz5OvXkvw5Kk9fA2xhsW71qTJ9nYJUgdLHH5EdsH+0RK/3EQ6dpwnKsx95hrKT 2NFRLoQ2wNRsll1ImY+Eb83/QcJDfxPVKvKy2h7sSp13zL4UOUv9eBJvnJoXM5mLbgCP +jYHH/dPinV1RgllXaAYNLMVRpK8iV00cfHsW2kmDYxA2/nb6ljeeZmFMjX0A0/Vl8wz Swytj0YA1VCE58u+SRc09oFwc1jtE2W+zl2kQdPZ/I/+6Kb8zuw6NZwmd7H4KQCzVMg6 SrZxc1Kr0wnWa/zW8WK/VRDyWYgg+Td4hVQawOpdIfsMQ9xu7Rc+D2V7CHcCQbFWd0B1 ab0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JdzYhU96phNVr/cQmxntosfoEfrUPlI8/6w18TG83mk=; b=oJAUAU1qXs4mznnHB5gRfXVAwa4uQ3KHNW99rWoVHg7QdANt19Tb9VuyPQSjyMe4zG KdZIxQAqFbxQYK2Q1hjC5B1D0zkdJgkkLtoU03IXN0QJctRMBZDB6gPn90g2SKECX+8n Xovc0LOftbjenu/hO1kLX0m/PBfn2hlMxOU8rlhxLyn+CMTYa6J9cS6GLHbD9v73+CeU 4HxDlZPR8QDJ22mtL0TwXodxan41k7DcjaBPEXf9jbSMzEju8y8knh3M86gmJKRZTiic nwUvOpu0k+MlaN6uxxYslsxcjWDI06YXJK95YiHoOBtceC3H9tYf6fVdq+IJGYZhggdM IvDQ== X-Gm-Message-State: AOAM533FnzTayAhMRjy0cOycyK+AdVhj1MZlJk6sqyUm/9wSF5gm7T36 orgm/fa0OnUIHYcI1qdBNZnHPA== X-Received: by 2002:a1c:4b14:: with SMTP id y20mr2837058wma.6.1610734577506; Fri, 15 Jan 2021 10:16:17 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Date: Fri, 15 Jan 2021 18:15:40 +0000 Message-Id: <20210115181601.3432599-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f2e2bf6d1421f..e7570f422400d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c @@ -48,7 +48,6 @@ struct vmw_validation_bo_node { u32 as_mob : 1; u32 cpu_blit : 1; }; - /** * struct vmw_validation_res_node - Resource validation metadata. * @head: List head for the resource validation list. @@ -64,6 +63,8 @@ struct vmw_validation_bo_node { * @first_usage: True iff the resource has been seen only once in the current * validation batch. * @reserved: Whether the resource is currently reserved by this process. + * @dirty_set: Change dirty status of the resource. + * @dirty: Dirty information VMW_RES_DIRTY_XX. * @private: Optionally additional memory for caller-private data. * * Bit fields are used since these structures are allocated and freed in @@ -205,7 +206,7 @@ vmw_validation_find_bo_dup(struct vmw_validation_context *ctx, * vmw_validation_find_res_dup - Find a duplicate resource entry in the * validation context's lists. * @ctx: The validation context to search. - * @vbo: The buffer object to search for. + * @res: Reference counted resource pointer. * * Return: Pointer to the struct vmw_validation_bo_node referencing the * duplicate, or NULL if none found.