From patchwork Fri Jan 15 18:15:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363730 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp91652jap; Fri, 15 Jan 2021 10:17:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvy9THj5b9mcVIkpLCcMIBvxgO62eOYGHcrUiGeacawYJZdy6xl3GRRcTk6TUO2mwC+jwV X-Received: by 2002:a17:902:8306:b029:da:d7f0:9e16 with SMTP id bd6-20020a1709028306b02900dad7f09e16mr14017182plb.53.1610734621791; Fri, 15 Jan 2021 10:17:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734621; cv=none; d=google.com; s=arc-20160816; b=IysGW4uxilt3V6lPnmV6YBejfNCy8bRY2bJoT/L4kO57SIbR3lt/zQGVHfniCQybuv P2HZdcjZL+xUsP9wgo5p7TzKd0SnWQ/KTzWny6Pm08Dkl7zxn9lfzWqgsauSztvY7KPh 8JuUib06OGjYdAdl0iLh9fMvWSlN2rsnmhA1H1spSpQ2AD1d3OG2ExSMQVL/iLzkZWbT IekMBkkGxEcLKcWZVUFHt8kC0jwfHQL4+4x7/vBVOxFOSWMExK1M4wogz2bZOSAB/QGq E8TU6iiwQcHTlstgzS58SwjIPIZkx6TZ3kpAIjSE7QkMDrCHbvbSgzgOn8X7NiPZBR0n VVkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=tqB+yBgENEFZFmNVRjzj1VmthaZLkaKGgvMSBjQVbJA=; b=u05vq2U5BI0kc7KBJItj+f6hyyOSVLVIZtkgf59Boolf8lThCZu7lTQpQ6RB8iBcRw lBt+FXJ9pPwqPlLhVzVrDoDoHD82Ugk5Gmu5DrgzdxBUQrXKZS2Cn7soeVMpdj5kgOGq IGk044mNEnlww951aXPlaiZRamgjyIDjIUHz/L7wsrV7+9zGlIwP7z/4SpfRjRdCNE/A oUbFmD1hYvyGeUnIpSvc6wlOKjwx3Ps5N94jmIqccZKrr4/RlRwdlGYlCOZeCpnOextx zGO88HOd6niBeYgqIfgX0AjU9VSWz4e/QTU7ApFoW1q1hWYf3Tjb02ngAzGSRmmiPE7w WhlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xlXITN0c; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a15si10982219pjk.93.2021.01.15.10.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:17:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xlXITN0c; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C5DD6E500; Fri, 15 Jan 2021 18:16:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id E48A16E4E8 for ; Fri, 15 Jan 2021 18:16:38 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id l12so4984747wry.2 for ; Fri, 15 Jan 2021 10:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W4lgvadJF0F6Eqo3TsN4IbMPwQEK3WYj/tmMeRVVJp8=; b=xlXITN0crvrSfNXAA3TYXbkG3biTTGWh/FeKcc0GwUfWToBTn1ZXsAlSAbSueg2VGo +xdTKtHkmYD4VLKzQ41PLO5LgxjNajgA8OiYgPCHvE18+WPzFxNqVrgzX48+8s90jXVm tdhh84IqxXC5EWBtLDwAiayJRWdFqc/fC1NbGjNc86XPp0MhXxyhwJf683KgKhTRFbUP Y+rwIuYviFsc4lI53HTwOaMC9bGDZb4XlLes1MFd3K2xpE5AvIRVKr9TMyy8+JW+DHW+ TR/6qjtTrr9bjhQQ6sqyLlu8erF2tlDZYgQJ4FvL6WY+vFG+5BC/zNo1iI80ohX8Nin0 oFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W4lgvadJF0F6Eqo3TsN4IbMPwQEK3WYj/tmMeRVVJp8=; b=ndT4HZWhv2YYIcaBwcAvcV8s1bqIT4NYvfKvkeUfvDMxJIfG6W21bRReqeCXpJMPZH a2n95yUnD0LzOtqFhsNrIQdmKLs/tla/6Yurnq9WJHnG8Nw7J/t5e/rJ0tqffF7I76RA x64ia0+Iz+K/djPpW+uZ14mC55achcz8DePs6bJdVFYlxHSDzW3RGvUX0auDbHhUm6LA txROGDmBMUoE3hDM7OXcpyil+avTvF+CdHwrQhSJcX056IGCwDs8L13mtuUbXIQTU5Xo 2hi6aQlqyMlXMTpQDNUvJaCcHHqmO0i+YHAxnDP/I05RU1M0MP6eCaQk3SAYlT05plmM R5Yw== X-Gm-Message-State: AOAM532Uo42p0MSRqHlxq0ulFo+q/t39WKV6o8LX9yms9Vt3iQr+R4hs H1sTmbUCBgwiURC075l6fbOdeg== X-Received: by 2002:adf:f4d0:: with SMTP id h16mr14699029wrp.30.1610734597599; Fri, 15 Jan 2021 10:16:37 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 23/29] drm/drm_agpsupport: Strip out obviously wrong descriptions and demote to standard headers Date: Fri, 15 Jan 2021 18:15:55 +0000 Message-Id: <20210115181601.3432599-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, Faith , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Gareth Hughes Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'dev' not described in 'drm_agp_info' drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'info' not described in 'drm_agp_info' drivers/gpu/drm/drm_agpsupport.c:105: warning: Function parameter or member 'dev' not described in 'drm_agp_acquire' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'dev' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'data' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'file_priv' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:145: warning: Function parameter or member 'dev' not described in 'drm_agp_release' drivers/gpu/drm/drm_agpsupport.c:171: warning: Function parameter or member 'dev' not described in 'drm_agp_enable' drivers/gpu/drm/drm_agpsupport.c:171: warning: Function parameter or member 'mode' not described in 'drm_agp_enable' drivers/gpu/drm/drm_agpsupport.c:203: warning: Function parameter or member 'dev' not described in 'drm_agp_alloc' drivers/gpu/drm/drm_agpsupport.c:203: warning: Function parameter or member 'request' not described in 'drm_agp_alloc' drivers/gpu/drm/drm_agpsupport.c:256: warning: Function parameter or member 'dev' not described in 'drm_agp_lookup_entry' drivers/gpu/drm/drm_agpsupport.c:256: warning: Function parameter or member 'handle' not described in 'drm_agp_lookup_entry' drivers/gpu/drm/drm_agpsupport.c:279: warning: Function parameter or member 'dev' not described in 'drm_agp_unbind' drivers/gpu/drm/drm_agpsupport.c:279: warning: Function parameter or member 'request' not described in 'drm_agp_unbind' drivers/gpu/drm/drm_agpsupport.c:318: warning: Function parameter or member 'dev' not described in 'drm_agp_bind' drivers/gpu/drm/drm_agpsupport.c:318: warning: Function parameter or member 'request' not described in 'drm_agp_bind' drivers/gpu/drm/drm_agpsupport.c:363: warning: Function parameter or member 'dev' not described in 'drm_agp_free' drivers/gpu/drm/drm_agpsupport.c:363: warning: Function parameter or member 'request' not described in 'drm_agp_free' drivers/gpu/drm/drm_agpsupport.c:404: warning: Function parameter or member 'dev' not described in 'drm_agp_init' Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Faith Cc: Gareth Hughes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/drm_agpsupport.c | 46 ++++++++------------------------ 1 file changed, 11 insertions(+), 35 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 8b690ef306dec..7ae446fb84ad2 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -45,13 +45,9 @@ #include "drm_legacy.h" -/** +/* * Get AGP information. * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a (output) drm_agp_info structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device has been initialized and acquired and fills in the @@ -92,7 +88,7 @@ int drm_agp_info_ioctl(struct drm_device *dev, void *data, return 0; } -/** +/* * Acquire the AGP device. * * \param dev DRM device that is to acquire AGP. @@ -115,13 +111,9 @@ int drm_agp_acquire(struct drm_device *dev) } EXPORT_SYMBOL(drm_agp_acquire); -/** +/* * Acquire the AGP device (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg user argument. * \return zero on success or a negative number on failure. * * Verifies the AGP device hasn't been acquired before and calls @@ -133,7 +125,7 @@ int drm_agp_acquire_ioctl(struct drm_device *dev, void *data, return drm_agp_acquire((struct drm_device *) file_priv->minor->dev); } -/** +/* * Release the AGP device. * * \param dev DRM device that is to release AGP. @@ -157,7 +149,7 @@ int drm_agp_release_ioctl(struct drm_device *dev, void *data, return drm_agp_release(dev); } -/** +/* * Enable the AGP bus. * * \param dev DRM device that has previously acquired AGP. @@ -187,13 +179,9 @@ int drm_agp_enable_ioctl(struct drm_device *dev, void *data, return drm_agp_enable(dev, *mode); } -/** +/* * Allocate AGP memory. * - * \param inode device inode. - * \param file_priv file private pointer. - * \param cmd command. - * \param arg pointer to a drm_agp_buffer structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired, allocates the @@ -242,7 +230,7 @@ int drm_agp_alloc_ioctl(struct drm_device *dev, void *data, return drm_agp_alloc(dev, request); } -/** +/* * Search for the AGP memory entry associated with a handle. * * \param dev DRM device structure. @@ -263,13 +251,9 @@ static struct drm_agp_mem *drm_agp_lookup_entry(struct drm_device *dev, return NULL; } -/** +/* * Unbind AGP memory from the GATT (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_binding structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and acquired, looks-up the AGP memory @@ -301,13 +285,9 @@ int drm_agp_unbind_ioctl(struct drm_device *dev, void *data, return drm_agp_unbind(dev, request); } -/** +/* * Bind AGP memory into the GATT (ioctl) * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_binding structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired and that no memory @@ -345,13 +325,9 @@ int drm_agp_bind_ioctl(struct drm_device *dev, void *data, return drm_agp_bind(dev, request); } -/** +/* * Free AGP memory (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_buffer structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired and looks up the @@ -388,7 +364,7 @@ int drm_agp_free_ioctl(struct drm_device *dev, void *data, return drm_agp_free(dev, request); } -/** +/* * Initialize the AGP resources. * * \return pointer to a drm_agp_head structure.