From patchwork Fri Jan 15 18:13:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363700 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp89640jap; Fri, 15 Jan 2021 10:14:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhKWkhiiTdZNXbP96GXuak09Y0y/3m08BD7hwLM3XdV6v5bk/+W2uj/huHE+rc/CwMYOZf X-Received: by 2002:a17:90a:d58c:: with SMTP id v12mr11978731pju.37.1610734480582; Fri, 15 Jan 2021 10:14:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734480; cv=none; d=google.com; s=arc-20160816; b=r30RG08SDnfI5CJNQTql4g5C5CKW3oLnqTk1uPQ3W9otERzgbpbdf+3snNl+odugG0 QNLpi1qmdIwW9Hlrj3HgED0CT+nEhUNvTP1HJDrqs5N+MybNXM0J/Tn8prQWGuakizE1 9GoFYP4uPVyg+2SsxT05ECdOegAZlb/c7zYb52XLLsgBPwQ0N+NWU8uGLAs5eKcDyeru uWu9Rv0hpXRWc2r9o+8ZGNMoTzOC1YA3Lgd3HJPI8Z4LdUN2/X6cEQWOD8jb4ptyLNSt xBApQc+hJWTrgpU6DuvuB2mBIgavXJ/VizgcnkzSXQ+x/pvvEyy8ZWXxlAWQ5HMdu55X tS7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=B+iH81mXto3ODF1oYVoYVuzCCpZtxcSA0JBEcRPRMxE=; b=gHagsrpUdqjiiJ6pw7PKDZrMUkl4ySJQcO5F4Bc+e2rdkaaWJrI9DCnkPH+DgPF9E9 smX5DMX27ugUbI4tqx7fYSWSNgk1jWox4vg0iUrto5XyPco6mBvft/1E8WRCp94mxdPV mkGhQepnsFmIpGAFngdUZBSIiSX1JEJLbhozDZ8hcV6DRvD6y2F+mFgyvyLS1BN6RU9e 5MtU6Cv+p+VAuy3phUtf32RcQXlV9BrmyMlgnRz569zFkboVyt1PCpEIQVhzUjvwaXFS QrV+SgHnhhtGCx5jYy3nn9W2XzDuFK8b3WUilnOn5kNdthvDyb4N9vFJHIQwXGDd7aSD Vi6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M77jBSyJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id co18si10695235pjb.34.2021.01.15.10.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M77jBSyJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 480096E484; Fri, 15 Jan 2021 18:14:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45BCB6E4A7 for ; Fri, 15 Jan 2021 18:14:12 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id a12so10180142wrv.8 for ; Fri, 15 Jan 2021 10:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Am4t8b9En1HIfsclMg+25TY7LAvRdlrz1SUTzn1fYz4=; b=M77jBSyJi06eqwSb0fQBTfnZ6ireTJ4ExXO9TEhHwoQ0gXWo1v183KS92TUeVaZNun YaX4duc8tuj90M1fTQ98u9PMbQ7Bejo7m/hnKIcm49IzS1dh3qyft6nJFFvkFkYBiNry 1Q/zs3xW7pMSKqv/lq/YTh6y5aZnafrgpq2vVAWsmVe0Q+UNzzL0nacr2TGkrdOlb/eq T3pzb174ylDgVUTO5QSkquN67H3RgsAoicWZOaTge4rkS7bE4D0HJRPNMF+NSBzgHaLx ZrQpEF7vifXb2dfhbkakdeZikPe+eIitwHnJCTNbbkkaP9BR8tNBrZemhTmDcmOFhh0g kzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Am4t8b9En1HIfsclMg+25TY7LAvRdlrz1SUTzn1fYz4=; b=e4lTBpl8c8SW2qwiFJQVFBlAkZsG1sz5EX8K/bXLdoEFkCGH/YSkseRDK3dur3OjBB q6Mr5y+F4rqa8iQQ34gxPBgM3IGegS1Zd6dO2sAqXojOpptpPOIc3K5I/oq506Fa0ar/ NqriRf6Py1Q2oyhNet+TuE5CXRDqFT4y1Zq4sG4KNNx1SSmr9ELuWTDBg+Wgk+e7SJ3j UlviyCyiTXcLdP7U9861NVb6Rumshgn8lO/gMFcsqVcb2huQb1GH0gk7eejaVdqO/23L i9vmA2CJMX5z39Gx6cvXOKoe0qBYUNSEdpeEzjjKfDjjXGHBNl48LVUUkNnWI1x7upYe 3B2A== X-Gm-Message-State: AOAM533+C1mbhGGmOCqbp1JqlNnoMVz9Qdn5eKlJLIAd3q+/pmk/NEl3 e/1CctZguSzsbWbU9zWbeqBlkw== X-Received: by 2002:adf:902a:: with SMTP id h39mr14400546wrh.147.1610734450977; Fri, 15 Jan 2021 10:14:10 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 37/40] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params Date: Fri, 15 Jan 2021 18:13:10 +0000 Message-Id: <20210115181313.3431493-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct vmw_cmdbuf_man ' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:164: warning: Function parameter or member 'handle' not described in 'vmw_cmdbuf_header' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:257: warning: Function parameter or member 'header' not described in '__vmw_cmdbuf_header_free' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:380: warning: Function parameter or member 'notempty' not described in 'vmw_cmdbuf_ctx_process' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1168: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_preempt' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1193: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_startstop' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c index 45fbc41440f1e..3158924ffa852 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c @@ -48,6 +48,7 @@ * @hw_submitted: List of command buffers submitted to hardware. * @preempted: List of preempted command buffers. * @num_hw_submitted: Number of buffers currently being processed by hardware + * @block_submission: Identifies a block command submission. */ struct vmw_cmdbuf_context { struct list_head submitted; @@ -58,7 +59,7 @@ struct vmw_cmdbuf_context { }; /** - * struct vmw_cmdbuf_man: - Command buffer manager + * struct vmw_cmdbuf_man - Command buffer manager * * @cur_mutex: Mutex protecting the command buffer used for incremental small * kernel command submissions, @cur. @@ -143,7 +144,7 @@ struct vmw_cmdbuf_man { * @cb_context: The device command buffer context. * @list: List head for attaching to the manager lists. * @node: The range manager node. - * @handle. The DMA address of @cb_header. Handed to the device on command + * @handle: The DMA address of @cb_header. Handed to the device on command * buffer submission. * @cmd: Pointer to the command buffer space of this buffer. * @size: Size of the command buffer space of this buffer. @@ -249,7 +250,7 @@ static void vmw_cmdbuf_header_inline_free(struct vmw_cmdbuf_header *header) * __vmw_cmdbuf_header_free - Free a struct vmw_cmdbuf_header and its * associated structures. * - * header: Pointer to the header to free. + * @header: Pointer to the header to free. * * For internal use. Must be called with man::lock held. */ @@ -365,10 +366,11 @@ static void vmw_cmdbuf_ctx_submit(struct vmw_cmdbuf_man *man, } /** - * vmw_cmdbuf_ctx_submit: Process a command buffer context. + * vmw_cmdbuf_ctx_process - Process a command buffer context. * * @man: The command buffer manager. * @ctx: The command buffer context. + * @notempty: Pass back count of non-empty command submitted lists. * * Submit command buffers to hardware if possible, and process finished * buffers. Typically freeing them, but on preemption or error take @@ -1161,6 +1163,7 @@ static int vmw_cmdbuf_send_device_command(struct vmw_cmdbuf_man *man, * context. * * @man: The command buffer manager. + * @context: Device context to pass command through. * * Synchronously sends a preempt command. */ @@ -1184,6 +1187,7 @@ static int vmw_cmdbuf_preempt(struct vmw_cmdbuf_man *man, u32 context) * context. * * @man: The command buffer manager. + * @context: Device context to start/stop. * @enable: Whether to enable or disable the context. * * Synchronously sends a device start / stop context command.