From patchwork Fri Jan 15 18:12:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363673 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp89010jap; Fri, 15 Jan 2021 10:13:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbWgRxB615etVJDI1obhbcVU1aG25iqQIWBco7gy+iV0m+M+ycjVrjQ+XLgKmJnRWThaIK X-Received: by 2002:aa7:9e91:0:b029:1b4:7f36:e3e3 with SMTP id p17-20020aa79e910000b02901b47f36e3e3mr2140761pfq.55.1610734434809; Fri, 15 Jan 2021 10:13:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734434; cv=none; d=google.com; s=arc-20160816; b=Kyd0pm2BrwBljDzo7j5OE2TL2czeND5TzVATMZvE6TEM8iiXos1Hqnqe3Fjb+K5n+/ HXZ5yytKmM53Bx2vazD2MXNTRH9yUTsMDvEv8uNumztz2o7lgK6ellkkqz3VY6bBuhKs auSWVQEHhk2bGe3bGrQE7xFS70kYnq1G7oLgvyK/IOVSzgA73JksPZ87tAp/QaVku7QX EfX1QzLo7Qq5L6jI4E6VxV4FJB93PBbCJ1WZAgIzcrcbQlJmrnolPoavhTjJ4ab4X8Sa 4aY5HSA0uWZ9nXrZoWSF//WoYxQTty94oX9lNPNsZRQQn2ccMEK2v62QLv8jBjzxZTN7 tkrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=mCekj5G+vF3htA3VS+4ghek5SPvEwPesnJT61ApTxGA=; b=xGAwHNKANeGPFjlxtmGWVznyL9b1oX3Nbd4UErckmaZyAxqDyWXD6uANyrJg0SScFd RoHef4X0ZpgjF1lzfLNzHd9PXuKb4+xL7VYe9QQrQ66irUuxkk/dGEruOffjS8xlw2Qe abFB/PayvVG0eh8tKndfbLoGAhLNZmRO4O3oRV8WyJ3AnQBugdclLgy84OIeqFB3M6RV uL4uI6CqOlCu47Nu4rAHLzemY8dEd8/vPhPXQuBFDxp3QUepq4iDIhItUBTwsO0Tkh3W wdrdNicANosxUGBzbNqUziYGJz3CL96uUyTI3a4bCm9vfQm2ucZNwH2npgddIpX/LTvd jLMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Xhjjfcqb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id l13si10505935plb.379.2021.01.15.10.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Xhjjfcqb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 074C66E47A; Fri, 15 Jan 2021 18:13:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5398E6E479 for ; Fri, 15 Jan 2021 18:13:37 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id w5so10180306wrm.11 for ; Fri, 15 Jan 2021 10:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jvyHS8XiQc1oAzz859zgo3XkDd1Co0kNwC7up5M68+w=; b=XhjjfcqbMACLLu1UbUwoqoD/8t48q+La60pp5xe4eCTr0EMZJnWkSTnd6IyBDzec+Q RHflyw7Qx5MObqDYdfUNRRhZb5tcQlDS93CBk9n8BvSp//3B3HXS7yDQ20yIBhpDjm7J CJecEL0ZPE8v+KQyGPehSrFI59nJ68dHfp6WhLpKaprgpNczqjT2o6uR2IhUfx7Oi11t SHGVxSBkHz1lL/PVJIlI2NtCTuHfxTPAzO+7XDJYkI017xs7WIYnJz9Of+IQrLWENyS9 LWVqRaqiy+jGvXeOmpQa99Xoe8wK0qekcEgWyk62TXSV6S75tLeGP5zkpNenv8umJU4L rIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jvyHS8XiQc1oAzz859zgo3XkDd1Co0kNwC7up5M68+w=; b=Awp54PYaWpOKP4NvDnmnStHhmX/bnk83VOqek+SxbEu4TLKCO47HcjsCL4ZiKDN+kd +ltPCqGbqaxQWO0jyOAb6P5qnhkSePYYYriQmLsCBavCvrB7/xqDJ/WFOXkQwrBEu4Jj Zafc5m0olBUeWta8+s7WXRb6OBf5Oky2cT8PdAnss4boN5GOuzVsur6ZA5Rg3B1QeHPg /7mMoloudZbpqnqG5S1OIgCBObzZiFfSQf21uZfC2lpGhxP4SQmaLcMn7jJl/krQR8lF BZOcaaBhMQBVluWAB9VLBCqlUShd1IIDcL/tVfLKzBI58Cf6UJePSRAhZJFKXEPHOYj9 6WVw== X-Gm-Message-State: AOAM530PSre7qi+nnlhkGxkJrqUuasbIxoFFBH86W4XyLXaZ4QRd/m1P 9Mp2vRBfOuC7ZCT1hxo7SNu9Gw== X-Received: by 2002:adf:902a:: with SMTP id h39mr14398191wrh.147.1610734415837; Fri, 15 Jan 2021 10:13:35 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/40] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter Date: Fri, 15 Jan 2021 18:12:46 +0000 Message-Id: <20210115181313.3431493-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:55: warning: cannot understand function prototype: 'struct vmw_legacy_display_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:218: warning: Function parameter or member 'state' not described in 'vmw_ldu_crtc_atomic_enable' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:228: warning: Function parameter or member 'state' not described in 'vmw_ldu_crtc_atomic_disable' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c index 9a9508edbc9ed..acae92a07f4f3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c @@ -49,7 +49,7 @@ struct vmw_legacy_display { struct vmw_framebuffer *fb; }; -/** +/* * Display unit using the legacy register interface. */ struct vmw_legacy_display_unit { @@ -206,6 +206,7 @@ static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc) * vmw_ldu_crtc_atomic_enable - Noop * * @crtc: CRTC associated with the new screen + * @state: Unused * * This is called after a mode set has been completed. Here's * usually a good place to call vmw_ldu_add_active/vmw_ldu_del_active @@ -221,6 +222,7 @@ static void vmw_ldu_crtc_atomic_enable(struct drm_crtc *crtc, * vmw_ldu_crtc_atomic_disable - Turns off CRTC * * @crtc: CRTC to be turned off + * @state: Unused */ static void vmw_ldu_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_atomic_state *state)