From patchwork Mon Jan 11 19:19:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 360567 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp3140849jai; Mon, 11 Jan 2021 11:22:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBuXIG7mJpOk5IABED2GG1astUVJqguPwF3/X8c1SX+T0rhYKz98Yxdc825t4s6GWcYQ9L X-Received: by 2002:aa7:9625:0:b029:1a4:3b48:a19c with SMTP id r5-20020aa796250000b02901a43b48a19cmr868886pfg.13.1610392829354; Mon, 11 Jan 2021 11:20:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610392829; cv=none; d=google.com; s=arc-20160816; b=V/lQyP/5c/6Uaq2tet/jLvdQ3/Vhy6rMIQVhWhKX+aY06AqMMuEbHC9zdArdyJKs7g xGTF/ysVxmp+ZHym592slcs+YOkZu2lkK54G6HriaLuENHoEiT27B0UJKDeyB3tDjMRD AFKthNNiJb/FisdsERC8k167xyIutzBd51FRO9lEAXhgk5hw9OqpYOpzkxmiaoRpZ5kA rXS60YpvaD5yD3AlT65SKkvCQaYgFqT0RJERFd/P+P+iCTLoYB5+8dwNGrdjwcP91d8p kyqc67YJydGv6eoMK25G2qTEHD1EIW6ZvWXylJJehl/GRt8nJcLYJyh9/LXT5DBn1UGX Teng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=z1yQzwF91+dHFcP4bJ5NCiGCXZ+5wVFgr+F0s7itb7U=; b=wVsq2V+BsuFFrZij7CzE+V4b6qGC899I6iJ2zOlwmwFUX0Rwmanwpx19IYN9NTzdkC LH5P/4vY+k8wYijJTJV/6ujJVwsXvw7FYzWDuQ891aaoJf12houpspAi8rd1q+aO8V7p m7NVQ+YkJPiQI9aQ1ya+IEtvUln51oVqPiQBWnBugtayAR4aCDyZ5nt90vstGLv3MzHr PoAlWFRnfLKxqC/V6qMtNSw9nvKCcje+8h3NWjhBmBARkf1x70daZrAsfhC4YdtM2V+7 K3cw6Dwob0W0yZggfcEoP5nrnKb8TkmYnSOuO0U9S6o81Cul0PXxrTwF7FDxcHG8JrGv RF7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Ahk/N7Wi"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z10si554290plo.404.2021.01.11.11.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 11:20:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Ahk/N7Wi"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC85189F19; Mon, 11 Jan 2021 19:20:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id D76CA89F31 for ; Mon, 11 Jan 2021 19:20:10 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id r4so279209wmh.5 for ; Mon, 11 Jan 2021 11:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8tzA9ne5yyDo/B6XSuB5tuKBnRjxwc25nSNFsXm3RyU=; b=Ahk/N7WicvAg2xBmcya5Li0rhrLV39Zple9TDmD2+AkEaK8Sfi6y9w1RxaLEw29Hoc bPQ62/KVS7U2rMgiAQBD0vuBrdJbNeX3D7IyoSZdxQsfgdy7s5brQpLlxBKi/vu4zzhC L50pSaqfRrQ891NVBw/dUnCgk2DJtrLhx+yJn7RG34J0YH/IiiwnToahF89kcKHDb5K4 v7KOMCktZ16hayl9fz55vyKjRpReSxfAmgM31je2nf9qCvRZiOpzx8MNDyel3UFFq/Bk jp3/pQq5ub9ag0PHbuovkitWojvt295oLOh9aJxS8LVJVPssdveidWb3KX+p/JfWGozv 3cRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8tzA9ne5yyDo/B6XSuB5tuKBnRjxwc25nSNFsXm3RyU=; b=XViOhRnuYWF5DqJArt9I2Qpw3NDH6k/j9lvzAbaG7GaDJxAwlPNwkTfEFzGG2CwzK5 7fiMNw+X12wCyapF5tl6wM5ObNGCzHRlL/UHri255x1Wbqv7a/kL9DlVB5v54FwjPiNL Ku2RdmRmQa7EXwpJo+8+veUSGpvhMfiMq6yNbLMjHMf6mCSxxVL4RLmw4U1RTcRW6TyE d2WtcKLceI9ujwYuYiI9knUHWvFyCrCwvGdpUxqu0Onbvivy9WNOYimgVJ3rfCQAFog4 4v/eh+ruvV160X3HMFxapieaOs+6kC7iP289baHLBnC0rpfCtQ0VtYYmLrl3uUBR4OGm sxzQ== X-Gm-Message-State: AOAM532Zhm4qf4vlCLJkYAOB863sMbJ1QVtztxvmmgnqKNoZcq+5Vag1 fBzyPUUOHobZQoMxOYllU55+mw== X-Received: by 2002:a1c:6484:: with SMTP id y126mr292412wmb.76.1610392809471; Mon, 11 Jan 2021 11:20:09 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id n3sm778090wrw.61.2021.01.11.11.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 11:20:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 30/40] drm/amd/display/dc/dce110/dce110_timing_generator_v: Demote kernel-doc abuse and line up comments Date: Mon, 11 Jan 2021 19:19:16 +0000 Message-Id: <20210111191926.3688443-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210111191926.3688443-1-lee.jones@linaro.org> References: <20210111191926.3688443-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:54: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_v_enable_crtc' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:216: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_v_wait_for_vactive' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../dc/dce110/dce110_timing_generator_v.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c index a13a2f58944e3..c509384fff543 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c @@ -46,17 +46,16 @@ * **********************************************************************************/ -/** -* Enable CRTCV -*/ +/* + * Enable CRTCV + */ static bool dce110_timing_generator_v_enable_crtc(struct timing_generator *tg) { /* -* Set MASTER_UPDATE_MODE to 0 -* This is needed for DRR, and also suggested to be default value by Syed. -*/ - + * Set MASTER_UPDATE_MODE to 0 + * This is needed for DRR, and also suggested to be default value by Syed. + */ uint32_t value; value = 0; @@ -209,9 +208,9 @@ static void dce110_timing_generator_v_wait_for_vblank(struct timing_generator *t } } -/** -* Wait till we are in VActive (anywhere in VActive) -*/ +/* + * Wait till we are in VActive (anywhere in VActive) + */ static void dce110_timing_generator_v_wait_for_vactive(struct timing_generator *tg) { while (dce110_timing_generator_v_is_in_vertical_blank(tg)) {