From patchwork Tue Nov 24 19:37:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331417 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795575ilb; Tue, 24 Nov 2020 11:44:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzai2PipPfGBBVrkrQElPM1fVBcjuXaJmC6kIL4t3y/Y0y61sKUzigKtAW/Zpko2QiCv34/ X-Received: by 2002:a17:90a:6b0d:: with SMTP id v13mr195847pjj.206.1606247073066; Tue, 24 Nov 2020 11:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247073; cv=none; d=google.com; s=arc-20160816; b=B59ez3PXGmORSdeAjoJrO1hkIzbzOvf5NwiNtpXGiQxBqSnYcMUyghM97mzJMJQyJv EStG3ViJjvW0F4keKdXxzCsytS9iukwGm0S2hbI4otCz5cPjWEqhob6s0CYyxB0CpfFA CFJkwkl3MPODgviDKFg/rURFmgHD2t4epEGjLIZjn831Hn7lziNBSokkqZAimW3zg8QW WQKaXwsD2UpwSDnz2pd83nZzQj5+zZnpCtnYYpt0vlaSmbEJoURt55SmSihDSEgdbxaV G3M8FhlI3kIhjZ44XlVSx4xkJbN3QO3gB/b/Yvx96EGV0Wja0g5ajadTxzpEOnRfx0y2 m2ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=hVCrDt0eSNZACqRVg5fGjVuQL+S17S5ZeV+AIWY5aHk=; b=KqRZxUV3fJXCsnYgVT8z6wszELZS+Z4KHe+GMIf2wQ2bw2UBlrqMl2owSVnt5vqby2 MElv2oBcF9zCJwDd2/pAHzIkAWXi+sRTh1KgOIH0tMxaJLXaSZ/AlBW/fkXqBQ3l2iCC P6Yb8cmIJre4Cr02/Zdufht33fLwx3MAQd3mG6UVUipB6iQFC8Oq1scs1/Xk5/EGweuX ZV53Iiq8drdQuM1UrP/kDDV+WHREoYh/PM2mM6tSPuyzYAHBTJO9DvACuDIrQdRokGtN PvWO/JOVBiv2Wd2s4zpKl6uwk4rKBJSnQjzhx9tJ17GILqVJ6afb/W+Ug9MxFBqubsJG TYAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Ag7rhcl7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p9si42104plr.249.2020.11.24.11.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Ag7rhcl7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E527B6E558; Tue, 24 Nov 2020 19:44:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id C18216E53E for ; Tue, 24 Nov 2020 19:44:06 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a186so87834wme.1 for ; Tue, 24 Nov 2020 11:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qjbxtDMJ2mzJHY8erVLf4gsozStccXbO1UKtGEg99mY=; b=Ag7rhcl7/rvzeLuAHjQfgJaFLQTfabEOu2bp+usdtMNvawzlH0cWoeYgVAdlXm/biq ZuPZfgyx6m2NUQSEkBnlnJJgAXw7ZL9Gedeo4VS1wjsX5Hosf48qqXr8+c//c3dxeNRX v+AvpZmgpG4hKWD+bq6vwgrjIVLgu5N+EzNskBVkez4sbFuZu9H6EpivWUedWLSDWYK1 mbF9KJ4sS+HvbukWNxWHNN25abdGc9B/vDEwX6zmmqtUntUPPJsgbCRMT85DKyPHbldD tc7RQJb0a8JDuMWutpdlsBpUPy5fyXLlIYLwhfDXXgG8vvGVl0QJ1NaL/tEHLpXs9bhj gX4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qjbxtDMJ2mzJHY8erVLf4gsozStccXbO1UKtGEg99mY=; b=hhi8+xf8jPcKA23DCGEezBHDsKLd1d1HWgEFCLZBQ80XX0N8diZiNA/7ZanP6jY3r0 TRXuoiZfy+fqIspMeQWKaBWqquhLG+ibJWUwdIDAsc4OVMkd0QChED19psVTzHnMHEK2 4daPR4ozhWbbwhZ9n7cj0hH/Ezdw/dVGaDLC7Dlummp1cDJdlQ9agJuvFPyoI9COtWOw qHfpmWDktv1HEeTXOXcJNgGhhGuj9ZgpWWVyp11kE6d+DtUmQbOYR1Yu1Rys4D72stk+ KkQqdKLzfSyrOWnd7QLfoTw8+W+yyOrX4DV9rztLyNKT9qqnR+Pdp6a9fbMSyzshR8di H8HQ== X-Gm-Message-State: AOAM530i1LkWRDWXlOH78tALtgMgPjR5T1o+6rLFNqf33irH25KJVrKV 2GTkKtrHAKa3nuHWR3Jd7bAUjw== X-Received: by 2002:a05:600c:2908:: with SMTP id i8mr188239wmd.182.1606247045448; Tue, 24 Nov 2020 11:44:05 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/40] drm/amd/amdgpu/tonga_ih: Provide some missing descriptions for 'ih' and 'entry' Date: Tue, 24 Nov 2020 19:37:49 +0000 Message-Id: <20201124193824.1118741-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/tonga_ih.c:193: warning: Function parameter or member 'ih' not described in 'tonga_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/tonga_ih.c:225: warning: Function parameter or member 'ih' not described in 'tonga_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/tonga_ih.c:225: warning: Function parameter or member 'entry' not described in 'tonga_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/tonga_ih.c:255: warning: Function parameter or member 'ih' not described in 'tonga_ih_set_rptr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c index e40140bf6699c..ce3319993b4bd 100644 --- a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c @@ -181,6 +181,7 @@ static void tonga_ih_irq_disable(struct amdgpu_device *adev) * tonga_ih_get_wptr - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to fetch wptr * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer (VI). Also check for @@ -215,6 +216,8 @@ static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, * tonga_ih_decode_iv - decode an interrupt vector * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to decode + * @entry: IV entry to place decoded information into * * Decodes the interrupt vector at the current rptr * position and also advance the position. @@ -247,6 +250,7 @@ static void tonga_ih_decode_iv(struct amdgpu_device *adev, * tonga_ih_set_rptr - set the IH ring buffer rptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to set rptr * * Set the IH ring buffer rptr. */