From patchwork Tue Nov 24 19:38:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331430 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795903ilb; Tue, 24 Nov 2020 11:45:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaRUfonhN8OhB/WeygJEnSUqY/RTG9cdQeb39piH4t3jETV/Zn080tjv6akLRP1QT579jD X-Received: by 2002:a17:902:70cc:b029:d7:e8ad:26d4 with SMTP id l12-20020a17090270ccb02900d7e8ad26d4mr35330plt.33.1606247105884; Tue, 24 Nov 2020 11:45:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247105; cv=none; d=google.com; s=arc-20160816; b=iN8Y7WeVjKn6hz6zvKvn550zPI2pSI7XAQHS3/FNbq1xSchJ5yMn0AHtkmqGt/mVax f6K2XUIC9n1rnTBZGRhk49yXrr6XVN86HeDRZ54aOfPPqZd1jqP+eHs76alhcuXoAmxi kmtwNVGJI/KLomHLbqCkpAKY8nqvArhd5J4CCiSh9H1UsBpmCBsw8lvZPzMhKlJKqGPF Io0Th/jMzWPKtK/1/eI4N95XzmxCEvRplbfmqdLaCTR4m+VGYYZylYUiQsNPacgbvq8H UYK4pfY3oX0xWLAw4Cs0NEwXU+6ixs6kIoTNoGHwmoB4nigMys6RYm/pUy/DYoJ/VKwf v4hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=I5Tt1Cg6bTy0JH209ZbqkOBARNwW0MCUFBgflgGluzA=; b=FeJCUHQYPPlYmvol4mmjjSTXHOrTc3YpQBHfK5pxxVn+U5LF97cyLBPaDOrOPIyW4U pY0qWT04MlL8pBMpw1kTle988Yh8jcgH2toAs1t57DiGi8cNKsceqHIPvCcj8KPEvxQg eHj2kuYscp/amv+y8qVeqMLU9E685K46W+31PgxgY7ag+STK6qidOFCC2gbXxh8bndjW V0NkRwt6bbuNdx2XWJuCCxozGDUBh5vdeIpEFQeikB1JvyY3P9O8OOY+UWlEQnVXAGrh USn5Vl3s9eHsOPdhodifcM4kc3NkwZ7T9ybuoy1tNgLdyMnnYGWpMSA2q+PFjA218nzz vOfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="qaBWT/Q6"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id f21si2139669pgv.452.2020.11.24.11.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:45:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="qaBWT/Q6"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00CAB6E598; Tue, 24 Nov 2020 19:44:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FC426E52A for ; Tue, 24 Nov 2020 19:44:40 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id t4so10608570wrr.12 for ; Tue, 24 Nov 2020 11:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W6u+an5wg59Ub2sA6cm8lJFBFNrxCPWC3h0dHv9agJ0=; b=qaBWT/Q6pz1M3PpcFDRhQIo4cEBtP7U3p6y0c3+5YoHb62+wyYRFYSV0D8tSWEnaAY bg6H+JIVfADrkVr7VEK82A4v0DnZDSyGKYMptp1H90hMwtcrxSM9i7zG+Pscp00yT1Wx hkdpIf+rdv5UOWm4bUVkLgQBoosj6pd+Jx9b4gqrGcQOQrl7qK/cCtQ3OOQs9kHkOk+z 1vwJzHtce24IVBXYFUm+mfHLiy0XZO4yuhEP+FcJi2i6HQzV+lgVrrx8p11vRNZbqHnD tiSvV5CKnTRS1tM8NfZP+DdOJS0Ckdjev9rJK38fsOWR4GGT1dQx1IeJT9I++FVEEULc AV2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W6u+an5wg59Ub2sA6cm8lJFBFNrxCPWC3h0dHv9agJ0=; b=aOmT5ljhSOHnWWGGmvATAyz7OL5foun4Xu9+wSmgl79fWH77qgdvWQ7jSRM7qMLe1i BQtf+8sDOZ4iumSdE1LTmYlWsdWxu40QLTNkURt6ZFw4qOF2Vx+5oERk9AHugxw+5fZx 9qnf92UsLRsY02SHBUfhXSHPwCjBbdTbPUTKiKDgmMxDXQnNGRQqP31CI90ZP5p6rkRt GtLyL6ve02EtVBMOJBmPxlDPHuqGiHx8yjY3f/6vfYmLH9gD1FJG265hlt6dZvOGLW+j n+/uvne5mo5ShwQ+sYy+OYsdfc1KDTs7SLykOwmlfknQtDzU+9x0OQR4ezDdfgYdGLeS dSxw== X-Gm-Message-State: AOAM530rkeEEErVxL+MKk0zbhH4AbilWUEg0mhI4xp5Qd712RAd5W+k+ KlqGewiIpQOu6Ec6oNBFjzwQyQ== X-Received: by 2002:a5d:5552:: with SMTP id g18mr68528wrw.145.1606247079348; Tue, 24 Nov 2020 11:44:39 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 32/40] drm/amd/amdgpu/vcn_v2_0: Fix a few kernel-doc misdemeanours Date: Tue, 24 Nov 2020 19:38:16 +0000 Message-Id: <20201124193824.1118741-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:483: warning: Excess function parameter 'sw' description in 'vcn_v2_0_disable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:644: warning: Excess function parameter 'sw' description in 'vcn_v2_0_enable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1404: warning: Function parameter or member 'count' not described in 'vcn_v2_0_dec_ring_insert_nop' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1426: warning: Function parameter or member 'addr' not described in 'vcn_v2_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1426: warning: Function parameter or member 'seq' not described in 'vcn_v2_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1426: warning: Function parameter or member 'flags' not described in 'vcn_v2_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1426: warning: Excess function parameter 'fence' description in 'vcn_v2_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1465: warning: Function parameter or member 'job' not described in 'vcn_v2_0_dec_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1465: warning: Function parameter or member 'flags' not described in 'vcn_v2_0_dec_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1609: warning: Function parameter or member 'addr' not described in 'vcn_v2_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1609: warning: Function parameter or member 'seq' not described in 'vcn_v2_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1609: warning: Function parameter or member 'flags' not described in 'vcn_v2_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1609: warning: Excess function parameter 'fence' description in 'vcn_v2_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1636: warning: Function parameter or member 'job' not described in 'vcn_v2_0_enc_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1636: warning: Function parameter or member 'flags' not described in 'vcn_v2_0_enc_ring_emit_ib' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c index e285f9c9d460e..5687c5ed0fb99 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c @@ -475,7 +475,6 @@ static void vcn_v2_0_mc_resume_dpg_mode(struct amdgpu_device *adev, bool indirec * vcn_v2_0_disable_clock_gating - disable VCN clock gating * * @adev: amdgpu_device pointer - * @sw: enable SW clock gating * * Disable clock gating for VCN block */ @@ -636,7 +635,6 @@ static void vcn_v2_0_clock_gating_dpg_mode(struct amdgpu_device *adev, * vcn_v2_0_enable_clock_gating - enable VCN clock gating * * @adev: amdgpu_device pointer - * @sw: enable SW clock gating * * Enable clock gating for VCN block */ @@ -1397,6 +1395,7 @@ void vcn_v2_0_dec_ring_insert_end(struct amdgpu_ring *ring) * vcn_v2_0_dec_ring_insert_nop - insert a nop command * * @ring: amdgpu_ring pointer + * @count: the number of NOP packets to insert * * Write a nop command to the ring. */ @@ -1417,7 +1416,9 @@ void vcn_v2_0_dec_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) * vcn_v2_0_dec_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write a fence and a trap command to the ring. */ @@ -1454,7 +1455,9 @@ void vcn_v2_0_dec_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, u64 seq, * vcn_v2_0_dec_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer */ @@ -1600,7 +1603,9 @@ static void vcn_v2_0_enc_ring_set_wptr(struct amdgpu_ring *ring) * vcn_v2_0_enc_ring_emit_fence - emit an enc fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write enc a fence and a trap command to the ring. */ @@ -1625,7 +1630,9 @@ void vcn_v2_0_enc_ring_insert_end(struct amdgpu_ring *ring) * vcn_v2_0_enc_ring_emit_ib - enc execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write enc ring commands to execute the indirect buffer */