From patchwork Tue Nov 24 19:38:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331443 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp796176ilb; Tue, 24 Nov 2020 11:45:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdeJjag0YnWjTzTOL9Az4vkngH1xxwGrLPcsNKCQ81vWYSDz2SnhzgnyagG7GavaRqfmA8 X-Received: by 2002:a63:fa4a:: with SMTP id g10mr4437pgk.360.1606247128760; Tue, 24 Nov 2020 11:45:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247128; cv=none; d=google.com; s=arc-20160816; b=oqs2HmXe83+pu0ARxwOiOUJ3gRsBFzvoLyDHFiwH/RU09hNrIXDoQu0rSL/Sxufsfp lY2h4cLsBreCP7WbrL1KmbeDE3mzyYRp831pZjBmOeaCRUnQnUuf9wiRiCdsnlS5S407 TXOfPXbY/ETS39bFhtTPjF0gkcFU5Bpe4ZqAVXIyx7l8QFjUiaocqtH6N4h19kpxepMn Bse8PtgPTxAy0SPmSk+0Ow1kMP+JDtCkECchD8KGnwuWHjWi+Bi9Rpmx3YYyxvX5w0EI e5eEkkIkwI5j/rcb0sXrjf5EcKNyyPJiTZ660wFHvo7IPxUZLfd327tUq4DVW5UUECG4 WJ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=FahSiCTjhPUJwzSurFbIQSxN5LzewOL41vVuGXu193Y=; b=iIUCxh7bbxANP5EMFVrI27cSyu1hqAwN4nYfNUzVgfaLZuhp+hQdRmiWp21x2tYs3H xsk+cy4yjcTKfRbUWEXxX/wsBcPlCQKKWok2jRsuzRu7Xho14fmxVQJLu8XyKG/9AD8e HEWt6Wgww6nqqxGVPTWpd5UbuapMzhEKLsHy1y9JTyMzoAwPNERTRbrtJPEhVWJlA8Ic NJMBoOZOsHxvhdCsXeJN8GEc+8KXgT7Hkiqm0NX6Pmry4FSRKGyI1Vs8yStihThPYv9y Bw9nuwGQQ8pL/gaqFlO/EYVAPxYVfa8dnnmJVfnXR8pY3G/TJWvpnTFUrIyRfojFwgOs 78Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KX+rHvLc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id j1si61636plj.81.2020.11.24.11.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:45:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KX+rHvLc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D9E66E5BD; Tue, 24 Nov 2020 19:44:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7ABC6E54C for ; Tue, 24 Nov 2020 19:44:36 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id t4so10608400wrr.12 for ; Tue, 24 Nov 2020 11:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b/U28BTdBGMRnDOnXaXT9FPg1voaJCOCB5Rl4gPT4og=; b=KX+rHvLcQeAGt+G+t9x+57/PA61xVTZTNqvrigBRVwItHIZSEB9puNLgxNps76v3U7 +nctpHeQLuMb5l5/ossElcaIgrjUXHzAkRVRDbJQietyxRx7+E75MBsNDOAwIwJ1yVhp Kvx81ixX+I68QKaTdpbrHASnDDs9Qdf5452foUVxQQRkdW7xG15qBAL5FXNbeMz1FD68 nkFmgNlu20yIyV237M2WdFXXxjNyAygCIZsUoMyTdVxffvk2w/yRmbJKQ9m7SamyVpbz hC+Cb4ChBuj+pHQj9q6wwZiFDndnnz/UUyIQ+ATocaQC04K74bfUNcKB8GKtWnDSi0Lk p9bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b/U28BTdBGMRnDOnXaXT9FPg1voaJCOCB5Rl4gPT4og=; b=oA2hL0xmXkDuU4wcBuCxudn0EgsAJ1BV075XkuMCQ/2IUoy6EzaTVJf2bZHSIjqEyQ G1XfhPbouLH33+08AifZ2pZ1xhGUT3B0dGdSp8d5htjz1oHhLWwctIEz2U1iHgrjGUNT qGpk3k3D6R14Lb3/MAWYpp2kdAtzktB2T2M3Al6KumpVsvJddqEUcgCUez34Wod+bkc4 X5eRsXUXvsDhHEthPTd6pm73wq5E1Aq4AAz+iTregdMpW4rflXOoAlbRVrsU5caIpGoa p7IySbcPKrXrkS8y6C3OBKzLlo0c/rf4XhNKSENEsMLLG5Ua8oBWONU5YHVNzznZ405d uAFA== X-Gm-Message-State: AOAM533aPvU4w+1E8XrQAU641rWxdVGLYI8wQDtGlGhCje/CGTfe8NOY f6rOUY/wgTE3SSRrHbnscSrrFw== X-Received: by 2002:a5d:400a:: with SMTP id n10mr87661wrp.362.1606247075639; Tue, 24 Nov 2020 11:44:35 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 29/40] drm/amd/amdgpu/vcn_v1_0: Fix a few kernel-doc misdemeanours Date: Tue, 24 Nov 2020 19:38:13 +0000 Message-Id: <20201124193824.1118741-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:439: warning: Excess function parameter 'sw' description in 'vcn_v1_0_disable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:566: warning: Excess function parameter 'sw' description in 'vcn_v1_0_enable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'addr' not described in 'vcn_v1_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'seq' not described in 'vcn_v1_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Excess function parameter 'fence' description in 'vcn_v1_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1495: warning: Function parameter or member 'job' not described in 'vcn_v1_0_dec_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1495: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_dec_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'addr' not described in 'vcn_v1_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'seq' not described in 'vcn_v1_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Excess function parameter 'fence' description in 'vcn_v1_0_enc_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1655: warning: Function parameter or member 'job' not described in 'vcn_v1_0_enc_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1655: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_enc_ring_emit_ib' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 86e1ef732ebec..72148f3b27d04 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c @@ -431,7 +431,6 @@ static void vcn_v1_0_mc_resume_dpg_mode(struct amdgpu_device *adev) * vcn_v1_0_disable_clock_gating - disable VCN clock gating * * @adev: amdgpu_device pointer - * @sw: enable SW clock gating * * Disable clock gating for VCN block */ @@ -558,7 +557,6 @@ static void vcn_v1_0_disable_clock_gating(struct amdgpu_device *adev) * vcn_v1_0_enable_clock_gating - enable VCN clock gating * * @adev: amdgpu_device pointer - * @sw: enable SW clock gating * * Enable clock gating for VCN block */ @@ -1445,7 +1443,9 @@ static void vcn_v1_0_dec_ring_insert_end(struct amdgpu_ring *ring) * vcn_v1_0_dec_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write a fence and a trap command to the ring. */ @@ -1484,7 +1484,9 @@ static void vcn_v1_0_dec_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, u64 * vcn_v1_0_dec_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer */ @@ -1619,7 +1621,9 @@ static void vcn_v1_0_enc_ring_set_wptr(struct amdgpu_ring *ring) * vcn_v1_0_enc_ring_emit_fence - emit an enc fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write enc a fence and a trap command to the ring. */ @@ -1644,7 +1648,9 @@ static void vcn_v1_0_enc_ring_insert_end(struct amdgpu_ring *ring) * vcn_v1_0_enc_ring_emit_ib - enc execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write enc ring commands to execute the indirect buffer */