From patchwork Tue Nov 24 19:37:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331420 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795622ilb; Tue, 24 Nov 2020 11:44:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAGsfThPSSOGDhZKYiqwEZ1KCV0zylFbaYMFEZ3e6XzogJhVF9A/6fAVy8nfpYERy9e9o6 X-Received: by 2002:a62:27c1:0:b029:196:59dc:8e6 with SMTP id n184-20020a6227c10000b029019659dc08e6mr5203429pfn.72.1606247077579; Tue, 24 Nov 2020 11:44:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247077; cv=none; d=google.com; s=arc-20160816; b=GZHFfd0rMvNo3Hr94ieyiRQ6LpsoazHGjYr45iSeAJpCciNH1djOW90F8cM1/zP/64 Rgb0XAFQP9mnfY+B9p9kwBSsn0PFAQmQgGu1Pw4YnOf3xN+kB891HxhYxdczEbyI291z QOWJGMK3zOlX1Z0LiMYBBtXkN+2PzdgZ34oEbfOW93qDctiXXtuCyxh5xveYFDp3TTwI wKwh+zgE0+zDkvTpA3FkesKk69LH0tm6FjmmaY2GiUYxxnAHyly1o0MKm+MPcfoBg2QM viD2qAuteddKM17eq8k61RPkfg+fQ8x8q8rshkOK2NmZbpr/yDaxFTg81g/kRGdrInZR F/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=KfF9u0cxSgujfiFyVB48xgPhtmT2+8g/HJVvMA9pDIA=; b=fU8DySzWwl5aQBY6e8iZkmHs7ezxbVpXUfifanQvmwjbY8RtawxmkcIjivISKDZaWS Xpz5jeXN5MW/0IX6JT910q6tLc0wNKCPwwV9DJVyNVFR9C6UYf7JlnQ8PgfmPe3HGTvR yXHX9IRgZqZJaByhlUrXqVTBXN0ZhehHEfeLxJgw+R8tpCTxJPVhr4OMcyEE9IG3CnU+ KelwkwMSp7RDfrPkeSL5/8r5Hk7JJOZcj5piV13Mcu8Q53Eg9gWLqeQhb7E1ijnmxGme sMReZkWAcCEFL+aN2PUi9Kl9KSGzX77KXFtyKm57iB/rDDz+cGfi/21MByO7DH2SiWD9 c4bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nQxuyfZy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id k15si14802244pgn.200.2020.11.24.11.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nQxuyfZy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 746246E566; Tue, 24 Nov 2020 19:44:28 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96A346E53C for ; Tue, 24 Nov 2020 19:44:11 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id w24so105423wmi.0 for ; Tue, 24 Nov 2020 11:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eEjMnBpqRZf7QYQfeBkVq9GHSjZiAa3R2MyumxVQjCg=; b=nQxuyfZyrLc6yy0cC6OO28iMpbA3g68SZwmc8nH+2WzT/A9hGEJWsdoV9Pxc9FrTRn Y/c8zmaIhPXEZQx6TDah7htFUQdimDx1ELdmxZn9dXhpmz/7eQqwSp/Pq1Ko1uRQkR1I yDp8naTL2GOals/p1vqjO5M0LkD/TcxmH4B09TqjFSGDdsVF3OmDxjriT1ZKrG5vHmQp sq75q3UBrxZX/Rl8P0JlAK6gKBWxHWJydUI1Aeoch5D4p1ibAfZdq/6ELCIyixNc9TsQ dGGkQsep1Mjz9ZkRSD2tveFZWf8wiwjJQ7OfTNU5ntPPVO1jGDghkvZBLVyLEU8XXK6v 1eSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eEjMnBpqRZf7QYQfeBkVq9GHSjZiAa3R2MyumxVQjCg=; b=t9mxCMeL7Z3izMgCrEK19Vi+5gk+Aq4WLvtV0DS7k4Iqw5fpvX2FYVRQ621jN8XtnX DDd+bJd6aCbc0Ethfb6JYZPNalkgdo1Rmt6H/jCYX2dVEXwShrMVB8Vb+pbXiznqcj/u xman45JW6kpzsetLcXDrUWk3y+8+W8MAFsBQc10UuCnpm+3UdZmY0F8Nx+jE3xrMFg2u 3t82tMPXPoP6Ux3pYRm3chnkgBr3fzznF3rMHKVEEr/UZyn+TdxQBPdvlxLqKvJWY5EJ GYfT3oPJ55bzcgbxfYI4InuAxBWMoGp7Op+jnJ/9pQ85kiQv9L8jYTcgvUKZT8tMPipY z3GQ== X-Gm-Message-State: AOAM533KEOioSmsq4c7u8kRDAMVwhY17Rjh3nNChwaqP246ckvvpnbdm Nn+KTx3wY1P9/TFBcq8dZ0EkbA== X-Received: by 2002:a7b:ce0e:: with SMTP id m14mr170464wmc.17.1606247050295; Tue, 24 Nov 2020 11:44:10 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/40] drm/amd/amdgpu/vega10_ih: Add descriptions for 'ih' and 'entry' Date: Tue, 24 Nov 2020 19:37:53 +0000 Message-Id: <20201124193824.1118741-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhigang Luo , David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vega10_ih.c:377: warning: Function parameter or member 'ih' not described in 'vega10_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Function parameter or member 'ih' not described in 'vega10_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Function parameter or member 'entry' not described in 'vega10_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/vega10_ih.c:480: warning: Function parameter or member 'ih' not described in 'vega10_ih_irq_rearm' drivers/gpu/drm/amd/amdgpu/vega10_ih.c:513: warning: Function parameter or member 'ih' not described in 'vega10_ih_set_rptr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Zhigang Luo Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c index 407c6093c2ec0..578fdee5b9758 100644 --- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c @@ -366,6 +366,7 @@ static void vega10_ih_irq_disable(struct amdgpu_device *adev) * vega10_ih_get_wptr - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to fetch wptr * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer (VEGA10). Also check for @@ -430,6 +431,8 @@ static u32 vega10_ih_get_wptr(struct amdgpu_device *adev, * vega10_ih_decode_iv - decode an interrupt vector * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to decode + * @entry: IV entry to place decoded information into * * Decodes the interrupt vector at the current rptr * position and also advance the position. @@ -473,6 +476,7 @@ static void vega10_ih_decode_iv(struct amdgpu_device *adev, * vega10_ih_irq_rearm - rearm IRQ if lost * * @adev: amdgpu_device pointer + * @ih: IH ring to match * */ static void vega10_ih_irq_rearm(struct amdgpu_device *adev, @@ -505,6 +509,7 @@ static void vega10_ih_irq_rearm(struct amdgpu_device *adev, * vega10_ih_set_rptr - set the IH ring buffer rptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to set rptr * * Set the IH ring buffer rptr. */