From patchwork Mon Nov 16 17:40:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324489 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3506263ils; Mon, 16 Nov 2020 09:41:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzE5dHvAq+9++hj/HHAF7YRB3ij8uXLxN6SMgUURa+WQUK8Qs9tbIH5xRwnJulWVkNVOMZq X-Received: by 2002:aa7:8154:0:b029:156:4b89:8072 with SMTP id d20-20020aa781540000b02901564b898072mr15408949pfn.51.1605548504267; Mon, 16 Nov 2020 09:41:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605548504; cv=none; d=google.com; s=arc-20160816; b=geW+hYIH2kL1brOCM2C8yCUGh9+WobjUD8Ei3/yD70qIpneJcIXr9GtjI/fgYIg/tV GP5kzkYfxLmyTPQ3jH6gvFFTdPlVd2HiFEv4YTG4bQNTHNxcgLn++YRJM49pZCfp9Zbb SQSz9TSq3xVE3QE4KvwqUJCK3DcbS5LM0i+GX8i8423hRaRGrvZO26FlsaFt6f/jDaX2 1MrVhrxtiFq1ve2iQwbzjgT5gWq19DJh4jyo7iHgqe62zRwv3T8l5RTWCrkYaORMGOEn Weht/StSwyb6EXfvZiyAcXLSTkXDt7bmoQ4rbyxVWuF4+rC684+OALAlAxZ1zRc+AV13 /tJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=5TnLGeIEh9fWAKDd2hyl92SMhHT8ni8MVbWbPDANmI8=; b=dpOCFO3weItBbEHKDm3KmV5GUCtWgigE5I6/42gMOowIuvW4lmZkd4ayEwCM6o57WA xJMmhS/nbmuYUWkPX5grkP+DZif3EmyDvlbTQHmTPslV0nP8yztZ+qcOP7Ne7U7VSL4Y rvJBrxC11XDCztH7ABqG2bZkObDPbY4DAdem/9U7sXNtDUmHFM3vesjUoPotzwKMFT9H CJI6MxpNFt55aFj/EmSe85B9czIOMULCkjgiEHrKT+GkUjDLr6tIKbBctTMSzqwBV+o/ p0q4id832yoDFVeWekZh4U4hP9LmmT+MlqqcYvgHkXUN5hkgYDDiqhwmDxUBQqQEb09J pYcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gfFikjbN; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a10si16183881pga.137.2020.11.16.09.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gfFikjbN; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78AD36E9F2; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFB756E9ED for ; Mon, 16 Nov 2020 17:41:35 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id d142so38227wmd.4 for ; Mon, 16 Nov 2020 09:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=gfFikjbNe9YkvOd+VXcfbf0J4Wd2441zhnFbQBUFTSfGl/11fLgrzMNsROSrDNKZnB 56O56aOR/HmR02tQ/3tiNJAhdUCmKv3PyRLNB0tFPnqebgucJjargzJMwuSJqsg4qUDz lUADz1TsIKFAEDWw/i6YYk8HVxvDJqeRjFeh11I8P7jIVCANAQ8XqJPeo2AmjbptibFD 3BUaOo+e/x2FHDxxqyNUMx1CFmyFSNvfDMIXzxiO4enNnSLj6DwZyaW/AX6d3z+XhZkM Hol8SB/aqA0USEkFwB5UEN9vO92vFQ3LpEYj0SMeSchExJmGtxQjQooiNX6+MTrjskNO qkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=uV1JMju8r0tp5CKh8LhYAkSwpSvchBsT4n5Sc4xv6o0erQ29xqVuMS1yhvF6RRKsBO TMpMPNgzt9lVvTzt13Vv9Z7G4/Fx3yBD/Ir2lfv5aLBo7q4IA/bZ1I2NB4wl8qnFIcb/ 4LN+R3tr/gKpSiZd5yoqc8+Hu1T4K4OkgUu3dHKC2CxnukB0Rlyj72AzRDq6MO0GvjCg uY0+IiFuGbAfqjJGviMUVfOoPEQZtZnEp06tz4iA41DNsF5pZlBfUo1vzxmLxCQMHeMe JAU9F2o9j5uqwYuNRYUPyDGCr8MwGH3M5oXJ1N2+4oHWggRzQhvi7Q64JW9xGEwSossi utWg== X-Gm-Message-State: AOAM5311x+SBNbZ3ZLxVmdsaePeLFv27jZH8DoEkzVNIzNpsxhky0ykm Etk1E7m4JyhCyq2doOzJ+nN1aw== X-Received: by 2002:a1c:9ec9:: with SMTP id h192mr48224wme.8.1605548494375; Mon, 16 Nov 2020 09:41:34 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/42] drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header Date: Mon, 16 Nov 2020 17:40:41 +0000 Message-Id: <20201116174112.1833368-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This needs someone with in-depth knowledge of the driver to complete. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_needs_vblank' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'layer_nr' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_async_planes' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_client' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'hw_lock' not described in 'mtk_drm_crtc' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 193848fd75154..bfe9942305435 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -24,7 +24,7 @@ #include "mtk_drm_gem.h" #include "mtk_drm_plane.h" -/** +/* * struct mtk_drm_crtc - MediaTek specific crtc structure. * @base: crtc object. * @enabled: records whether crtc_enable succeeded @@ -34,6 +34,8 @@ * @mutex: handle to one of the ten disp_mutex streams * @ddp_comp_nr: number of components in ddp_comp * @ddp_comp: array of pointers the mtk_ddp_comp structures used by this crtc + * + * TODO: Needs update: this header is missing a bunch of member descriptions. */ struct mtk_drm_crtc { struct drm_crtc base;