From patchwork Mon Nov 16 17:36:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324436 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3502938ils; Mon, 16 Nov 2020 09:37:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJze6VXKNdGBOzVFRYu8g0aRRQZV+zD2ftfcJXV1AkvrhZNW/jiGEuaDxTKZNfKVJCAHgEte X-Received: by 2002:aa7:8704:0:b029:18a:e2c9:c38 with SMTP id b4-20020aa787040000b029018ae2c90c38mr14483871pfo.79.1605548235977; Mon, 16 Nov 2020 09:37:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605548235; cv=none; d=google.com; s=arc-20160816; b=1K2++b+LjX0n40+ag4xpBxV3JbezqbQ9xb/myAiusr2MTdyt6+Lvzk60ZpxFa710rG ePNDRdKhgVxFqsdMneK2wCV5euUrlsBUWAACto6GXBp41L1Q0Ujty1AGDxACZstVSv/h na4tDXMTHYFfVK+/6Tv4xCv/wHhXPvZdcM1r06yR1T4W5GacXN7G9TjKuAO+3zJG73ux cNKguaYU+JVOUflt/nF+M6mtDZmDyxB5AOle3Otka0n17HuI4wuKoUiGQeeOHpuBbc4u Ee3/zJ8fkZjYaLV3bhyzaWB38g3VqmwY2pcnAr3NbjW7/J6AXYu1IrXEzji94DsuCCW+ 2wWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ot4SWUAjr7XFzqCysQxwf1NlC/UeuZH1wGPzbh9G49Q=; b=AwLLmSsToeHct/LGftGf3mpFUHc1edXFLwEyuUm9FHSfhvE5ba2HuuG77cYGLsdsrR z4xSpkQmrELYjYEfH9jCH9GFZx6o6LfyJviCCTkV58cd1t3xTr7SYH/FWv0U59Rd05mv BaRvT4Des/Ec58LBaSTvEqhhRW55QKqpJoG6Zt/niCaFW1euxs28qHEa8bPjQEhz/7Ug m9Hwl0eGoMJVDrhg7JCnWn1qsXU+NtT4K5mQcvu4wDz076tTMwUErRMI94/hMEHFonLu A7uOH2PONEawMnPH7QuBhr7g2sudRBLwPADILMxN0lqvD2f0BpNbghSs1O+tYbj8009s ZmVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Rp3u8Jwo; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g15si4762pju.120.2020.11.16.09.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:37:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Rp3u8Jwo; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB13C6E038; Mon, 16 Nov 2020 17:37:11 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D82289FA6 for ; Mon, 16 Nov 2020 17:37:06 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id p1so19596972wrf.12 for ; Mon, 16 Nov 2020 09:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xb5oU/OD2Y3rEdVts+1SNNg+EwKMwAAR+VS8s4ifyQw=; b=Rp3u8JwosxZh0tOeegPBxxchLmVOYDwvYReTo37Z7mS8aEPbmb6WEaUD6M5dTaExSd xzcQJ4Sq1/oi3Lxxv8GqyecBWbauJ2CVW/X7CT+hhZiz9m4wmSUKFokcNvpH6fJEkPzB QOz8TiyiEQpjN7gUlhkDZH8soePq9CURV8V1prdX9MPZFc777IyoWRW42CCdNhNBO5Y3 npVM63rsAmWkWqXDUYLzA/Vrq40jzzHFZ9tshka692aiawIxhXa8tYxkiqEvRKizwNkR uX6ikzRdIoBV7hQ+3w+iZ+3uF5yMJ2D8HpTAjwF4jqxFOuvg550DFPYirq6Vp15qcLdY +Nxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xb5oU/OD2Y3rEdVts+1SNNg+EwKMwAAR+VS8s4ifyQw=; b=WnNqc2+zLatrIFJsooXMjrQuvghxlumNfaE1ygEY4DM5jmwDdEiZkusdlhatUBUtJA ugCP8KLOToPsnE5FkfiwlNUWZ0OtLd1/RuCCH1Ji4cbjFMq5kNW1cMCrZU9eYi5hXT6v MlcN1JHgGlZIq51h5rwzw+NnuryJ8UrKP06hlwt2mtz/t2Ew1XBcUjvvkAI2y4nersw+ E7XmljHa6803YPBGGsstoxTOLoJ84FDDYgeXSGV62juiJqD+0g97n8v1cGg9nf8VKm7K Q97ybqr8K7sOYuQCVKxJ+EsJtGRZEkqihOoWn21gjSKc1gD66j+ioevK6hTyD3CBTBQH JqXw== X-Gm-Message-State: AOAM533XZf4e9W5wNEUWWG++lSuLKGHwUydQLIvxuZ4MFtPSbFXKRr9Q 4DTxc5ERafhyelg2NQpJJYU8Gg== X-Received: by 2002:a5d:654b:: with SMTP id z11mr19684774wrv.291.1605548225053; Mon, 16 Nov 2020 09:37:05 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id 30sm16942828wrd.88.2020.11.16.09.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:37:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location Date: Mon, 16 Nov 2020 17:36:18 +0000 Message-Id: <20201116173700.1830487-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116173700.1830487-1-lee.jones@linaro.org> References: <20201116173700.1830487-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/atombios_encoders.c | 5 +-- drivers/gpu/drm/radeon/radeon_atombios.c | 1 + drivers/gpu/drm/radeon/radeon_atombios.h | 37 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 4 deletions(-) create mode 100644 drivers/gpu/drm/radeon/radeon_atombios.h diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index cc5ee1b3af84f..683de198e18d9 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -33,6 +33,7 @@ #include #include "atom.h" +#include "radeon_atombios.h" #include "radeon.h" #include "radeon_asic.h" #include "radeon_audio.h" @@ -296,10 +297,6 @@ static void radeon_atom_backlight_exit(struct radeon_encoder *encoder) #endif -/* evil but including atombios.h is much worse */ -bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, - struct drm_display_mode *mode); - static bool radeon_atom_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 5d25917251892..71bf2ed172697 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -34,6 +34,7 @@ #include "atom.h" #include "atom-bits.h" #include "radeon_asic.h" +#include "radeon_atombios.h" extern void radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, diff --git a/drivers/gpu/drm/radeon/radeon_atombios.h b/drivers/gpu/drm/radeon/radeon_atombios.h new file mode 100644 index 0000000000000..b7c76920feb7d --- /dev/null +++ b/drivers/gpu/drm/radeon/radeon_atombios.h @@ -0,0 +1,37 @@ +/* radeon_atombios.h -- Private header for radeon driver -*- linux-c -*- + * + * Copyright 2007-8 Advanced Micro Devices, Inc. + * Copyright 2008 Red Hat Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + * + * Authors: Dave Airlie + * Alex Deucher + */ + +#ifndef __RADEON_ATOMBIOS_H__ +#define __RADEON_ATOMBIOS_H__ + +struct drm_display_mode; +struct radeon_device; + +bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, + struct drm_display_mode *mode); + +#endif /* __RADEON_ATOMBIOS_H__ */