From patchwork Mon Nov 16 17:33:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324431 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3500814ils; Mon, 16 Nov 2020 09:34:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwSgybbGwqiU/95euMMNAfhfhVFRM22nMeNpKNDw3OJGmqIeXdWszDgvKnC5LvelW0g64E X-Received: by 2002:a17:90a:460b:: with SMTP id w11mr15902pjg.12.1605548050380; Mon, 16 Nov 2020 09:34:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605548050; cv=none; d=google.com; s=arc-20160816; b=uzc3Yc4pyClBHHMzfQsPtFIH6pD6xKZdey0pJUnWDqk367i0PUFMVVceqSk0WaBR+d yI5OIseQudjpC7Er9djLOYhWzaKrTO33aDy/DDMnkDS8DL+dasbj0I5rwGI9PHy3IdOM swjfgl6LqJmAqJuLvL2zaro9xYnMpSP+8VWrXBsTJdLhjSRGieIEBIUprFDdooY2ZQq5 GapMHiqCG62C6gjFB9OzUE1WP91C6T0dr6XXZM/y5SlG1/IiPrnFuUCnoQSaHAaTzn2g TqKNcDonaEfhNvlgtIBePG7KFxpIwCQC4zuZmkeQvlhyT5uiF3m4Z/X2G8wgiIBji0cU qjPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=v64TEXhhWGMb/caDvLF4xSoAvofsrOynkYw4Gw1iaUo=; b=0hh7pIIZumgCKJVf+yFAGdI2mtA/VHsvpaXueOmgzZJIT3IsZW7pE4ut25Fh/Ukzg3 mxxHo6WUXKzhJvvOA4RBvbUIPJ7htZmU1E5o24O4Uz2dV3ssVfp5uHWnIrB723JSvD7n Q2iFuRpIPweOnhz9tECz/BBCcbW3+Vt12UiEa6ZkoAwQtMkzCMcduHArmyHuqFrcrYAD krsp1QBk2IC8aFgeG7DYmHXeL4IVf6rzB2dRXewGtPqNLLwRknLPcbrxzBQ8OrnpGhcf ADw3U+8abUCKUolfJbUJHQJHT/Ci1AMHSWFRlV/Ww9m1VY9dffT8I8Q5aA5x805CCmuo NFWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=OPtujtuU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r6si15906904pgm.338.2020.11.16.09.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:34:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=OPtujtuU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30DD66E03A; Mon, 16 Nov 2020 17:34:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 217926E03A for ; Mon, 16 Nov 2020 17:34:05 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id o15so19620958wru.6 for ; Mon, 16 Nov 2020 09:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qEyPNgqrCvgW7yAtw6B6vQyE222bBpFcTf7vHkr21Ko=; b=OPtujtuUIiaHPXrwEHhBFdgesbmCfs+lQzSA9SMtgIcwEdph0SW0wllmS/L3kUHbce Y24r/TzNwhqkpzekveoWb2t/h8FdnLBdgOlMPfvBjCMe8Jm6tixGksZAvVCDSNvZllNX Awv7Cl117cA02/Z5UmFgwEmfpwAq22KGcXm07IXFwhz5WMOBfD1wfNjs1S31Sb5Sk4WT egyPpwERRQ/nrOL0xiS7btKXz53rGfcr/yv6NK8GkUlxkkvZ1jjLphtmn8iqqVCH9QkQ IxUTqhA9CNRLEmHcxm8l3EE8sPji/wzUvnULxrXfhBd3BS97mQjTD01EQKD4MprDzcPn m4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qEyPNgqrCvgW7yAtw6B6vQyE222bBpFcTf7vHkr21Ko=; b=Tgs4WzFHySqnPDKYBruvmHi66IByYCfluo0KJt/X2w8sCqbw1oXsNJdjClQThbbo5X k7P4pQ2HyEQwrLidV4QcfmZAgkc7ilh9/mUUltVPvg4dnKSt4TwqkfnKq8scLysgG/zM BCExJSSvx90PvgbodDYz5pWVxBUfRNJ5x4MqenY81Y/hF8AqxBMbqa/6JfZtioIOIG00 gBPKuwQUWtQO0rnAM1QgO341P9YhtjrWweWgDHSYl6Ypa6KH3G3yzM72gFsz826g2GhV IEhnNZo6aftmLQtpqAZ2EXqJ5oBO7VijBrWXoFASV7kUMbhm1XF3vvuQNPX13MbFSEEN UxNw== X-Gm-Message-State: AOAM533TGnuD7QHirYmxn9dZEDiEe1wyUhPabMEH46esesPHXJE6eDgg NrQZI923ddQHbCCl3x65paDSGA== X-Received: by 2002:adf:9e48:: with SMTP id v8mr21978405wre.55.1605548043787; Mon, 16 Nov 2020 09:34:03 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id k22sm20178562wmi.34.2020.11.16.09.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:34:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Date: Mon, 16 Nov 2020 17:33:15 +0000 Message-Id: <20201116173356.1828478-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116173356.1828478-1-lee.jones@linaro.org> References: <20201116173356.1828478-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Luben Tuikov , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg() since, according to Alex Deucher, "We call it again below indirectly". Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’: drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Luben Tuikov Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c index fa817ebff9804..6134ed9640279 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c @@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode struct backlight_properties props; struct amdgpu_backlight_privdata *pdata; struct amdgpu_encoder_atom_dig *dig; - u8 backlight_level; char bl_name[16]; /* Mac laptops with multiple GPUs use the gmux driver for backlight @@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode pdata->encoder = amdgpu_encoder; - backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev); - dig = amdgpu_encoder->enc_priv; dig->bl_dev = bd;