From patchwork Mon Nov 16 17:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324413 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3497825ils; Mon, 16 Nov 2020 09:30:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxE9pRmNEI1unEee4IjKfp+eV7nDg7eFBLupZEnTT8c5x/XB2HZGNbZW/lnMfIj1ghX4AJM X-Received: by 2002:a17:90a:4281:: with SMTP id p1mr17707967pjg.87.1605547815272; Mon, 16 Nov 2020 09:30:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605547815; cv=none; d=google.com; s=arc-20160816; b=WA6ddVCEbxOlLAL9mQ8T5IciAjQ0KslfMK0oGRIvJVe9nlE+2y6u2c7SAz+ANUuAAO jIoQ3sVJCuF0c6bW2pKiXCQEZQs3bXZf4TW/JjT00yNA6RNwaGSBaw7PrYfe51Y+Bynx 4W07D4GoL2EQUa07HZ67H7YNKG14ngwWrQT4yyOq3NFJkpQ8IaYG2lT1B7KsB6LRaXZM /yM3JO3Of9DN88YbMZ7vCZt7sATSiashF+pdHJNu7dkxl2ZQeeH5dRXI6eC/I3qeT4h8 5R1AX8g/0d0x1pVd4rd8tUik0Xh/LpuZ71SEi9jkKcQCZcWj2NHvHbk0iw9eagF/SBq1 ew5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ot4SWUAjr7XFzqCysQxwf1NlC/UeuZH1wGPzbh9G49Q=; b=yXPu6Gx4037xZBDie0xDwtw7jngSKTJmudP/Qnpxx+BjKGRy1niv/AIPjDi/yIReNn 6aT5xro+Zo32W8DlTbXegtZw3jhOkE5NdiwFgvXavkpdI2o0y/ojo/KiYhnBuVony7xW vGxMjKbMNVAOUjGWm2ted6R1LAIeIPsXjFaWBUSLUjpmr2D9KZUivwRWHYHUQtP0AWQw zg65FGJJlStrXKStr28yGfb6dA87KlHs+nvroY2xVVYCihzpyfEOC4aCPORPuz1y4zV7 Vk4z5egrOb69bOigYMbbJkAWrWBSbHf7WtqdWaaKFp9sr9m1htHFAF5FRCV2h660hbZF +Jvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=w7NXvRpz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id b10si16194091pgl.297.2020.11.16.09.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:30:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=w7NXvRpz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 357E489F75; Mon, 16 Nov 2020 17:30:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA76C89F77 for ; Mon, 16 Nov 2020 17:30:11 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id s13so24354260wmh.4 for ; Mon, 16 Nov 2020 09:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xb5oU/OD2Y3rEdVts+1SNNg+EwKMwAAR+VS8s4ifyQw=; b=w7NXvRpzd6ocS+5FSqdsaZu3FdrPnEfrBt31TUnTJfHGHtFLIb1PtdzBxYzLEJSZ4t UYtP+BvBN28qhjNd9+vn+MzSCwRZKFTMRSgwCK9yGwjcVWtpoO5rkrnAQTod5+uT6IS3 DG4NYRC7N1KBkVmUG67DnkwuVZPROZtBcouRJrbhrSd8AqALBM30h93G2mgoyLQE6RFp hfSLbsdUu+ywMyE6858tw/O7m6MhlJpSmHleJe4aLJ/S7nvDHaiv8xknh76zmJO5ULIJ IZmroZyYP259sTS2fWQKi+/wC6AWIddT2yAh9L1CuqHGP9qvCirPEqXUCuGW73RzSz8b J0vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xb5oU/OD2Y3rEdVts+1SNNg+EwKMwAAR+VS8s4ifyQw=; b=S7fil12jzcZdWtKME73bOh3Nqgl6/1cA2+vHUnkYAtqz7IBnnpuLeyLb5WHNHzdDfP 0tWMKfW4sG2vpfUAn8n8Eyc+Z1pVp/m7awUJCQFq7jiSlF5NQTShqC4aI7O/gD01CcBo rQQhpcQLeolIykPOELnhVgjEUl/L5hr2BHGdjRyOHM5hOdJ2V2CfiO2fa36ulxqZFA70 aTIoTi8joaRJyR8A2Gk44omjkN0fN9tQzaBKBepnNZL/vulBAx9+SGKLvB4X4bzHQN4C 8zOqFqQkwIJI6UEDtc5yKjz2KyKIrSojXfZUhgg7FSG9XXcb3gMrr2x1WTc09NVC0TSp I1sA== X-Gm-Message-State: AOAM532RgXSxGmf/0L5IYXMTBdH6oDy1qE4a5cpsHpGksAHJoKA90uh7 0J9scccPjcnBJxmeeMIis0GeNg== X-Received: by 2002:a1c:67d5:: with SMTP id b204mr16966162wmc.92.1605547810539; Mon, 16 Nov 2020 09:30:10 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id f23sm20054854wmb.43.2020.11.16.09.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:30:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location Date: Mon, 16 Nov 2020 17:29:23 +0000 Message-Id: <20201116173005.1825880-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116173005.1825880-1-lee.jones@linaro.org> References: <20201116173005.1825880-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/atombios_encoders.c | 5 +-- drivers/gpu/drm/radeon/radeon_atombios.c | 1 + drivers/gpu/drm/radeon/radeon_atombios.h | 37 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 4 deletions(-) create mode 100644 drivers/gpu/drm/radeon/radeon_atombios.h diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index cc5ee1b3af84f..683de198e18d9 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -33,6 +33,7 @@ #include #include "atom.h" +#include "radeon_atombios.h" #include "radeon.h" #include "radeon_asic.h" #include "radeon_audio.h" @@ -296,10 +297,6 @@ static void radeon_atom_backlight_exit(struct radeon_encoder *encoder) #endif -/* evil but including atombios.h is much worse */ -bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, - struct drm_display_mode *mode); - static bool radeon_atom_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 5d25917251892..71bf2ed172697 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -34,6 +34,7 @@ #include "atom.h" #include "atom-bits.h" #include "radeon_asic.h" +#include "radeon_atombios.h" extern void radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, diff --git a/drivers/gpu/drm/radeon/radeon_atombios.h b/drivers/gpu/drm/radeon/radeon_atombios.h new file mode 100644 index 0000000000000..b7c76920feb7d --- /dev/null +++ b/drivers/gpu/drm/radeon/radeon_atombios.h @@ -0,0 +1,37 @@ +/* radeon_atombios.h -- Private header for radeon driver -*- linux-c -*- + * + * Copyright 2007-8 Advanced Micro Devices, Inc. + * Copyright 2008 Red Hat Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + * + * Authors: Dave Airlie + * Alex Deucher + */ + +#ifndef __RADEON_ATOMBIOS_H__ +#define __RADEON_ATOMBIOS_H__ + +struct drm_display_mode; +struct radeon_device; + +bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, + struct drm_display_mode *mode); + +#endif /* __RADEON_ATOMBIOS_H__ */