From patchwork Thu Nov 12 19:00:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324226 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp588895ils; Thu, 12 Nov 2020 11:01:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzyhMwfIC6dZw+iu1YsVzUGeL2pGUOsdh/UuUpQeJXxWxpuAoYH6h4zzUKbRY1ePaWCKbr X-Received: by 2002:a17:90a:d70d:: with SMTP id y13mr685181pju.138.1605207666264; Thu, 12 Nov 2020 11:01:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605207666; cv=none; d=google.com; s=arc-20160816; b=W1FWQmEpraBHR0j5g5UoKqqHcYsUGcvPwpeUeTVjyy7qR9FojAzupEQ7rd/LtVaYR7 pBi75d7CmKReJuuxin9UqHkvjOREtT2kjGvn9cW1t25HcJ3dbQmguYkxnJRxJy0fm1UX xoeNlVbSmGuqpPRVBsKKSyOwlJ4W4JF9P0M7a5ThzH0riYC+I6rrjLTAW9KMPK7vBu7S sff/zkYOx4bnG0efmgA7iKbDWEkfv3uwaXQcV+Cu7dsfFRVwsmxYf+olJ+/uXCCtntbW +NqYfswh+BD2n9D6RMkdhQsCD1XF1XdmtRxzp3qlNmZiOp+hXW4XoJSPmrU3OZsP5wLu eCJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=qzEIUTamGn7lkUp8CN1UFpBQB8h0zkq/imAT60MVDFE=; b=AD3LZcbWxQX2YYkb369SS/2FXB/H2TWSCmZ1waWggKA+8U4Gs/b0sOFNSgA6Ho9YXA C3Kl3vkvh3gyoU53P5WVjISkW1kPqV1ZIC70H6d6StFL5nS2UJJo8FS3WTbB/Lc2b/2U oGEe508MsdLO08JUuzLuLUxMHqBNMrWPRL9Dnzvq/3sAZ9sf8pnWaW8B4Y2nctnxclzS V64pTIAI4bhSKh0qXbUejhxP2ILM7k2f6sttKcTPDfZVT5MIASvpiZ+kLdYviwhq451t NRB5gFduzHpzjrXkfdmQUTDyGqvchnKAvrCYuRHN0KKt73s1P4cTgqDA7h+9Juq3jDAe zEQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=R5t7wb0Q; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d11si2323587pjw.59.2020.11.12.11.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 11:01:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=R5t7wb0Q; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 579E46E32A; Thu, 12 Nov 2020 19:01:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 638D96E32A for ; Thu, 12 Nov 2020 19:01:03 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id c9so6180958wml.5 for ; Thu, 12 Nov 2020 11:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mzTBD6bXnToow7y30j0wcO7cLIFklFZSxhnu2Adjze8=; b=R5t7wb0QJwlNzlSddPQ32LAfqqewHgBSYPv56bsw5qfjGDpNqJXAat91m8ZBaDWnzU z7qLGrUP+h/Gg/YDb6dObuaLLdYddhhni2yPpZQj55OpxnRzyOsgNzJG8dEH8zhJLSks xVNqGy7nRmLEfLGxYxbuOuoP8xA7fg9zh/sVjgPAiVryTR332MRwRsLyllFWNNuoJPoX Z4EsbpQhUOTY6CE/1lJVahnVCddCTkEmn0nbx4EqomedksR7JEJ6EqXudECIu/5vUJsQ 5ev5kB6ttgvJSvlNW5nT52+VPMePRlJIs3ZdEH3rG9y2S2SM9CXNoelER4mNKSDE3JD8 1ZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mzTBD6bXnToow7y30j0wcO7cLIFklFZSxhnu2Adjze8=; b=q+XxUMeCtMTLEwCTyDOKIDSUGJub08k+ikKORBFS2X5HtXqMWT9JQhpb1pIyFZSHZ5 bRpVCpW1PckuRManEUTtWdJb/uxQ7Xqcuzjnh0i6D22ybj9LRimaQCiva26J6J79Q5Xx bIWHEkB9hyg9RALKbS+4/XEMT3Jh3pTH+36BoKG24NUEipylRTUG42v+0fu3bbsizgTL 0NHU9EElAOojEuSgdn7B54/qO/R/nYbQ02oTQLu/YEG+oYs/Ij0WKUk1bo8VDL/w+c4o LC3CNwV6kfhnZWz77O5Vb29kt75vaiW68/+7jPxfnxPELV++aOkNr47guKy07FuNYRgQ 4VVA== X-Gm-Message-State: AOAM533quCPvfxzRRgI2jDjKao2B3fWlsf6W4WwHVaGEWBLw8Ub/hS2c aHeBWoK9LZWEW4lsAYnle0344w== X-Received: by 2002:a7b:c8d3:: with SMTP id f19mr1042992wml.17.1605207661941; Thu, 12 Nov 2020 11:01:01 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id p4sm8105214wrm.51.2020.11.12.11.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 11:01:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/30] drm/amd/amdgpu/amdgpu_fence: Fix some issues pertaining to function documentation Date: Thu, 12 Nov 2020 19:00:16 +0000 Message-Id: <20201112190039.2785914-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112190039.2785914-1-lee.jones@linaro.org> References: <20201112190039.2785914-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, Jerome Glisse , dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:139: warning: Function parameter or member 'flags' not described in 'amdgpu_fence_emit' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:197: warning: Function parameter or member 'timeout' not described in 'amdgpu_fence_emit_polling' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:302: warning: Function parameter or member 't' not described in 'amdgpu_fence_fallback' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:302: warning: Excess function parameter 'work' description in 'amdgpu_fence_fallback' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:320: warning: Excess function parameter 'adev' description in 'amdgpu_fence_wait_empty' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:649: warning: Function parameter or member 'f' not described in 'amdgpu_fence_enable_signaling' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:649: warning: Excess function parameter 'fence' description in 'amdgpu_fence_enable_signaling' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:684: warning: Function parameter or member 'f' not described in 'amdgpu_fence_release' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:684: warning: Excess function parameter 'fence' description in 'amdgpu_fence_release' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:749: warning: Function parameter or member 'm' not described in 'amdgpu_debugfs_gpu_recover' drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:749: warning: Function parameter or member 'data' not described in 'amdgpu_debugfs_gpu_recover' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c index fe2d495d08ab0..d56f4023ebb31 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c @@ -130,6 +130,7 @@ static u32 amdgpu_fence_read(struct amdgpu_ring *ring) * * @ring: ring the fence is associated with * @f: resulting fence object + * @flags: flags to pass into the subordinate .emit_fence() call * * Emits a fence command on the requested ring (all asics). * Returns 0 on success, -ENOMEM on failure. @@ -187,6 +188,7 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct dma_fence **f, * * @ring: ring the fence is associated with * @s: resulting sequence number + * @timeout: the timeout for waiting in usecs * * Emits a fence command on the requested ring (all asics). * Used For polling fence. @@ -294,7 +296,7 @@ bool amdgpu_fence_process(struct amdgpu_ring *ring) /** * amdgpu_fence_fallback - fallback for hardware interrupts * - * @work: delayed work item + * @t: timer context used to obtain the pointer to ring structure * * Checks for fence activity. */ @@ -310,7 +312,6 @@ static void amdgpu_fence_fallback(struct timer_list *t) /** * amdgpu_fence_wait_empty - wait for all fences to signal * - * @adev: amdgpu device pointer * @ring: ring index the fence is associated with * * Wait for all fences on the requested ring to signal (all asics). @@ -639,7 +640,7 @@ static const char *amdgpu_fence_get_timeline_name(struct dma_fence *f) /** * amdgpu_fence_enable_signaling - enable signalling on fence - * @fence: fence + * @f: fence * * This function is called with fence_queue lock held, and adds a callback * to fence_queue that checks if this fence is signaled, and if so it @@ -675,7 +676,7 @@ static void amdgpu_fence_free(struct rcu_head *rcu) /** * amdgpu_fence_release - callback that fence can be freed * - * @fence: fence + * @f: fence * * This function is called when the reference count becomes zero. * It just RCU schedules freeing up the fence. @@ -740,7 +741,7 @@ static int amdgpu_debugfs_fence_info(struct seq_file *m, void *data) return 0; } -/** +/* * amdgpu_debugfs_gpu_recover - manually trigger a gpu reset & recover * * Manually trigger a gpu reset at the next fence wait.