| Message ID | 20201112190039.2785914-3-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | e232e3d4ea4a313af4ec0ce316516fcec369585e |
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
Hi Lee, On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > The precedent has already been set by other macros in the same file. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] > 55 | struct drm_crtc *crtc; > | ^~~~ > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Clark <robdclark@gmail.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Also applied to drm-misc-next. This was the last patch from this batch I will process. The others are left for the maintainers to pick up. Sam
On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > Hi Lee, > > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > The precedent has already been set by other macros in the same file. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] > > 55 | struct drm_crtc *crtc; > > | ^~~~ > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Also applied to drm-misc-next. > This was the last patch from this batch I will process. > The others are left for the maintainers to pick up. btw for patches that maintainers don't pick up, the usual process is that we give them 2 weeks, then just mass apply. Now you're producing a lot of patches, too much for me to keep track, so please just ping me with a resend for those that expired and I'll go through and pick them all up. Cheers, Daniel > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > Hi Lee, > > > > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > The precedent has already been set by other macros in the same file. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set > but not used [-Wunused-but-set-variable] > > > 55 | struct drm_crtc *crtc; > > > | ^~~~ > > > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Cc: Maxime Ripard <mripard@kernel.org> > > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > Cc: David Airlie <airlied@linux.ie> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Rob Clark <robdclark@gmail.com> > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > Also applied to drm-misc-next. > > This was the last patch from this batch I will process. > > The others are left for the maintainers to pick up. > > btw for patches that maintainers don't pick up, the usual process is that > we give them 2 weeks, then just mass apply. Now you're producing a lot of > patches, too much for me to keep track, so please just ping me with a > resend for those that expired and I'll go through and pick them all up. > That's great Daniel. Thanks for your support. I can do one better than that. Would a pull-request suit you? > <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <<a href="mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote:<br> > Hi Lee,<br> > <br> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote:<br> > > The precedent has already been set by other macros in the same file.<br> > > <br> > > Fixes the following W=1 kernel build warning(s):<br> > > <br> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable]<br> > > 55 | struct drm_crtc *crtc;<br> > > | ^~~~<br> > > <br> > > Cc: Maarten Lankhorst <<a href="mailto:maarten.lankhorst@linux.intel.com" target="_blank" rel="noreferrer">maarten.lankhorst@linux.intel.com</a>><br> > > Cc: Maxime Ripard <<a href="mailto:mripard@kernel.org" target="_blank" rel="noreferrer">mripard@kernel.org</a>><br> > > Cc: Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de" target="_blank" rel="noreferrer">tzimmermann@suse.de</a>><br> > > Cc: David Airlie <<a href="mailto:airlied@linux.ie" target="_blank" rel="noreferrer">airlied@linux.ie</a>><br> > > Cc: Daniel Vetter <<a href="mailto:daniel@ffwll.ch" target="_blank" rel="noreferrer">daniel@ffwll.ch</a>><br> > > Cc: Rob Clark <<a href="mailto:robdclark@gmail.com" target="_blank" rel="noreferrer">robdclark@gmail.com</a>><br> > > Cc: <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a><br> > > Signed-off-by: Lee Jones <<a href="mailto:lee.jones@linaro.org" target="_blank" rel="noreferrer">lee.jones@linaro.org</a>><br> > <br> > Also applied to drm-misc-next.<br> > This was the last patch from this batch I will process.<br> > The others are left for the maintainers to pick up.<br> <br> btw for patches that maintainers don't pick up, the usual process is that<br> we give them 2 weeks, then just mass apply. Now you're producing a lot of<br> patches, too much for me to keep track, so please just ping me with a<br> resend for those that expired and I'll go through and pick them all up.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">That's great Daniel. Thanks for your support. </div><div dir="auto"><br></div><div dir="auto">I can do one better than that. </div><div dir="auto"><br></div><div dir="auto">Would a pull-request suit you? </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: >> >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: >> > Hi Lee, >> > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: >> > > The precedent has already been set by other macros in the same file. >> > > >> > > Fixes the following W=1 kernel build warning(s): >> > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] >> > > 55 | struct drm_crtc *crtc; >> > > | ^~~~ >> > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> > > Cc: Maxime Ripard <mripard@kernel.org> >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> >> > > Cc: David Airlie <airlied@linux.ie> >> > > Cc: Daniel Vetter <daniel@ffwll.ch> >> > > Cc: Rob Clark <robdclark@gmail.com> >> > > Cc: dri-devel@lists.freedesktop.org >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> >> > >> > Also applied to drm-misc-next. >> > This was the last patch from this batch I will process. >> > The others are left for the maintainers to pick up. >> >> btw for patches that maintainers don't pick up, the usual process is that >> we give them 2 weeks, then just mass apply. Now you're producing a lot of >> patches, too much for me to keep track, so please just ping me with a >> resend for those that expired and I'll go through and pick them all up. > > > That's great Daniel. Thanks for your support. > > I can do one better than that. > > Would a pull-request suit you? We have a few trees going on, and your patches are landing through all kinds of them. So this might be more coordination pain. If you can exclude patches for the separately and usually fairly well maintained drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). Or you just send the next pile and we'll see. Also I guess I can't really interest you in commit rights so this patch bombs get off my back again? :-) Cheers, Daniel
On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <daniel@ffwll.ch> wrote: > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > >> > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > >> > Hi Lee, > >> > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > >> > > The precedent has already been set by other macros in the same file. > >> > > > >> > > Fixes the following W=1 kernel build warning(s): > >> > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > set but not used [-Wunused-but-set-variable] > >> > > 55 | struct drm_crtc *crtc; > >> > > | ^~~~ > >> > > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > >> > > Cc: Maxime Ripard <mripard@kernel.org> > >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > >> > > Cc: David Airlie <airlied@linux.ie> > >> > > Cc: Daniel Vetter <daniel@ffwll.ch> > >> > > Cc: Rob Clark <robdclark@gmail.com> > >> > > Cc: dri-devel@lists.freedesktop.org > >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > >> > > >> > Also applied to drm-misc-next. > >> > This was the last patch from this batch I will process. > >> > The others are left for the maintainers to pick up. > >> > >> btw for patches that maintainers don't pick up, the usual process is > that > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > of > >> patches, too much for me to keep track, so please just ping me with a > >> resend for those that expired and I'll go through and pick them all up. > > > > > > That's great Daniel. Thanks for your support. > > > > I can do one better than that. > > > > Would a pull-request suit you? > > We have a few trees going on, and your patches are landing through all > kinds of them. So this might be more coordination pain. If you can > exclude patches for the separately and usually fairly well maintained > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > Or you just send the next pile and we'll see. > > Also I guess I can't really interest you in commit rights so this > patch bombs get off my back again? :-) > What does that mean? Merge my own patches? Not sure how that works with your group maintenance setup. Is it just a `git push`? > <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <<a href="mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <<a href="mailto:lee.jones@linaro.org" target="_blank" rel="noreferrer">lee.jones@linaro.org</a>> wrote:<br> ><br> ><br> ><br> > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <<a href="mailto:daniel@ffwll.ch" target="_blank" rel="noreferrer">daniel@ffwll.ch</a>> wrote:<br> >><br> >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote:<br> >> > Hi Lee,<br> >> ><br> >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote:<br> >> > > The precedent has already been set by other macros in the same file.<br> >> > ><br> >> > > Fixes the following W=1 kernel build warning(s):<br> >> > ><br> >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable]<br> >> > > 55 | struct drm_crtc *crtc;<br> >> > > | ^~~~<br> >> > ><br> >> > > Cc: Maarten Lankhorst <<a href="mailto:maarten.lankhorst@linux.intel.com" target="_blank" rel="noreferrer">maarten.lankhorst@linux.intel.com</a>><br> >> > > Cc: Maxime Ripard <<a href="mailto:mripard@kernel.org" target="_blank" rel="noreferrer">mripard@kernel.org</a>><br> >> > > Cc: Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de" target="_blank" rel="noreferrer">tzimmermann@suse.de</a>><br> >> > > Cc: David Airlie <<a href="mailto:airlied@linux.ie" target="_blank" rel="noreferrer">airlied@linux.ie</a>><br> >> > > Cc: Daniel Vetter <<a href="mailto:daniel@ffwll.ch" target="_blank" rel="noreferrer">daniel@ffwll.ch</a>><br> >> > > Cc: Rob Clark <<a href="mailto:robdclark@gmail.com" target="_blank" rel="noreferrer">robdclark@gmail.com</a>><br> >> > > Cc: <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a><br> >> > > Signed-off-by: Lee Jones <<a href="mailto:lee.jones@linaro.org" target="_blank" rel="noreferrer">lee.jones@linaro.org</a>><br> >> ><br> >> > Also applied to drm-misc-next.<br> >> > This was the last patch from this batch I will process.<br> >> > The others are left for the maintainers to pick up.<br> >><br> >> btw for patches that maintainers don't pick up, the usual process is that<br> >> we give them 2 weeks, then just mass apply. Now you're producing a lot of<br> >> patches, too much for me to keep track, so please just ping me with a<br> >> resend for those that expired and I'll go through and pick them all up.<br> ><br> ><br> > That's great Daniel. Thanks for your support.<br> ><br> > I can do one better than that.<br> ><br> > Would a pull-request suit you?<br> <br> We have a few trees going on, and your patches are landing through all<br> kinds of them. So this might be more coordination pain. If you can<br> exclude patches for the separately and usually fairly well maintained<br> drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915,<br> drm/nouveau, drm/msm and drm/omapdrm probably the usual ones).<br> <br> Or you just send the next pile and we'll see.<br> <br> Also I guess I can't really interest you in commit rights so this<br> patch bombs get off my back again? :-)<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">What does that mean? Merge my own patches? </div><div dir="auto"><br></div><div dir="auto">Not sure how that works with your group maintenance setup. </div><div dir="auto"><br></div><div dir="auto">Is it just a `git push`? </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, 13 Nov 2020, Daniel Vetter wrote: > On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > Hi Lee, > > > > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > The precedent has already been set by other macros in the same file. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] > > > 55 | struct drm_crtc *crtc; > > > | ^~~~ > > > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Cc: Maxime Ripard <mripard@kernel.org> > > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > Cc: David Airlie <airlied@linux.ie> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Rob Clark <robdclark@gmail.com> > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > Also applied to drm-misc-next. > > This was the last patch from this batch I will process. > > The others are left for the maintainers to pick up. > > btw for patches that maintainers don't pick up, the usual process is that > we give them 2 weeks, then just mass apply. Now you're producing a lot of > patches, too much for me to keep track, so please just ping me with a > resend for those that expired and I'll go through and pick them all up. Okay, I have split the remaining patches into 2 new sets. One for Radeon, the other for everything else. Hopefully that makes things easier/more obvious.
On Fri, Nov 13, 2020 at 10:01:57PM +0000, Lee Jones wrote: > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > > >> > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > >> > Hi Lee, > > >> > > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > >> > > The precedent has already been set by other macros in the same file. > > >> > > > > >> > > Fixes the following W=1 kernel build warning(s): > > >> > > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > > set but not used [-Wunused-but-set-variable] > > >> > > 55 | struct drm_crtc *crtc; > > >> > > | ^~~~ > > >> > > > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > >> > > Cc: Maxime Ripard <mripard@kernel.org> > > >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > >> > > Cc: David Airlie <airlied@linux.ie> > > >> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > >> > > Cc: Rob Clark <robdclark@gmail.com> > > >> > > Cc: dri-devel@lists.freedesktop.org > > >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > >> > > > >> > Also applied to drm-misc-next. > > >> > This was the last patch from this batch I will process. > > >> > The others are left for the maintainers to pick up. > > >> > > >> btw for patches that maintainers don't pick up, the usual process is > > that > > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > > of > > >> patches, too much for me to keep track, so please just ping me with a > > >> resend for those that expired and I'll go through and pick them all up. > > > > > > > > > That's great Daniel. Thanks for your support. > > > > > > I can do one better than that. > > > > > > Would a pull-request suit you? > > > > We have a few trees going on, and your patches are landing through all > > kinds of them. So this might be more coordination pain. If you can > > exclude patches for the separately and usually fairly well maintained > > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > > > Or you just send the next pile and we'll see. > > > > Also I guess I can't really interest you in commit rights so this > > patch bombs get off my back again? :-) > > > > What does that mean? Merge my own patches? > > Not sure how that works with your group maintenance setup. > > Is it just a `git push`? It's a bunch of scripting and setup, might not be worth it for just one of. Plus we still take pull requests from submaintainers so it's all just if you feel like it. Some docs if you're curious: https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html Cheers, Daniel
Daniel, For some reason, you're not appearing in the recipents list when I reply to all. You're not in the Mail-Followup-To header. Any idea why this might be? Anyway, please see below: On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Fri, Nov 13, 2020 at 10:01:57PM +0000, Lee Jones wrote: > > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > >> > > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > > >> > Hi Lee, > > > >> > > > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > >> > > The precedent has already been set by other macros in the same file. > > > >> > > > > > >> > > Fixes the following W=1 kernel build warning(s): > > > >> > > > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > > > set but not used [-Wunused-but-set-variable] > > > >> > > 55 | struct drm_crtc *crtc; > > > >> > > | ^~~~ > > > >> > > > > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > >> > > Cc: Maxime Ripard <mripard@kernel.org> > > > >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > >> > > Cc: David Airlie <airlied@linux.ie> > > > >> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > >> > > Cc: Rob Clark <robdclark@gmail.com> > > > >> > > Cc: dri-devel@lists.freedesktop.org > > > >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > >> > > > > >> > Also applied to drm-misc-next. > > > >> > This was the last patch from this batch I will process. > > > >> > The others are left for the maintainers to pick up. > > > >> > > > >> btw for patches that maintainers don't pick up, the usual process is > > > that > > > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > > > of > > > >> patches, too much for me to keep track, so please just ping me with a > > > >> resend for those that expired and I'll go through and pick them all up. > > > > > > > > > > > > That's great Daniel. Thanks for your support. > > > > > > > > I can do one better than that. > > > > > > > > Would a pull-request suit you? > > > > > > We have a few trees going on, and your patches are landing through all > > > kinds of them. So this might be more coordination pain. If you can > > > exclude patches for the separately and usually fairly well maintained > > > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > > > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > > > > > Or you just send the next pile and we'll see. > > > > > > Also I guess I can't really interest you in commit rights so this > > > patch bombs get off my back again? :-) > > > > > > > What does that mean? Merge my own patches? > > > > Not sure how that works with your group maintenance setup. > > > > Is it just a `git push`? > > It's a bunch of scripting and setup, might not be worth it for just one > of. Plus we still take pull requests from submaintainers so it's all just > if you feel like it. Some docs if you're curious: > > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html As *fun* as that looks, I think I'll give it a miss, thanks. :) So for the final merge of the non-Radeon set [0] to date (Alex just pulled in all of the outstanding Radeon patches), we have a few options: 1. Take them directly from the most recent set [0] 2. I can rebase and resubmit again in a few days 3. I can submit a PR Whatever works for you. [0] "[PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon)"
On Tue, Nov 17, 2020 at 10:34:04AM +0000, Lee Jones wrote: > Daniel, > > For some reason, you're not appearing in the recipents list when I > reply to all. You're not in the Mail-Followup-To header. Any idea > why this might be? No idea either, could be my mutt not setting the reply headers like it should. I'm generally confused with how email works ... > > Anyway, please see below: > > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > On Fri, Nov 13, 2020 at 10:01:57PM +0000, Lee Jones wrote: > > > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > > > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > > >> > > > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > > > >> > Hi Lee, > > > > >> > > > > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > > >> > > The precedent has already been set by other macros in the same file. > > > > >> > > > > > > >> > > Fixes the following W=1 kernel build warning(s): > > > > >> > > > > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > > > > set but not used [-Wunused-but-set-variable] > > > > >> > > 55 | struct drm_crtc *crtc; > > > > >> > > | ^~~~ > > > > >> > > > > > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > >> > > Cc: Maxime Ripard <mripard@kernel.org> > > > > >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > > >> > > Cc: David Airlie <airlied@linux.ie> > > > > >> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > > >> > > Cc: Rob Clark <robdclark@gmail.com> > > > > >> > > Cc: dri-devel@lists.freedesktop.org > > > > >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > >> > > > > > >> > Also applied to drm-misc-next. > > > > >> > This was the last patch from this batch I will process. > > > > >> > The others are left for the maintainers to pick up. > > > > >> > > > > >> btw for patches that maintainers don't pick up, the usual process is > > > > that > > > > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > > > > of > > > > >> patches, too much for me to keep track, so please just ping me with a > > > > >> resend for those that expired and I'll go through and pick them all up. > > > > > > > > > > > > > > > That's great Daniel. Thanks for your support. > > > > > > > > > > I can do one better than that. > > > > > > > > > > Would a pull-request suit you? > > > > > > > > We have a few trees going on, and your patches are landing through all > > > > kinds of them. So this might be more coordination pain. If you can > > > > exclude patches for the separately and usually fairly well maintained > > > > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > > > > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > > > > > > > Or you just send the next pile and we'll see. > > > > > > > > Also I guess I can't really interest you in commit rights so this > > > > patch bombs get off my back again? :-) > > > > > > > > > > What does that mean? Merge my own patches? > > > > > > Not sure how that works with your group maintenance setup. > > > > > > Is it just a `git push`? > > > > It's a bunch of scripting and setup, might not be worth it for just one > > of. Plus we still take pull requests from submaintainers so it's all just > > if you feel like it. Some docs if you're curious: > > > > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html > > As *fun* as that looks, I think I'll give it a miss, thanks. :) > > So for the final merge of the non-Radeon set [0] to date (Alex just > pulled in all of the outstanding Radeon patches), we have a few > options: > > 1. Take them directly from the most recent set [0] > 2. I can rebase and resubmit again in a few days > 3. I can submit a PR > > Whatever works for you. > > [0] "[PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon)" I planned to go through that today and apply it all. Wanted to ping a few maintainers first whether they pick anything up, but aside from Alex they're non-committal so I think I just vacuum them all up so it's done. -Daniel
On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Tue, Nov 17, 2020 at 10:34:04AM +0000, Lee Jones wrote: > > Daniel, > > > > For some reason, you're not appearing in the recipents list when I > > reply to all. You're not in the Mail-Followup-To header. Any idea > > why this might be? > > No idea either, could be my mutt not setting the reply headers like it > should. I'm generally confused with how email works ... Yes, email is a mystery! > > Anyway, please see below: > > > > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > > On Fri, Nov 13, 2020 at 10:01:57PM +0000, Lee Jones wrote: > > > > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > > > > > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel@ffwll.ch> wrote: > > > > > >> > > > > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > > > > >> > Hi Lee, > > > > > >> > > > > > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > > > >> > > The precedent has already been set by other macros in the same file. > > > > > >> > > > > > > > >> > > Fixes the following W=1 kernel build warning(s): > > > > > >> > > > > > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > > > > > set but not used [-Wunused-but-set-variable] > > > > > >> > > 55 | struct drm_crtc *crtc; > > > > > >> > > | ^~~~ > > > > > >> > > > > > > > >> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > > >> > > Cc: Maxime Ripard <mripard@kernel.org> > > > > > >> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > > > >> > > Cc: David Airlie <airlied@linux.ie> > > > > > >> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > > > >> > > Cc: Rob Clark <robdclark@gmail.com> > > > > > >> > > Cc: dri-devel@lists.freedesktop.org > > > > > >> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > > >> > > > > > > >> > Also applied to drm-misc-next. > > > > > >> > This was the last patch from this batch I will process. > > > > > >> > The others are left for the maintainers to pick up. > > > > > >> > > > > > >> btw for patches that maintainers don't pick up, the usual process is > > > > > that > > > > > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > > > > > of > > > > > >> patches, too much for me to keep track, so please just ping me with a > > > > > >> resend for those that expired and I'll go through and pick them all up. > > > > > > > > > > > > > > > > > > That's great Daniel. Thanks for your support. > > > > > > > > > > > > I can do one better than that. > > > > > > > > > > > > Would a pull-request suit you? > > > > > > > > > > We have a few trees going on, and your patches are landing through all > > > > > kinds of them. So this might be more coordination pain. If you can > > > > > exclude patches for the separately and usually fairly well maintained > > > > > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > > > > > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > > > > > > > > > Or you just send the next pile and we'll see. > > > > > > > > > > Also I guess I can't really interest you in commit rights so this > > > > > patch bombs get off my back again? :-) > > > > > > > > > > > > > What does that mean? Merge my own patches? > > > > > > > > Not sure how that works with your group maintenance setup. > > > > > > > > Is it just a `git push`? > > > > > > It's a bunch of scripting and setup, might not be worth it for just one > > > of. Plus we still take pull requests from submaintainers so it's all just > > > if you feel like it. Some docs if you're curious: > > > > > > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html > > > > As *fun* as that looks, I think I'll give it a miss, thanks. :) > > > > So for the final merge of the non-Radeon set [0] to date (Alex just > > pulled in all of the outstanding Radeon patches), we have a few > > options: > > > > 1. Take them directly from the most recent set [0] > > 2. I can rebase and resubmit again in a few days > > 3. I can submit a PR > > > > Whatever works for you. > > > > [0] "[PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon)" > > I planned to go through that today and apply it all. Wanted to ping a few > maintainers first whether they pick anything up, but aside from Alex > they're non-committal so I think I just vacuum them all up so it's done. Okay, perfect. Thanks a bunch.
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 413fd0ca56a8f..dc5e0fbecc04e 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -802,6 +802,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->crtcs[__i].ptr && \ ((crtc) = (__state)->crtcs[__i].ptr, \ + (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ (old_crtc_state) = (__state)->crtcs[__i].old_state, 1)) /**
The precedent has already been set by other macros in the same file. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] 55 | struct drm_crtc *crtc; | ^~~~ Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Rob Clark <robdclark@gmail.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- include/drm/drm_atomic.h | 1 + 1 file changed, 1 insertion(+)