From patchwork Tue Nov 10 19:30:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 322868 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp500519ils; Tue, 10 Nov 2020 11:31:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBsWU1Z9p/8LwS06rpoX80RDaVOzAaogL+/Bh9Ha67ovwvMBkuH9w4zP1uZQTeYfF2UQd0 X-Received: by 2002:a63:1a54:: with SMTP id a20mr18491908pgm.133.1605036713169; Tue, 10 Nov 2020 11:31:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605036713; cv=none; d=google.com; s=arc-20160816; b=D4LbDGKnsH7T8nlJY1UwH7mL37My420pL8e6DUuSfb6RLciMoMSHyAYtZwGb9YR8+z AyjVMhd2sfJH/b6gyPJG2fLIbeFzG/UXqDLSo7NNedh6NIZRwuVBOT8SaSePMFlroCzL ressIr8wln7Ik6zZJ61ItIWjG7plGSRljXFxuBPl7W6Wx2sU+rh87YhwYiCz/fiwuXDX JHraxtgAOj5zZd2q2paE4wgjy4WPH08QENoQ/1ZkHOiVwrXJL6+X6EFZo59Nv1PFEO9J nhxTwbeB2gAxrQWJH+OGaA34EJghdZkjI6cqBjzB1orWqK+knRM1s4EjFtY7+7UjfOKp ZK2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=luZrSY0qyWZNvaafjCAPA9s/uM97smb9YVSxB4RJD8w=; b=Ee5iOK3upC0O/T/x4wreZCArQT6r0sDG+c0Ewgxw2Ia1PNdRoUvfhjLqYfxP4MdIij EjLockft0GaL7ftpKoR1BTvgHPZfPPZMbNcyS+/iMyzNLLxpH2EAD2qFMWrRL/MrR3y1 bhKOpc5Z+qwVHPisXOy6aDIPJP2hl6G1VYXQBOLUL0+qLCLjlXPVv0cUU6O8JuGD0c2z 5ABekx1v3YiSTHM2uOWBp9dlgsJK+jU8e2UCl/RX7iSJBT60kaS3vdSbcyYC1U3apW9r mxp3igtZQ+uKnzGx4Uk9TOhWEH+8b2r+4gsLNE+io4XndxU07i52qVLBxmRQ8LUiGBVH 9NXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bWEncwk9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id d3si10838590pld.76.2020.11.10.11.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 11:31:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bWEncwk9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 740A289BF1; Tue, 10 Nov 2020 19:31:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12AD889BF1 for ; Tue, 10 Nov 2020 19:31:39 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id p22so4336607wmg.3 for ; Tue, 10 Nov 2020 11:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sa4D9H3FopQ6FC9s62hXq/PcYKcafVSvMGNnPWttN0U=; b=bWEncwk9wr4hyGIAHgAfJ00TYqT033OOA+eahgRfxnsKrAZROWgGzK4sd1MmNS9oQh GvbtKa1pabul6vB72nEB1Z1XQjiEisZrnaYbvtUmksKjCeYfi3PX/VozLIBlVh4xq6UI +YjwyRORt6ZobT8cOQMaNz2JFglA/Ejzl9c68LomGj22IFWO/4Db/1SoszfAvaTa87qB oPBDIHnaFCRn1+y7xopvEOrQtiLc1NK2o6q5Dh8Q2zED+IdMw8r0K2GXUvtuDWRQl7kQ QYxR62UwnGQu9x4IsWiQgF9YKl27S1i+BEnsEIBco+s4+ATFiC8qmjqgffHlEHjAGSCc nrQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sa4D9H3FopQ6FC9s62hXq/PcYKcafVSvMGNnPWttN0U=; b=RouIy+hk0q4ScI3FBQuzHRJn/lJ2wMv67KBFCZjAhIBVzN0SCttKO6SCHJ+IBq/mVE 6vCSgWOezavMhQqVghhIG2VLCWJJf0BrI0hqFygSRk4FGGaUqqbB6ZvytOqTrQfeR+K/ E4rj9DcRIAWp4wDR8PtVAvseE6Sv5biLxNdMzeV5Z69k6+8U/Eco0eirOU4QzPFdnsRH e7DUtuJzH0xVHJfmaj/gMzHTCZ6faamLaAZ4a1NG4nZFelo6nwbLfgHLF9QdSwQY5zIh hve60H1fve/4r0n0RTxzSEXfbcLEVz5RdCD+kkj7/Jp5cMJUyDL2IQYPRzi/ykbaovi+ 4ORw== X-Gm-Message-State: AOAM530JK6TN5twEJgIb4duQkTiECzNScbWHiqZA0/kVOlNCpCgBdLjU asKKTS6lXXsMeoo5Ik8XXyUDBg== X-Received: by 2002:a1c:3803:: with SMTP id f3mr754555wma.14.1605036697717; Tue, 10 Nov 2020 11:31:37 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 30sm17635335wrs.84.2020.11.10.11.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 11:31:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/30] drm/radeon/r600_cs: Fix some doc-rot and supply missing function param docs Date: Tue, 10 Nov 2020 19:30:59 +0000 Message-Id: <20201110193112.988999-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201110193112.988999-1-lee.jones@linaro.org> References: <20201110193112.988999-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600_cs.c:793: warning: Function parameter or member 'p' not described in 'r600_cs_packet_parse_vline' drivers/gpu/drm/radeon/r600_cs.c:793: warning: Excess function parameter 'parser' description in 'r600_cs_packet_parse_vline' drivers/gpu/drm/radeon/r600_cs.c:826: warning: Function parameter or member 'p' not described in 'r600_cs_common_vline_parse' drivers/gpu/drm/radeon/r600_cs.c:826: warning: Excess function parameter 'parser' description in 'r600_cs_common_vline_parse' drivers/gpu/drm/radeon/r600_cs.c:968: warning: Function parameter or member 'p' not described in 'r600_cs_check_reg' drivers/gpu/drm/radeon/r600_cs.c:968: warning: Excess function parameter 'parser' description in 'r600_cs_check_reg' drivers/gpu/drm/radeon/r600_cs.c:1473: warning: Function parameter or member 'base_offset' not described in 'r600_check_texture_resource' drivers/gpu/drm/radeon/r600_cs.c:1473: warning: Function parameter or member 'mip_offset' not described in 'r600_check_texture_resource' drivers/gpu/drm/radeon/r600_cs.c:1473: warning: Function parameter or member 'tiling_flags' not described in 'r600_check_texture_resource' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/r600_cs.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 390a9621604ae..f20b619466816 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -782,7 +782,7 @@ static int r600_cs_track_check(struct radeon_cs_parser *p) /** * r600_cs_packet_parse_vline() - parse userspace VLINE packet - * @parser: parser structure holding parsing context. + * @p: parser structure holding parsing context. * * This is an R600-specific function for parsing VLINE packets. * Real work is done by r600_cs_common_vline_parse function. @@ -801,7 +801,7 @@ static int r600_cs_packet_parse_vline(struct radeon_cs_parser *p) /** * r600_cs_common_vline_parse() - common vline parser - * @parser: parser structure holding parsing context. + * @p: parser structure holding parsing context. * @vline_start_end: table of vline_start_end registers * @vline_status: table of vline_status registers * @@ -956,7 +956,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p, /** * r600_cs_check_reg() - check if register is authorized or not - * @parser: parser structure holding parsing context + * @p: parser structure holding parsing context * @reg: register we are testing * @idx: index into the cs buffer * @@ -1460,6 +1460,9 @@ static void r600_texture_size(unsigned nfaces, unsigned blevel, unsigned llevel, * @idx: index into the cs buffer * @texture: texture's bo structure * @mipmap: mipmap's bo structure + * @base_offset: base offset (used for error checking) + * @mip_offset: mip offset (used for error checking) + * @tiling_flags: tiling flags * * This function will check that the resource has valid field and that * the texture and mipmap bo object are big enough to cover this resource.