From patchwork Mon Nov 9 21:18:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320993 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000600ejb; Mon, 9 Nov 2020 13:19:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzX36aqYaXOz5KIku8aFdbzVQlIv5aQH2SYqAAelH0pGNUJo/xciqa9wF1FYhzKVhQGokkT X-Received: by 2002:a17:90a:4b45:: with SMTP id o5mr1068079pjl.223.1604956789605; Mon, 09 Nov 2020 13:19:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956789; cv=none; d=google.com; s=arc-20160816; b=bZ2EVEekiIXuu/aYhoy80ne73HEJar6uanB6MSS0DkbTXYJjwgEkO9biUdid+oY6xF 4KlE+AxtAS563ozs7EDVwBUYphf2m3neBkWJVrS61h5YeBBfPCdGdy2R1jZ21MvFrEto G9EWKSzh47Yw1nc2IS6romPLiXXrTNEpYGCJ+IEY7JPPqR8RYeQYgevBmCX69QFiyS2B OB1SiSqp1i8iGa/1H3EtFuALwPkrE3vXBG1Le0L/B2Gotmfw//LxFl3/Si0FBZxpcUri hXxXTFOOc/a0bfDlRGqGW6ntNM2MXWSljiifVuijGjisPgox07lYK3rmKG49K+FcT1D4 ihOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=29I0xXPMvn3UiGgUxWfPCoYNEuyFptPKbeWA7nfKhP8=; b=fHMPTtt097KBibY6MXUczcWqFwTw4We3CAY2xZ+XvNPf9glqdp/U1wP3XyXP5zy1wF 7m2oKZJak8GatrAbJZaA6OSya55h2zRMm0AbEpoZXwACPDHf31J0+EXPVTrWcabW4m1P QWRPyT9RQOvqAV1fzl2DFQuK6Uatuj5BQlOelIKyxEa2uyVBTd3FS+5FoLYa02DYv6xT zRftUtdcnyEWl0nn1smzm4vaL7k8h6YGEWlmUbxwZwumm0yTMXVrOUElcpGbf2fWepcw J0ongxOzmvCC9WgW4C5Xgi2HHWJZax0+P6wF6Akx5rhK24N8ujrqBaBuHD8PWXcF6KJ1 OgiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yLNFiHYO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id l13si10777845pgq.112.2020.11.09.13.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yLNFiHYO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FFF989617; Mon, 9 Nov 2020 21:19:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id C019389650 for ; Mon, 9 Nov 2020 21:19:45 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h62so912418wme.3 for ; Mon, 09 Nov 2020 13:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GKEWaGJB8BfGR6ufuyFa6sc9ZYlzJUyj0WhtwnEg+YM=; b=yLNFiHYOOshoi44YOcHvCJLLEepPoEefGQL1ft/wS6fsl9FUBhQHLyJ4M4k86v5zCs 5J5RdBCbgV+7LI5avSvNm9OU0JAbs9DADt00zEd2Ba9Mz4hOjuJn9JFWKURi/7bvIdt1 xb7UopKkEa8/tRNspkGKQ2Is28Vu5W9N0IieG7NbyaI9fH8PExpFz/fdSK6TKix+0Iwb ygndmQg6/vzQvngoclWGooLS0vCOPnLUQucMoGcBAlNeUndHdyfFCWizDCiYwZPTvMDI ljKm8/NevMLVASgfqYYYm+5j3vYRMHMEMecOkwxAWvBCEZ2lR1U8SOBYI06Q/nz3j6NV BOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GKEWaGJB8BfGR6ufuyFa6sc9ZYlzJUyj0WhtwnEg+YM=; b=hooy5BfcorKjSTFupn7xpWs6X+IdN2jI+Q0QMPFhWp0zJFL+fIGnKXqEi2bKu5NP9K Depbjl8oJ5ZH23GiEpZEX9W+KbSK2EtGRk+2CL6kbvexGT2nLjdYCcVTWSTdz1PrkIjU DiTniDNkEu1w4HatWBuxDVJUKPQvfrn5B+e97DxG0H+ni3jVDVhU+2yFPrFvhoCZpC07 pDSX7cz3JsRXRwQ+4/sPxQJlZ1W7yTP1F/W6366V0ysjRUoFNaqGMZQlZ82ZiDeV3rFP pMThKiECO43CvXrOl9ynUTROY9glsr2iAnA7hvwC+PIqxRAOJn58wq0Cm779j1PuY55q 2/gQ== X-Gm-Message-State: AOAM5329LphefTyUM9pdtATV0D7/2gDMf/Nof4A1tdN0k4TNneueElpN L0hImKl+xE08H89nOxbiB1ikjA== X-Received: by 2002:a1c:2ece:: with SMTP id u197mr1180731wmu.58.1604956784455; Mon, 09 Nov 2020 13:19:44 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues Date: Mon, 9 Nov 2020 21:18:53 +0000 Message-Id: <20201109211855.3340030-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , report to , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or member '__work' not described in 'radeon_unpin_work_func' drivers/gpu/drm/radeon/radeon_display.c:406: warning: Function parameter or member '__work' not described in 'radeon_flip_work_func' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'freq' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'fb_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'frac_fb_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'ref_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'post_div_p' not described in 'radeon_compute_pll_avivo' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: report to Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_display.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 78fceedfd9255..eb0d4cb95f0a6 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -256,7 +256,7 @@ static void radeon_crtc_destroy(struct drm_crtc *crtc) /** * radeon_unpin_work_func - unpin old buffer object * - * @__work - kernel work item + * @__work: kernel work item * * Unpin the old frame buffer object outside of the interrupt handler */ @@ -398,7 +398,7 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id) /** * radeon_flip_work_func - page flip framebuffer * - * @work - kernel work item + * @__work: kernel work item * * Wait for the buffer object to become idle and do the actual page flip */ @@ -937,11 +937,12 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div, * radeon_compute_pll_avivo - compute PLL paramaters * * @pll: information about the PLL + * @freq: target frequency * @dot_clock_p: resulting pixel clock - * fb_div_p: resulting feedback divider - * frac_fb_div_p: fractional part of the feedback divider - * ref_div_p: resulting reference divider - * post_div_p: resulting reference divider + * @fb_div_p: resulting feedback divider + * @frac_fb_div_p: fractional part of the feedback divider + * @ref_div_p: resulting reference divider + * @post_div_p: resulting reference divider * * Try to calculate the PLL parameters to generate the given frequency: * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div)