From patchwork Fri Nov 6 21:49:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320847 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657085ilc; Fri, 6 Nov 2020 13:50:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWSp4qBPmB1WcWX598zqjqWwXWnKLb3FWNPHrGeNboSuH7b5iuXqALBSL4cU3DcoFIZU80 X-Received: by 2002:aa7:9699:0:b029:18a:e057:c44 with SMTP id f25-20020aa796990000b029018ae0570c44mr3862743pfk.34.1604699415609; Fri, 06 Nov 2020 13:50:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699415; cv=none; d=google.com; s=arc-20160816; b=enpp6mNY1cZI71d6F/OHj2PTb9LFgloB1exJNvR5MMCmxeIk9L3aAvRdF30ayhXOBR kY6AY6MnMBdhjnWBeXhY5vsc2/3qn25tSon9FLaFwUNhrwHg2Qcg6s2tLVMVJiUAquFS SIdhsFJHbDxXLjlMHXqae/JWXp4PQPcy/2M/IhLcBFJMo5owyKPuuIHtkR6MrWZg9yUi PDE2fKe9gg6pPYaKlwgDoKgUTDBUmJJYphUF7rA+i9kzT2VlBgSzlHgCl760juat3JSf A/QgfozPUrlMQHdvdvO0QNGSPktOxa6At1cy65MKrunISj28Quam/CJiCO3OYrWBQwyZ GL/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=cjbq+/QTHPgHQ0z9xozke2lIFXtPHOtAYjuPmlOWABc=; b=RWWVhw5/JwZEMwPzyCrI2j7jaq6vN67XVsZdYi4a5wyGUQGRj1Imp/XBRCHsRDCE3o xrxUGIXhb4QDeqwG1fsj2yyZbCqwMv2mTCChqu9NKoDgVTYMAfkN44fj5/U6gF8y0Rlv LLcuj89x4/kA/X/dKxZYWc5KNfXi9Bv8JtRUOJ5FJeyB0DGET2j/aoYWXxEkAZgT1gXr Mo/2cTqq1OZozRmtXWWmqoZ3niRhmgGBWvO4zQ6BWbcY2GWQnMkVdgwKldgF5HRVlYq8 83E5/N3YKckYbH1qtRZ/9p2taJN8JOYpXoNsHGaD8/pnbxcQqlZIZBZ3KHQTuKHB1Fdu U9pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cVJbpGO0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t23si2146500pfc.114.2020.11.06.13.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cVJbpGO0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 460246EB28; Fri, 6 Nov 2020 21:50:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EC476EB26 for ; Fri, 6 Nov 2020 21:50:02 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id 23so1771628wmg.1 for ; Fri, 06 Nov 2020 13:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E44zAySPmawq+qLbsH9q5xt7WGcYQXLEVwBfYO570wQ=; b=cVJbpGO0mn9PFOK6wV3RI1ztFhosLDnGLAYO4ev3T9QpIRZ2SSqsEx8FWEUkN+upm/ HS8YHS57ONCD2IVwBKqTIIoyLLrbNFPelDe5IxCJ8PGsFiXgXqe7cLhkoTUrAoHixgZo KDP2patea7yG8pSvObvQ56FR4KjPr651sE8b30YFsZQO1CI2rUBjP+Jg9kQsXCsrIiYl kvdHKnkUFuKAF51usqRPb3FB+WAkJ3NKop0XNHNG/HonC/IukIGGjt2gWOzW3Yk3+aB6 L0qwyZria23XEQBZ4ZV4Z9dI8tXdlsT47zwq42PF50XnSulcKL9WAjNKbSUvqekGHt4W z3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E44zAySPmawq+qLbsH9q5xt7WGcYQXLEVwBfYO570wQ=; b=KN0FW05AbOlpfLoERBS7fkcI1Iwl5x3PV1wfDH+E06mIebyg/NSMIMRVVsqAcVr9Qd WGkFbFW+bNoWgnv4pmI67FlK39FgwDPTZhLFqWZ5hwj7Gjm00o2UC0TlVVYywpuC9N9d prFE96VuPaTCe6FJJ45TqkRVrjcLSWV6qLHUe6bXJWhRi8OI+YXAd794wp8kQcVLSq0n 2hhPz4hHPW0wI1OFLwAHjbuGWBcLphq34WWl9tCTFZEki8ANpRMfny/Dyt2kRSoHykiH 5j40Yn4h6nStjpPGOBbH5VslvrrlkNLU88Cwhwvqeq/Yueu2sGLOukqvXycHDTi40FDg wd0A== X-Gm-Message-State: AOAM532wtnZqfLCgwI+CZCqMJ6gnENPPnQ2NrNt8d7V36v65Rno96gGv 8ESaimnQNs18QzfEe72XQ3LNow== X-Received: by 2002:a1c:ba0b:: with SMTP id k11mr1557572wmf.37.1604699401085; Fri, 06 Nov 2020 13:50:01 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/19] drm/radeon/atom: Move prototype into shared location Date: Fri, 6 Nov 2020 21:49:36 +0000 Message-Id: <20201106214949.2042120-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Both source files include atom.h, which seems like a reasonable location to place an atom based function into. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/atom.h | 6 ++++++ drivers/gpu/drm/radeon/atombios_encoders.c | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.h b/drivers/gpu/drm/radeon/atom.h index 1bf06c91cd959..cb93b83114dbe 100644 --- a/drivers/gpu/drm/radeon/atom.h +++ b/drivers/gpu/drm/radeon/atom.h @@ -154,6 +154,12 @@ bool atom_parse_data_header(struct atom_context *ctx, int index, uint16_t *size, bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t *frev, uint8_t *crev); int atom_allocate_fb_scratch(struct atom_context *ctx); + +struct drm_display_mode; +struct radeon_device; +bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, + struct drm_display_mode *mode); + #include "atom-types.h" #include "atombios.h" #include "ObjectID.h" diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index cc5ee1b3af84f..85f903caf12e1 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -296,10 +296,6 @@ static void radeon_atom_backlight_exit(struct radeon_encoder *encoder) #endif -/* evil but including atombios.h is much worse */ -bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, - struct drm_display_mode *mode); - static bool radeon_atom_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode)