From patchwork Tue May 28 08:27:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 165248 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp8168878ili; Tue, 28 May 2019 01:28:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzW2CvCQ5Q5kAJqqX7qP8egFPzVHGznwdtPkiU3Q9R+p1T559CfriJVpsVwzw6R6sL+xPvG X-Received: by 2002:a17:902:d896:: with SMTP id b22mr120604957plz.40.1559032113718; Tue, 28 May 2019 01:28:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559032113; cv=none; d=google.com; s=arc-20160816; b=Vbe5zXGU+3wivpNOymmnA301z5FN7JB10+G9WShv6AxWmgmZ4kEqQ1gdTNL+3ugwgM f3RdramMOCK4zD1hEdIjD6gMre6xnS6cxf+VEtPwuspVM2zPog2wK6LSaitFbNx/XI5D WvI3ccVopLAPC/C3mXfgJTlddNPMKXJzHclSWbN1e/QLZ9zoyk81YUtjzFN4N9Dyi+DB x19RQfAX4YnlciTnDPYgDbfdaT/RzUse+Lb4Ou41WSeA/dBTUpP9XIXlJnuyeVkhBEYa oKhCfrdXEyqnR3Ez7C/nyzDhJkHysMq3Z2sbY/onNPVU/SQweZDcuYfo9UKaMpRkdvz9 36Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=hI4pkPk+Fy6cb+Db4DGkgTT7XGBZcjlxBgAyehvy0tA=; b=YqgWWI70IPs9k7dzpY8aaiYZ3qsx7cWWsrpd8w8SyrBc7AoWFZrajSPt7nTuewDUBA rnwcr6gWUBXAU/ek1co5jxB4rT8dl3Z8DeYi+fyjMTcW1fVS6QOSiaqEJ32QOteNn5qH F9EoPx1pVmum3bbv8LdnBLSYHlAdHH8Z5hH2ObhGbhsIkvhapUpV7dxFW5hN8DOtmCnV AodAYvygTkRAEt0lmdwewo6C7MYOXwlZ7jeQgQFTHkH1xcQiYa0DlWH9hJhbcVy+/MpB q7ZILC940oMDUrI3XvgGy7L+h1vvl8RanP2tdM9ev+MX3oQCW9pz1xTnHJUqIPQnTawb v1XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d5si22405221pla.376.2019.05.28.01.28.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 01:28:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0ABC689C9A; Tue, 28 May 2019 08:28:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DC3289C93 for ; Tue, 28 May 2019 08:28:21 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x4S8SH2S036580; Tue, 28 May 2019 03:28:17 -0500 Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x4S8SHCJ114654 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 May 2019 03:28:17 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 28 May 2019 03:28:17 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 28 May 2019 03:28:17 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x4S8Rxua125039; Tue, 28 May 2019 03:28:14 -0500 From: Tomi Valkeinen To: , Andrzej Hajda , Laurent Pinchart , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Peter Ujfalusi , Jyri Sarha , Benoit Parrot Subject: [PATCHv4 06/24] drm/bridge: tc358767: cleanup aux_link_setup Date: Tue, 28 May 2019 11:27:29 +0300 Message-ID: <20190528082747.3631-7-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190528082747.3631-1-tomi.valkeinen@ti.com> References: <20190528082747.3631-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1559032097; bh=JA81L4DZF+VT1/si/AaH2gVLTQtIvC+v133rQ78YOJI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ymcvbDnYJt3AOdKyl1PlSX/VWic7R7XV3ES5aYld1EtyriJv6q9rchSQq29tfNYrN 2pdEHeWG73FvGKHzzFY6B1cq4vSkmSQ0l/6Gu1lxgOSwm24NWoq4FFZ2atdvyl0ysV IPlKo1qQsuSQZ0HiTx6qGk0DG/e4W3mJKLXtojeE= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver sets up AUX link at probe time, but, for some reason, also sets the main link's number of lanes using tc->link.base.num_lanes. This is not needed nor correct, as the number of lanes has not been decided yet. The number of lanes will be set later during main link setup. Modify aux_link_setup so that it does not use tc->link, and thus makes aux setup independent of the link probing. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/tc358767.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 119cd8d14d4b..39a9de880e5a 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -542,7 +542,6 @@ static int tc_aux_link_setup(struct tc_data *tc) unsigned long rate; u32 value; int ret; - u32 dp_phy_ctrl; rate = clk_get_rate(tc->refclk); switch (rate) { @@ -567,10 +566,7 @@ static int tc_aux_link_setup(struct tc_data *tc) value |= SYSCLK_SEL_LSCLK | LSCLK_DIV_2; tc_write(SYS_PLLPARAM, value); - dp_phy_ctrl = BGREN | PWR_SW_EN | PHY_A0_EN; - if (tc->link.base.num_lanes == 2) - dp_phy_ctrl |= PHY_2LANE; - tc_write(DP_PHY_CTRL, dp_phy_ctrl); + tc_write(DP_PHY_CTRL, BGREN | PWR_SW_EN | PHY_A0_EN); /* * Initially PLLs are in bypass. Force PLL parameter update, @@ -587,8 +583,9 @@ static int tc_aux_link_setup(struct tc_data *tc) if (ret == -ETIMEDOUT) { dev_err(tc->dev, "Timeout waiting for PHY to become ready"); return ret; - } else if (ret) + } else if (ret) { goto err; + } /* Setup AUX link */ tc_write(DP0_AUXCFG1, AUX_RX_FILTER_EN |