From patchwork Tue Mar 26 10:31:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 161186 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp5038823jan; Tue, 26 Mar 2019 03:33:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyE2XTIQ92+ZqsHZH+5eCwtHzqtTPnMJhDe+n8rhgboFLZSnu4geswYe0cgDgoRS8BjVjyG X-Received: by 2002:a17:902:a506:: with SMTP id s6mr5711444plq.164.1553596383425; Tue, 26 Mar 2019 03:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553596383; cv=none; d=google.com; s=arc-20160816; b=U35APGjeFC07PYX6hb54Ekop1J2qZsBy1/ACgypHBfOYeHGGm5fFOG/NZqM63GnnKb C1Fi63D8VPS5FfOIafxVHUmbQfrysQTV49r57aypxCFgTusGz28ZkT2HrAzTd0hXyDuL 63jqLnMP5KCBXgG42CqLG8QqLgzdUt2IYdEp1NWCAfhDI0BsJ1C7JEjACmy+uY8pAwQY U37dyuNIzvr7L5qW2P84DBi8VoPoz+f7KdOUDHj3J/G8veIF/dhvq1YMOcL1p5JQcuns n+o7C7/kNOPhMoU+yMuZ9SQWNsf9KFK7BGZUj7AK39sQh1T+EigojHiA4DiRLjSTZjUr i2SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=oxLG4f6oU4QzEV5RDQPm55Yv2hoT2k3oCd8ZRAax/Co=; b=fGErB0sT2RbSaDjfgkL8xum2rCSW+IvgYghCUReHkZuU2LGLCjeYvjSJCLOhrgrxu7 xN0zRmgS4/BuPAndTG5vq9yK5iJw1ehzXeJW7+JOSv1oEKOGNyFDEv9Xl14Ei2XZ9Xpm KonoBLnJq807E6umXTaNbKYVAs9sRWB/HNjuKHlhKkOHShXEPEjwsiD3hcSgEABNtVTW /FMUHP02wtOq3bRp8btzdDp2kHBrz55YmtnkGkT7XfOHi4Jr78AZCER6w/Ut4YQHP238 30cXfyU0K1VpIbwdM/OUjsWavmmsjlLMFjCqpu8vKTNGtPQhuPshRigMW3IMFz4vpgaw GxpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 1si17449629plw.390.2019.03.26.03.33.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 03:33:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 132C86E7E8; Tue, 26 Mar 2019 10:33:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98F0F6E7E7 for ; Tue, 26 Mar 2019 10:32:58 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2QAWt6q043834; Tue, 26 Mar 2019 05:32:55 -0500 Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2QAWt5t044563 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Mar 2019 05:32:55 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 26 Mar 2019 05:32:55 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 26 Mar 2019 05:32:55 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x2QAWN2D071249; Tue, 26 Mar 2019 05:32:52 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Jyri Sarha , Peter Ujfalusi , Benoit Parrot Subject: [PATCHv2 11/22] drm/bridge: tc358767: ensure DP is disabled before LT Date: Tue, 26 Mar 2019 12:31:35 +0200 Message-ID: <20190326103146.24795-12-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190326103146.24795-1-tomi.valkeinen@ti.com> References: <20190326103146.24795-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553596375; bh=G8whvB5XNu5+1oZ0kK0Z1pXv14d/iWkdimHvxEYS8B0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gjMlgjSEinnUdpLgsoP9AU1jVO88D8LCjpRMmRhD3I9zJxpjq7gw6Y2T8yYGj+51J wZvmytOL4Lp6AvTy1Edt8f0B3z14c6rjnQVIU5MMfVAI7y5SAGTx1oUU6fU1UQJGCg SoLlyO+OCYmOjQddBxRVpVQIyPQf1PyIGASqkQlc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Link training will sometimes fail if the DP link is, for some whatever reason, enabled when tc_main_link_enable() is called. Ensure that the DP link is disabled by setting DP0CTL to 0 as the first thing. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index fe5fd7db0247..f628575c9de9 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -839,6 +839,8 @@ static int tc_main_link_enable(struct tc_data *tc) dev_dbg(tc->dev, "link enable\n"); + tc_write(DP0CTL, 0); + tc_write(DP0_SRCCTRL, tc_srcctrl(tc)); /* SSCG and BW27 on DP1 must be set to the same as on DP0 */ tc_write(DP1_SRCCTRL,