From patchwork Tue Mar 19 10:41:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 160551 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp3711917jad; Tue, 19 Mar 2019 03:42:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVYNwxWCaNUWCBQQm88afslpd7uZ459xVFV+CfSPKJdJwftpvC3TkzMm76YawPJP5UDimG X-Received: by 2002:a62:bd17:: with SMTP id a23mr1668411pff.233.1552992162258; Tue, 19 Mar 2019 03:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552992162; cv=none; d=google.com; s=arc-20160816; b=RhQxEv/Sf+NecKDgbXiRianBwcSIpn0NWBnalBOp+9CdjYPhpkLTKw4mI5NzX+NVNo OUkm108WA0VMdw0tXDIsM74+3a8mPa4Ydgz+W/RIwWXZmlxnczQEmRYjoe7KxqGgwBEG Y5K23g3QZogWkiWj7cju4Z9bRvmtXTcJ8nbJkgVoqToCsQf9+S9BGKk5kT2q2Os5+I49 Ulsc4cpSpPvWhWQLOjlSeAzXtoY0G8HlXuYfrvVAwcmqjBCzf4g5IxxK9v0k3KOCRlYF BiyhFGSex1oBLJKv5e0sPK5sfIwhAeUqp7BaxKeWvc+VrCN5guTMYjhbku9bcGbJ4TVL SY6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=J3MNhoRcWU98H5u+ZXxkRqIy6j0S11+ZE49ro/uV5l4=; b=EdcPgsttnreB8muk3Is2LEXUhrIrUJGeVJcykd7wGmoO0XKWpBPjPVY84eE4BoyArl aVItbE8+ZdbvXVg5+O8bS7cw/LlblZrmgjico0A6+wjTJEqlJFvFgm7TUsoif2jILeOD 9QVRjVtHBulwyHLzkx7BZ5gCz+IreayDv34OIndPLNikwgDXgSjgNTd+hrB2NLsOVide zOIJgM52L/9SzQiYXawp4u9GpAjvDhX21UbhgzaJKbygAO8x5NQ0jjEgMvy1MmH9S7M1 qK8/Y98HvDgoDcngJJ5UQsEZ6cb4XDXOM2AjNLfT0SC8tNs1wrhoZK7pt+RYsTHp7vkZ OEMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id v34si1438412pgk.320.2019.03.19.03.42.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 03:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E149589AA7; Tue, 19 Mar 2019 10:42:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FC6989A92 for ; Tue, 19 Mar 2019 10:42:34 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2JAgVYX068526; Tue, 19 Mar 2019 05:42:31 -0500 Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2JAgVav105763 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Mar 2019 05:42:31 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 19 Mar 2019 05:42:30 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Tue, 19 Mar 2019 05:42:29 -0500 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2JAfxlV019091; Tue, 19 Mar 2019 05:42:27 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , , Lucas Stach , Andrey Gusakov , Philipp Zabel , Jyri Sarha , Peter Ujfalusi , Benoit Parrot Subject: [PATCH 12/21] drm/bridge: tc358767: remove unnecessary msleep Date: Tue, 19 Mar 2019 12:41:05 +0200 Message-ID: <20190319104114.12077-13-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190319104114.12077-1-tomi.valkeinen@ti.com> References: <20190319104114.12077-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1552992151; bh=Y/GI5YL+6+n4P6J+MriGtVKz9CfPUrpmszJbyAEyIDk=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=k5rt9RMNSSNwtdskjvmjZN1jSjcJCdAcQkJhh/gbIHsGKfY+kMNfzGGl4+0x9wzKg jHVzOy7TFuTTdapbMes6yuzfQh6tSxdzjmIVmuiFx/1V74KY3syNxePhwLBpN1U8AS P+Iit6BhF8yR16s2vlK8sF0e27KOu8t+LKrQo0g0= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" For some reason the driver has a msleep(100) after writing to DP_PHY_CTRL. Toshiba's documentation doesn't suggest any delay is needed, and I have not seen any issues with the sleep removed. Drop it, as msleep(100) is a rather big one. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index f628575c9de9..2a6c0c0d47a6 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -872,7 +872,6 @@ static int tc_main_link_enable(struct tc_data *tc) if (tc->link.base.num_lanes == 2) dp_phy_ctrl |= PHY_2LANE; tc_write(DP_PHY_CTRL, dp_phy_ctrl); - msleep(100); /* PLL setup */ tc_write(DP0_PLLCTRL, PLLUPDATE | PLLEN);