From patchwork Thu Jan 3 11:59:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154723 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp639839ljp; Thu, 3 Jan 2019 05:09:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN5wZpoIKwDi6cRBTGAZx/uc5t0wTWd01572vfh3FWE97nkBEf6k3vkPKeF92H3uOjaQu6DE X-Received: by 2002:a63:c051:: with SMTP id z17mr16546971pgi.20.1546520965270; Thu, 03 Jan 2019 05:09:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546520965; cv=none; d=google.com; s=arc-20160816; b=Wt/WK2LlNbexoGTUTXPYtiY0EYu4pYa3Njc1lfZ0+iVxf10nlGIYZ8VBVoCnn6mK+k Kd1SKEI/i5RZDzpy3wkJ4mZ93tldVDuTRaTT6DOnDaUTDwBsbeQgpf6zk+xtQxp3evpv t/FNheTY+7N19YkeF3XW9WJD2/VnSlVvmM7ZFyZELLZDYMVO8JgzKcC3RvNTDeKgH125 qgqpihKcbY6Te21FNoyc3nYXl03VWtjsRaGUJ6uhQUs5OARk5k/56E2tDyaMvk8kgCKv 45qu7Ni8nm3F9JlE9AXe2e+trAyWVgb+unXh97feZ/db3sT1IYqHdgDfs1y9AVpSZRlq Accw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=zkLDn16DYy9qb4W7moyRcKPN7XIT41EFCJddXnmPnTk=; b=Dw1y9WZFZS2ABRDg8kzLRtyAJfvkP2GFbfMyD8LDl+BH5z4H3u7Ax6wPaHVQF+0u+o Q5hO23O4mbdb7e958F8zfG3J2hFkd5icBYaXDRb8ZhjCuEjUJo3M0oRQFVMx238E76oy qsVo9CyxkPD5CCGzLlzCQ5IlALIXWOWplN0B6C5IBCSNcXzdfyiwJEFaChUPu9MUvqzh 4AaiX2h6ALkKAV9TEfAcYnC4ABkFmDnKvyyxLkJlsTd1DR0P/P5XcUVH5AhRnmABLPm4 r+2IPT9n4Qrp4fqGyaQxPv5IROiEP0WlHj6Wnph6VBD/srihmc0xipHbtubO/is4QPyu 6Z/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g18si52826149pgg.522.2019.01.03.05.09.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 05:09:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D84DF6E544; Thu, 3 Jan 2019 13:09:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id E49776E544 for ; Thu, 3 Jan 2019 13:09:22 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C0CvL021837; Thu, 3 Jan 2019 06:00:12 -0600 Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C0Cf7029592 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:12 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:10 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:10 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgk001514; Thu, 3 Jan 2019 06:00:09 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 5/7] drm/bridge: tc358767: reject modes which require too much BW Date: Thu, 3 Jan 2019 13:59:52 +0200 Message-ID: <20190103115954.12785-6-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The current driver accepts any videomode with pclk < 154MHz. This is not correct, as with 1 lane and/or 1.62Mbps speed not all videomodes can be supported. Add code to reject modes that require more bandwidth that is available. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index ab299f4debfa..a1f3dd2afbb1 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1114,10 +1114,20 @@ static bool tc_bridge_mode_fixup(struct drm_bridge *bridge, static enum drm_mode_status tc_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { + struct tc_data *tc = connector_to_tc(connector); + u32 req, avail; + u32 bits_per_pixel = 24; + /* DPI interface clock limitation: upto 154 MHz */ if (mode->clock > 154000) return MODE_CLOCK_HIGH; + req = mode->clock * bits_per_pixel / 8; + avail = tc->link.base.num_lanes * tc->link.base.rate; + + if (req > avail) + return MODE_BAD; + return MODE_OK; }