From patchwork Thu Mar 29 10:40:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 132561 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp1577588ljb; Thu, 29 Mar 2018 03:40:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx49w+RbWA9/NzMmD67pf4QciSCtLPy99xuBPPN9o9sOI+V2/ki5qT8z0OzCaQ3SOp+uH3+sG X-Received: by 2002:a17:902:aa86:: with SMTP id d6-v6mr6167103plr.375.1522320048993; Thu, 29 Mar 2018 03:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522320048; cv=none; d=google.com; s=arc-20160816; b=XsJwxZh6WvjxsWxTbuDDXe+qfgMPqI6nAPXFG0gdegutfsClOhBPYXLBPYeOc3WBps tNKjzRA/b7i5540idwphCPb8L06YzRMeyM7eVjZflNxHY3BG217I30raJN5P/B14ZRyy V7KqabnDkFUjrsuB8yRh3I6EKoCC0qnNfuxbKWJVRoZa+Ff/x4Vxa+MGhDtePCke8t10 DdrWQdYqlNaaY7fyuiSzzbqZyQwUNSnrwZKm0C9JGK84taVS/mlogZATJr/Ooq7i4pG/ WZbUgkAeiuorqCKtolfZ5l9yqu3HqYjnMrETRCqrF0C3qX/A98cYg5kIGtMp0QdrkOe4 LlcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=CSX46dT/Iq3dLaqG0OHtkH7AexLTBiqcCU6PbXKDG0U=; b=MGzu/Vm5eD8wyw8CHTXOSh50B6Y/wEv4WDcUNJLKa8cVnG9DBKwJN+pkq+fvH5X3sW ZHjZg0dLMeTDVTbs61nzHAKWyetKVMfh3xDhKyqq1hP9+M/dMHB1vT9ICWovsHsBBdjm Nomgag247iC8v8nMSSWYBJXVjkYkcli+zEtbNpuTG72wTp4RMmKo9F8lbQ2Agz3RkHkX YVE06K3uv4P72B3qMkDobICWgZsn8NeVTH1KijbBHvRRtmedu6EdJLovG+lDy2FTJUJj JQPd4L9k0uPbmM2eUFgk+CEpHWIxvMS+S5RFhlytTrtXpIb/Gd58ONUpaO6aPTfnXlr4 /Hkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=GfgNbFLi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id y11si2348375pfk.380.2018.03.29.03.40.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Mar 2018 03:40:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=GfgNbFLi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 760DD6E6AD; Thu, 29 Mar 2018 10:40:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 582A96E6AD for ; Thu, 29 Mar 2018 10:40:44 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id w2TAegab000860; Thu, 29 Mar 2018 05:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1522320042; bh=fi6QRLniQrJ/7hhfK60ngm+xAXkhLlHii33mGMAfiaM=; h=From:To:CC:Subject:Date; b=GfgNbFLiCfH7ARtIAPKpyfEDq5Z3JcztAeWO1KqERX4fat70jWd2b+P9xgzxjD2wE d2+4jGp8qmcuYMD3uw2gb8LP6OYIdrk0XOaoKYlVgqdeMnP4S72/cAZPI/Ea4CEAiy bdXZVo5eYLjUsovLWn8kc02X/nDl4cbroXp2Fz2k= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2TAegJW003126; Thu, 29 Mar 2018 05:40:42 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Thu, 29 Mar 2018 05:40:41 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Thu, 29 Mar 2018 05:40:41 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2TAeeE4012628; Thu, 29 Mar 2018 05:40:40 -0500 From: Tomi Valkeinen To: Subject: [PATCH 1/3] drm/omap: fix uninitialized ret variable Date: Thu, 29 Mar 2018 13:40:36 +0300 Message-ID: <20180329104038.29154-1-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.16.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" audio_config function for both HDMI4 and HDMI5 return uninitialized value as the error code if the display is not currently enabled. For some reason this has not caused any issues. Signed-off-by: Tomi Valkeinen Reviewed-by: Emil Velikov Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 2 +- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index 97c88861d67a..5879f45f6fc9 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c @@ -679,7 +679,7 @@ static int hdmi_audio_config(struct device *dev, struct omap_dss_audio *dss_audio) { struct omap_hdmi *hd = dev_get_drvdata(dev); - int ret; + int ret = 0; mutex_lock(&hd->lock); diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index d28da9ac3e90..ae1a001d1b83 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c @@ -671,7 +671,7 @@ static int hdmi_audio_config(struct device *dev, struct omap_dss_audio *dss_audio) { struct omap_hdmi *hd = dev_get_drvdata(dev); - int ret; + int ret = 0; mutex_lock(&hd->lock);