From patchwork Wed Feb 28 13:40:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 129990 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp1544314edc; Wed, 28 Feb 2018 05:42:14 -0800 (PST) X-Google-Smtp-Source: AH8x226gw13lCJs8vIFxqTpgerUvXuu65qX7ecvlYIsE5qYX43qwocOEwY4frNHcvOa347mrOxvO X-Received: by 2002:a17:902:a610:: with SMTP id u16-v6mr17286891plq.293.1519825334718; Wed, 28 Feb 2018 05:42:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519825334; cv=none; d=google.com; s=arc-20160816; b=DpZGIIWj9ISwmSrWyRh0W1f/BgezbtfCsTp1mPNdMI/0AHyqENhB2yl/SC4x9Z9pFl mw2ZephAsm2DrfRieAVdV4g7GZtf0dYk0vLf5l3SCmbANnrvltLyV1gCBzuAKZHSTbUr B0FPIlUW/F9aVLqJqLttsKPaacG86OCVeKc2KXxT1yogeYOpmlWdAghtj3qGE93MFWUz xYJDnWo4Dh0PYIGLC7HqtF9bZDZlKZXNI/RJ8IqdwCcglEhUtvCSwECyllwS/n46TzJs Ma+uN+jj/bcU57LFjqPJ61GGzv8B1TdhNPjyeSUKum/UuoMJY+V5TzwP9AU4g3O2d6ym Hg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:delivered-to :arc-authentication-results; bh=tHgbRS3JwruJqabCFMFQd1/i3E7bcDnFBXBovo2C+ec=; b=0Gm/znxBuOVGPsj2bmghePqIoUgoRlDLG8UlNvwy722ZBT4sH73mxriar447JdXK5t OwPP6m6MjXYjYv8je/LWu2i/EeIcZiNytZPtCImCAnQMFaqDzHRoWJTk3bQi6rRvzjM5 bBQl+Ld36Q7D7+9J2Jao1LiYlr0BiuMg28I1o6VtoOTntBE6lESv/jVBl1x1feLdNj38 MG7ZkHrC7XAAZIRvbCAph6BjY+9ebvQh9wIRxTPdq+NzsscXrBGtHawd7ajGwGQWe8tP nBk2OL78/m8fnwNIATeyvwfv2d4Lninxkj6HsucnK/y8J+CpNZHUOCXbx4Jh+z0cSrTT 7rUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id c6-v6si1339217pll.258.2018.02.28.05.42.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 05:42:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DAD26E94D; Wed, 28 Feb 2018 13:42:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3FE16E94D for ; Wed, 28 Feb 2018 13:42:07 +0000 (UTC) Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MC5H2-1eznPG0cZE-008oJN; Wed, 28 Feb 2018 14:41:14 +0100 From: Arnd Bergmann To: =?utf-8?q?Noralf_Tr=C3=B8nnes?= , David Airlie Subject: [PATCH] tinydrm: add backlight dependency Date: Wed, 28 Feb 2018 14:40:48 +0100 Message-Id: <20180228134111.2042877-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:e/i3ftyCf7oTYTma45OqIhkCHPxtjiBYiog4qvnKHi8KBpciuRU bEFYkA9kNGnki/zAbiOXs0mftrUca6dpFg0L94gW76A8ECcKd+jUFmcU81UHtUx0sQfieLD kUTtGBjv0MN7mVL+NzvSapeMypE8iQcCvZ2+8lywM4tH/CNnrhnqgYBRJTxRoPrpsF9Z19V b4d7LKGzLrzJcFCKENjdA== X-UI-Out-Filterresults: notjunk:1; V01:K0:5dcZjLIgImc=:Wl2s6i8CF0eP8F7ZZqfeXU LDvRpy95YnUhK1Qo1lcsB3Bk9k2n4GVkuXUG0k3d5oxH7ECmFvTSZW+9/Wi0ZjRlWskVGr1/T 0vZnU7NL6Wvth9kqvpZqc0U8DcmZbitaBqOUv5bS77kUKa07q6kdCsUPBT1ZIdYUYpQFwlW0i 5voiTa7byOaCtatdRTJPpUd1QxaOi1iyBYLY/R+U+BilmMTv2OrCkZr3+QwbXPBMa3UpJX9Qu m5aHYRNfm/xS6lQT4Ux8+B11FZ+ieGySTqIX4eIjmxP1+MrO6nF0kEwWN85VT42t4S6vi44To 3Vj81xDFZEe4ydSt57mWsaDkHFC6kyHD4/iW0b2VjPl/HhREttS4JmQg9u+WMQP+wpfZL+0s/ LUleNptWl/URQd8M3cPLSJ9pP2QGs8mZS6+D076TMdn9PG1TkklfcBp6AZXnmrliC2eAk3xdC UCwfCSA/RUTM6SXs1keDGZbyIrnD/tG6w0r0QHKakcm0GrmvUIs1jdLZ737mHM4f6OTIJWGUS dTmDGgMj0z0mS7lXhYD+TYccSOo3pX5JiAcrf+dY7m9tmZk1QYA9bsoi1aSq9Dvok3kqRxTzk hgf7AzpEs/R8A4+qH+jyVnrF8cXrnpYtNz3ml7nc9FrHw7sw1pP86SEtF57oVNrpCc7g0Vzs4 4Hf0IRUGe8K7VRpSKKfyVXK2dC9sjYcm8UsVYNJZeM9tnzKdZRmKbCY9ik9vqQjqODiRgah8n fVPunkB8Pd66ZOa//Nr4hGMFozMNyHNvlKrDlw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Lechner , Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Meghana Madhyastha MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Calling devm_of_find_backlight directly means we get a link failure without CONFIG_BACKLIGHT_CLASS_DEVICE: drivers/gpu/drm/tinydrm/mi0283qt.o: In function `mi0283qt_probe': mi0283qt.c:(.text+0x684): undefined reference to `devm_of_find_backlight' This adds an explicit Kconfig dependency for it. While I did not observe that failure for st7735r, I assume the same change is needed there for the same reason. Fixes: d1a2e7004b5e ("drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/tinydrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig index 13339be843bc..4592a5e3f20b 100644 --- a/drivers/gpu/drm/tinydrm/Kconfig +++ b/drivers/gpu/drm/tinydrm/Kconfig @@ -23,6 +23,7 @@ config TINYDRM_ILI9225 config TINYDRM_MI0283QT tristate "DRM support for MI0283QT" depends on DRM_TINYDRM && SPI + depends on BACKLIGHT_CLASS_DEVICE select TINYDRM_MIPI_DBI help DRM driver for the Multi-Inno MI0283QT display panel @@ -54,6 +55,7 @@ config TINYDRM_ST7586 config TINYDRM_ST7735R tristate "DRM support for Sitronix ST7735R display panels" depends on DRM_TINYDRM && SPI + depends on BACKLIGHT_CLASS_DEVICE select TINYDRM_MIPI_DBI help DRM driver Sitronix ST7735R with one of the following LCDs: