From patchwork Mon Jan 9 13:32:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomeu Vizoso X-Patchwork-Id: 90445 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp618026obz; Mon, 9 Jan 2017 05:33:33 -0800 (PST) X-Received: by 10.84.150.129 with SMTP id h1mr194669250plh.3.1483968813059; Mon, 09 Jan 2017 05:33:33 -0800 (PST) Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 130si88684908pgb.271.2017.01.09.05.33.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 05:33:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE dis=NONE) header.from=collabora.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 054396E43B; Mon, 9 Jan 2017 13:33:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0F7A6E441; Mon, 9 Jan 2017 13:33:15 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id r144so13379098wme.0; Mon, 09 Jan 2017 05:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yhoD9qmlzBaFpG6LQNHSGOdK2uuh0xjEujewWpzwFOs=; b=KkxLXDUBH6h3OzIollqsY0z88EtuDMzyJ2tnPhdK9qYZtZzWQ0gfCcJMwQkAH5DIfS I0HDXevr9CQsOqmoyGt92WU+f1S36NhFMozTH1EI9Nh2J/oOm1JG35LXkgNDAYgWDnfF VPD4HDm/HWsgycHXywwaDvNmFplHZ6uKRZcgOBFb3RUKzLvPDogAoklvHECPGZAY4nvI Iwd1iONsBV702mfpXjC7nR7KoJgrRBvE8z7XipIVRgoQPhGNXj7Y+ZYJgFm71PBJYdEh ID1rLBcagpwCUur6uTK4MPmQyuSKNA+X/b86+dwfkldjFjhL6qie7WRDf8P+vwfw1O89 0jEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yhoD9qmlzBaFpG6LQNHSGOdK2uuh0xjEujewWpzwFOs=; b=jpQi8P//PXAgZyBFLAakAKw8vguBa+/GYGsI5FMfpZPlfcVJLu63lmwuQk4Lc8ouC0 Ehr+NK6WPXOQNXjOiXBWX0RWWpw/5Zzlf0DkDJ+hq3567LBacYYiv7w6PWKWTwtQkCg0 V20vRp5/Umc3peGeTKUAG5RCqR51d+b1Lyndiei73zn21dRYmlYc4aD/WNXYF9RT28BI ClnwirwioXGRvRC/s0KyvRyjJ7CU41GSHht5bXTJVU1/94ZMRjhWYzqxsCQ2jerjuj81 ARaz0J3w6Gtxb2qiQdzyWupWA2e94EJrpAfTKtgow10KGqbG2eYzHNfvuQ+7hdIRiTpY 1J2A== X-Gm-Message-State: AIkVDXJasC6DXFFe+/hP0YISGtiqgiPrT6vi8+fjOvVzOTuJlUn/gQt8iC7Mg0jjCVe5FA== X-Received: by 10.223.136.206 with SMTP id g14mr10143531wrg.52.1483968793830; Mon, 09 Jan 2017 05:33:13 -0800 (PST) Received: from cizrna.lan ([109.72.12.251]) by smtp.gmail.com with ESMTPSA id u78sm18908423wma.11.2017.01.09.05.33.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 05:33:12 -0800 (PST) From: Tomeu Vizoso To: linux-kernel@vger.kernel.org Subject: [PATCH v4 5/5] drm/rockchip: Implement CRC debugfs API Date: Mon, 9 Jan 2017 14:32:37 +0100 Message-Id: <20170109133237.17413-6-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170109133237.17413-1-tomeu.vizoso@collabora.com> References: <20170109133237.17413-1-tomeu.vizoso@collabora.com> Cc: Tomeu Vizoso , Emil Velikov , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, intel-gfx-trybot@lists.freedesktop.org, Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Implement the .set_crc_source() callback and call the DP helpers accordingly to start and stop CRC capture. This is only done if this CRTC is currently using the eDP connector. v3: Remove superfluous check on rockchip_crtc_state->output_type Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 +++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index fb5f001f51c3..6e5eb1aa182a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -1105,6 +1106,46 @@ static void vop_crtc_destroy_state(struct drm_crtc *crtc, kfree(s); } +static struct drm_connector *vop_get_edp_connector(struct vop *vop) +{ + struct drm_crtc *crtc = &vop->crtc; + struct drm_connector *connector; + + mutex_lock(&crtc->dev->mode_config.mutex); + drm_for_each_connector(connector, crtc->dev) + if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) { + mutex_unlock(&crtc->dev->mode_config.mutex); + return connector; + } + mutex_unlock(&crtc->dev->mode_config.mutex); + + return NULL; +} + +static int vop_crtc_set_crc_source(struct drm_crtc *crtc, + const char *source_name, size_t *values_cnt) +{ + struct vop *vop = to_vop(crtc); + struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc->state); + struct drm_connector *connector; + int ret; + + connector = vop_get_edp_connector(vop); + if (!connector) + return -EINVAL; + + *values_cnt = 3; + + if (source_name && strcmp(source_name, "auto") == 0) + ret = analogix_dp_start_crc(connector); + else if (!source_name) + ret = analogix_dp_stop_crc(connector); + else + ret = -EINVAL; + + return ret; +} + static const struct drm_crtc_funcs vop_crtc_funcs = { .set_config = drm_atomic_helper_set_config, .page_flip = drm_atomic_helper_page_flip, @@ -1112,6 +1153,7 @@ static const struct drm_crtc_funcs vop_crtc_funcs = { .reset = vop_crtc_reset, .atomic_duplicate_state = vop_crtc_duplicate_state, .atomic_destroy_state = vop_crtc_destroy_state, + .set_crc_source = vop_crtc_set_crc_source, }; static void vop_fb_unref_worker(struct drm_flip_work *work, void *val)