From patchwork Mon Feb 12 09:44:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 127973 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3041048ljc; Mon, 12 Feb 2018 01:47:01 -0800 (PST) X-Google-Smtp-Source: AH8x227NaS3gCowEpBv+MM8Xp0B5HIEqhBPJsiIusSQ9O0pFEBPPMm+3/QLXeOIk+S42fPuUaMKv X-Received: by 2002:a17:902:5481:: with SMTP id e1-v6mr10411952pli.410.1518428821441; Mon, 12 Feb 2018 01:47:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518428821; cv=none; d=google.com; s=arc-20160816; b=AzrZ0WGMGW1zf8a/8dX39Tybz0x7pST0Hm60R9fTlfNjRv0hmanAd0tKBMint8tAZp pD6y+FM8Mwm4suyH4e9AWw4IAJ7YWFSl8LAMTcaYSiOT05kRoJeidyC1f4rJ+59J1gGi gq1ZsIXQe3o1o3mLemq/P/UEcH4DA+cTVBNtqbafiMorweVh7JZWazgvMtnduKG7ALXY BKNralmD/ZIpJTHYqqwb8gF/J5nJjWl/d7UEp9HWulxNJK3oQwImnZxxIsgl+qQisuwc 46Csixc9BvUuzLTpicZMMGqLs73ElSZ4DRWQbMJmm8v8Fh1eVS7X7vYjNvYp0nsUl51w Hj0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=rf7eOBDmZY/ojGiNXyzmv8tJRzG2KdQcI1nx2RxfqOA=; b=mZaaZN/rKto63Hmyko+tpOYyjJKCfdBVnZs6+JmRjHbgc0w9bbShEGyMke1SEhAALE Pvjp+FAjup1dCzo8tWN9GOJ469LdnQUjtTwSJDpEK0fIx0uqSB0gL/2Zl4X1zCCBw9Ae JIkKs8n4P/dP6r00tw3xXVJ7jB6tYF4J7VAanvltZCyFG7C1vAikvZ04X8po6OtJLYcE w9r25juwcgbrEOnMPCVco9ZEGAkxiBXhzp4udalK5bM7eSKEi2dqCY8zMM8gkAwxcdFn JM3tBONX157mnuxOAEsIbSizk7SnG99Bq9FiLaCP6CMSt/tZ4/HknhTkEOaMRXWqUOSj gv9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=TscygPv3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id q187si188500pga.547.2018.02.12.01.47.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 01:47:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=TscygPv3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06EB96E184; Mon, 12 Feb 2018 09:45:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B4766E1C2 for ; Mon, 12 Feb 2018 09:45:45 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id w1C9jhZn019018; Mon, 12 Feb 2018 03:45:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518428743; bh=wD9T8+qZNh8p5M9Rc+Yw45jtBwymO1pvohgnl8iYEbQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=TscygPv3fT4BBfF6W0OQoc1KN0qM52ylWETA5lcUvu0iig4RjX9VABLJGsOSPDn2E 8T6vgHszxgQN0hSJSlCIRdQiCBMH6hqgX/DMVwiyeK/c2/XDJNm7a0qSpaKqb0evm9 ydCznv6gQrLc14ie76/sA5rlYRaD+JFapadoBRu4= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1C9jhlE020695; Mon, 12 Feb 2018 03:45:43 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Mon, 12 Feb 2018 03:45:43 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Mon, 12 Feb 2018 03:45:43 -0600 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1C9j0NJ003439; Mon, 12 Feb 2018 03:45:41 -0600 From: Tomi Valkeinen To: , Laurent Pinchart , Peter Ujfalusi , Jyri Sarha , Benoit Parrot Subject: [PATCH 22/24] drm/omap: fix maximum sizes Date: Mon, 12 Feb 2018 11:44:52 +0200 Message-ID: <1518428694-18018-23-git-send-email-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1518428694-18018-1-git-send-email-tomi.valkeinen@ti.com> References: <1518428694-18018-1-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We define max width and height in mode_config to 2048. These maximums affect many things, which are independent and depend on platform. We need to do more fine grained checks in the code paths for each component, and so the maximum values in mode_config should just be "big enough" to cover all use cases. Change the maximum width & height to 8192. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 5a27a47b628e..2df125369781 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -412,11 +412,14 @@ static int omap_modeset_init(struct drm_device *dev) dev->mode_config.min_width = 8; dev->mode_config.min_height = 2; - /* note: eventually will need some cpu_is_omapXYZ() type stuff here - * to fill in these limits properly on different OMAP generations.. + /* + * Note: these values are used for multiple independent things: + * connector mode filtering, buffer sizes, crtc sizes... + * Use big enough values here to cover all use cases, and do more + * specific checking in the respective code paths. */ - dev->mode_config.max_width = 2048; - dev->mode_config.max_height = 2048; + dev->mode_config.max_width = 8192; + dev->mode_config.max_height = 8192; dev->mode_config.funcs = &omap_mode_config_funcs; dev->mode_config.helper_private = &omap_mode_config_helper_funcs;