From patchwork Mon Feb 12 08:19:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 127948 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2985152ljc; Mon, 12 Feb 2018 00:19:45 -0800 (PST) X-Google-Smtp-Source: AH8x225pzRCr6Yo+XBFmTApsOT+jB1pJOloA64bl47ArZLJxTqjD2NPTU52cOhbtQK1XHENf+PlZ X-Received: by 10.99.116.9 with SMTP id p9mr8918515pgc.437.1518423585796; Mon, 12 Feb 2018 00:19:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518423585; cv=none; d=google.com; s=arc-20160816; b=xP5ZpSk21wcL/3Ce167D6uAPrpCuU6Eucaqba9wN0yKqydYec+xi7UVrZKM1JA6rUa Bwr8B2XH1qIrldjeeRWs1XHIgB+bR2qjweqX9R4OKj6jzevmvWSnMZ1yyU9CK50xUraX i4Fmq+ui6rycBKQSnZ8dQHXJn/8yCJUHbBVqxu4rcWzUucp9O80Q2/Fxu0DtHhQKdWH1 XUY/kI/RbJuh+HIAgErUzIgnL5qyufMjzxWNFO4XbBHvCO5Lx3AdAmD8WWTYregVXQeA hKBTZI6D5ScZt02PLNFDmcbFLNHxfU39cEm5pk33TviRy19RQhb9rKBLGlkl3dLk5nCF rvOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=CbjDVFYWa/V6zsRWnsz4IEhIL69WCbH/W845a9q3Vxo=; b=r/6Zu2hKFDOf4ulAt+Mbxj9cmwhluPBT2gVcIdhefE2kO5ZzUZl34rKNsDbgA1NtBQ 2lz+/J28WRDPfSZiAFzzv78YC9kMq0wgDHB/HImTOaAdJ3+dwTjcQ6MkahRxJE2B9PsI 8S+P2Zwg19raohJgpIeE6N+BAXG7jQlYlgZ6V+wp+YYxcbLrbe5QexY9w5W+iyiZ9b+b WJNBD75CQK9zFQVfmGL1rdIvZoAItU7aUZGcYVP1XIBD0kUFZlj12eW1CHOrl+/MOlQ+ EvyPZRUHf0sxOzo65o9vVPG/EmGbrwio8Ot6OddGFjhcBhaybkG0tply0J1ZLTx7zLQT xdSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=HcQ0WVk0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id e27si3858596pfk.256.2018.02.12.00.19.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 00:19:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=HcQ0WVk0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B631589836; Mon, 12 Feb 2018 08:19:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id CECEB89836 for ; Mon, 12 Feb 2018 08:19:42 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id w1C8Je8o027558; Mon, 12 Feb 2018 02:19:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518423580; bh=KJc8X42x/Czm5sPZaXqNeRQwkJ0NvdXVCbihHz88McU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=HcQ0WVk02tw9mf7poBgbfJWIWtEglxME9fzzSDN2NmIzCSPwJSDfxjNieUVm7B8Gw uoTL+JUu/YrGZF35Ekw6xEWNkTTZvZF4PDOFV7dTTX0y1/LmWivBLEZXp4qJqPG13Y D2DhPr6lAuudbmdeY0nK7qG84ZA98ilNEsQDuFi4= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1C8JeTW001375; Mon, 12 Feb 2018 02:19:40 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Mon, 12 Feb 2018 02:19:40 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Mon, 12 Feb 2018 02:19:40 -0600 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1C8JYka029541; Mon, 12 Feb 2018 02:19:39 -0600 From: Tomi Valkeinen To: , Laurent Pinchart Subject: [PATCH 4/4] drm/omap: fbdev: avoid double initializer entry Date: Mon, 12 Feb 2018 10:19:22 +0200 Message-ID: <1518423562-1191-4-git-send-email-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1518423562-1191-1-git-send-email-tomi.valkeinen@ti.com> References: <1518423562-1191-1-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fix sparse warning: drivers/gpu/drm/omapdrm/omap_fbdev.c:83:9: warning: Initializer entry defined twice drivers/gpu/drm/omapdrm/omap_fbdev.c:91:10: also defined here Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 211ab0b865c9..1ace63e2ff22 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -80,15 +80,21 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, static struct fb_ops omap_fb_ops = { .owner = THIS_MODULE, - DRM_FB_HELPER_DEFAULT_OPS, + + .fb_check_var = drm_fb_helper_check_var, + .fb_set_par = drm_fb_helper_set_par, + .fb_setcmap = drm_fb_helper_setcmap, + .fb_blank = drm_fb_helper_blank, + .fb_pan_display = omap_fbdev_pan_display, + .fb_debug_enter = drm_fb_helper_debug_enter, + .fb_debug_leave = drm_fb_helper_debug_leave, + .fb_ioctl = drm_fb_helper_ioctl, .fb_read = drm_fb_helper_sys_read, .fb_write = drm_fb_helper_sys_write, .fb_fillrect = drm_fb_helper_sys_fillrect, .fb_copyarea = drm_fb_helper_sys_copyarea, .fb_imageblit = drm_fb_helper_sys_imageblit, - - .fb_pan_display = omap_fbdev_pan_display, }; static int omap_fbdev_create(struct drm_fb_helper *helper,