From patchwork Mon Jul 27 14:12:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 51542 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by patches.linaro.org (Postfix) with ESMTPS id CC10D214B7 for ; Mon, 27 Jul 2015 14:12:50 +0000 (UTC) Received: by wixh2 with SMTP id h2sf28778572wix.0 for ; Mon, 27 Jul 2015 07:12:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=kRr1Kcubt1M1pYa7IHTgxOD+ZejUEcNlOnMjO8UKkKA=; b=cX0i/wsd+dckBDnu1gAwIxnI84LaERZvd0Tu1ZHY7+F7XqimN9jlBZKs6oFDCxJ7KJ NIUDj174db4ImaCwpKhcZvl3k5snakES+p1EBNWhzs5joQmV5ySP7lI+FHKrUAy0ynYR OrJsgihQi53HbvmBfYNKpssyQuBNU06OqtcFDoYyFhnBxHV8XpZcCPCw1ausMCxTW4vP Z5zfMkAY728hzq/CBlwOdET94E23y+jVXM1yIwwsrhFHFMN2NfDk5pG6QGJgzsihUpnq oyegiqSUVdOimk6CpEWABmzGtYj888VSK3fl9NxUswRV4yOnF5z8ESeLCHjpmiuxrqt9 r8jA== X-Gm-Message-State: ALoCoQnFkedsb4qjY/KaxI3oxh58SpJfy5nTrGwOhfdS4RC/Rsop6XvOEvuUzdXcDH9ewm9kgNfP X-Received: by 10.152.88.111 with SMTP id bf15mr12132303lab.9.1438006370122; Mon, 27 Jul 2015 07:12:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.7.105 with SMTP id i9ls613318laa.96.gmail; Mon, 27 Jul 2015 07:12:49 -0700 (PDT) X-Received: by 10.152.42.144 with SMTP id o16mr27131813lal.46.1438006369941; Mon, 27 Jul 2015 07:12:49 -0700 (PDT) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPS id h3si15334117lbj.145.2015.07.27.07.12.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2015 07:12:49 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by laah7 with SMTP id h7so49880247laa.0 for ; Mon, 27 Jul 2015 07:12:49 -0700 (PDT) X-Received: by 10.152.25.228 with SMTP id f4mr26739948lag.112.1438006369811; Mon, 27 Jul 2015 07:12:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1555746lba; Mon, 27 Jul 2015 07:12:48 -0700 (PDT) X-Received: by 10.67.7.199 with SMTP id de7mr67996034pad.107.1438006368024; Mon, 27 Jul 2015 07:12:48 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j2si44472262pdn.104.2015.07.27.07.12.47; Mon, 27 Jul 2015 07:12:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754605AbbG0OMp (ORCPT + 28 others); Mon, 27 Jul 2015 10:12:45 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37798 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700AbbG0OMo (ORCPT ); Mon, 27 Jul 2015 10:12:44 -0400 Received: by wibud3 with SMTP id ud3so117877815wib.0 for ; Mon, 27 Jul 2015 07:12:43 -0700 (PDT) X-Received: by 10.194.122.132 with SMTP id ls4mr52567209wjb.130.1438006363121; Mon, 27 Jul 2015 07:12:43 -0700 (PDT) Received: from srini-ThinkPad-X1-Carbon-2nd.dlink.com (host-78-147-3-201.as13285.net. [78.147.3.201]) by smtp.gmail.com with ESMTPSA id lm5sm13851494wic.22.2015.07.27.07.12.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Jul 2015 07:12:42 -0700 (PDT) From: Srinivas Kandagatla To: robdclark@gmail.com, dri-devel@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH] drm/msm: add calls to prepare and unprepare panel Date: Mon, 27 Jul 2015 15:12:39 +0100 Message-Id: <1438006359-16850-1-git-send-email-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srinivas.kandagatla@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Prepare the panel before it's enabled and un-prepare after disable, this will make sure that the regulators are switched on and off correctly. Tested it on APQ8064 based IFC6410 with panel. Signed-off-by: Srinivas Kandagatla --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c index c048433..4cd6e72 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c @@ -346,8 +346,10 @@ static void mdp4_lcdc_encoder_disable(struct drm_encoder *encoder) mdp4_write(mdp4_kms, REG_MDP4_LCDC_ENABLE, 0); - if (panel) + if (panel) { drm_panel_disable(panel); + drm_panel_unprepare(panel); + } /* * Wait for a vsync so we know the ENABLE=0 latched before @@ -412,8 +414,10 @@ static void mdp4_lcdc_encoder_enable(struct drm_encoder *encoder) if (ret) dev_err(dev->dev, "failed to enable lcdc_clk: %d\n", ret); - if (panel) + if (panel) { + drm_panel_prepare(panel); drm_panel_enable(panel); + } setup_phy(encoder);