From patchwork Thu Mar 21 10:03:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15452 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 81E4723E75 for ; Thu, 21 Mar 2013 10:15:18 +0000 (UTC) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by fiordland.canonical.com (Postfix) with ESMTP id 3BE86A18177 for ; Thu, 21 Mar 2013 10:15:18 +0000 (UTC) Received: by mail-ve0-f182.google.com with SMTP id ox1so2274415veb.27 for ; Thu, 21 Mar 2013 03:15:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=jJRdBhw4arHXVGUIcWRq3DRqQniRh7QGYw6hHxekCZc=; b=N+kcJ9PpM9Nxrq+8iKC4PY/fatiE/v+RlLKelG0DoQQTtGz2tSEmEfA2zz+PNFduh5 xasOX3OnDVD/O4SklQJJcaxmEAc6Jqw68QI4MlSNjDYbdska03ylJmRRf49pNNjZolw/ v1DNRuhnZgnQXnGrysMTKHhWYiaXZcqDkjqbwFeQDA2fqD+tbhfv9hBffkkJndd87y14 PonIP9lLJY6RYcJ6Wv4bkwZkJSX3HG18YhiUdlwk/DxNuX4Rxy4WOXLpkzqSu/G4IjDk C+z3EnnTluXrgidO7TXR7WPAjzZsDNdP7X5E/mDfuu7SBUVSFjuhfr7k/N6HnRqz6KOM blaQ== X-Received: by 10.220.225.200 with SMTP id it8mr12356004vcb.39.1363860917771; Thu, 21 Mar 2013 03:15:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.233.198 with SMTP id ty6csp53163vec; Thu, 21 Mar 2013 03:15:17 -0700 (PDT) X-Received: by 10.229.73.72 with SMTP id p8mr2669541qcj.69.1363860917408; Thu, 21 Mar 2013 03:15:17 -0700 (PDT) Received: from mail-da0-x22e.google.com (mail-da0-x22e.google.com [2607:f8b0:400e:c00::22e]) by mx.google.com with ESMTPS id go8si4178860qab.40.2013.03.21.03.15.17 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Mar 2013 03:15:17 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c00::22e is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c00::22e; Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400e:c00::22e is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-da0-f46.google.com with SMTP id y19so1546920dan.5 for ; Thu, 21 Mar 2013 03:15:16 -0700 (PDT) X-Received: by 10.68.10.227 with SMTP id l3mr14188760pbb.100.1363860916304; Thu, 21 Mar 2013 03:15:16 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yr10sm5989471pab.6.2013.03.21.03.15.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 21 Mar 2013 03:15:15 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, jy0922.shim@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 3/3] drm/exynos: drm_rotator: Fix incorrect usage of IS_ERR_OR_NULL Date: Thu, 21 Mar 2013 15:33:59 +0530 Message-Id: <1363860239-916-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1363860239-916-1-git-send-email-sachin.kamat@linaro.org> References: <1363860239-916-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnj4WOCXfkot0tvgdtLl7lCKEQOYkww4F6LGGLtD4ho4/58Ku8DSI8JAmnQ0V0OhA3wq283 Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index a40b9fb..947f09f 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -674,7 +674,7 @@ static int rotator_probe(struct platform_device *pdev) } rot->clock = devm_clk_get(dev, "rotator"); - if (IS_ERR_OR_NULL(rot->clock)) { + if (IS_ERR(rot->clock)) { dev_err(dev, "failed to get clock\n"); ret = PTR_ERR(rot->clock); goto err_clk_get;