From patchwork Thu Mar 21 10:03:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15450 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5AF1223E75 for ; Thu, 21 Mar 2013 10:15:13 +0000 (UTC) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by fiordland.canonical.com (Postfix) with ESMTP id EAF0BA1904E for ; Thu, 21 Mar 2013 10:15:12 +0000 (UTC) Received: by mail-ve0-f172.google.com with SMTP id cz11so2250330veb.31 for ; Thu, 21 Mar 2013 03:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=3pbsQufh70qKW99eLIDsbWsvnGaXXDuMLS9my1tu8d0=; b=QkE7JAMch0JFXJdzsMhwCoLLLy+EfOAQnfoY4v1omC63cHsZ09LiJajFLZe6KTQX30 vGra7USvsyN5ZRtIv3ARn6jnCvFST+uofZEc9WW10fa+eT25U4Q9Jovt5dtUkIldKO07 dqegur0Q/gAF0TyYl8NGRj4NS9Ju3vA0p3vD9s1rw2F091dKietaYC0HvALyqx2+OPvl Sv9IdMDry2Ck3/FNym/evay+p8Y/VYTPgfGL7ZBqM00yndY4VVdUWgdZ2RdkE6dky/pC a1/gx2KQ6HhRYO0Im6IlRQ+AsDzYL1TRTeNrcmMIUADwrmgec11p9LLP2U5LCSZG5r9s SvdQ== X-Received: by 10.220.150.74 with SMTP id x10mr12529277vcv.68.1363860912426; Thu, 21 Mar 2013 03:15:12 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.233.198 with SMTP id ty6csp53160vec; Thu, 21 Mar 2013 03:15:12 -0700 (PDT) X-Received: by 10.224.72.203 with SMTP id n11mr563488qaj.72.1363860911548; Thu, 21 Mar 2013 03:15:11 -0700 (PDT) Received: from mail-da0-x234.google.com (mail-da0-x234.google.com [2607:f8b0:400e:c00::234]) by mx.google.com with ESMTPS id n12si9692429qct.80.2013.03.21.03.15.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Mar 2013 03:15:11 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c00::234 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c00::234; Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400e:c00::234 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-da0-f52.google.com with SMTP id f10so1565975dak.11 for ; Thu, 21 Mar 2013 03:15:10 -0700 (PDT) X-Received: by 10.67.14.105 with SMTP id ff9mr14322656pad.101.1363860910369; Thu, 21 Mar 2013 03:15:10 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yr10sm5989471pab.6.2013.03.21.03.15.07 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 21 Mar 2013 03:15:09 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, jy0922.shim@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/3] drm/exynos: hdmi: Fix incorrect usage of IS_ERR_OR_NULL Date: Thu, 21 Mar 2013 15:33:57 +0530 Message-Id: <1363860239-916-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnFJa/0Dt2yGCivAqidpR4MxkCAf1xZN7MqQghrgzaItTyhH6qlPVYzSEWyXasQXBuhLOOb Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2c5f266..10757b6 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2023,27 +2023,27 @@ static int hdmi_resources_init(struct hdmi_context *hdata) /* get clocks, power */ res->hdmi = devm_clk_get(dev, "hdmi"); - if (IS_ERR_OR_NULL(res->hdmi)) { + if (IS_ERR(res->hdmi)) { DRM_ERROR("failed to get clock 'hdmi'\n"); goto fail; } res->sclk_hdmi = devm_clk_get(dev, "sclk_hdmi"); - if (IS_ERR_OR_NULL(res->sclk_hdmi)) { + if (IS_ERR(res->sclk_hdmi)) { DRM_ERROR("failed to get clock 'sclk_hdmi'\n"); goto fail; } res->sclk_pixel = devm_clk_get(dev, "sclk_pixel"); - if (IS_ERR_OR_NULL(res->sclk_pixel)) { + if (IS_ERR(res->sclk_pixel)) { DRM_ERROR("failed to get clock 'sclk_pixel'\n"); goto fail; } res->sclk_hdmiphy = devm_clk_get(dev, "sclk_hdmiphy"); - if (IS_ERR_OR_NULL(res->sclk_hdmiphy)) { + if (IS_ERR(res->sclk_hdmiphy)) { DRM_ERROR("failed to get clock 'sclk_hdmiphy'\n"); goto fail; } res->hdmiphy = devm_clk_get(dev, "hdmiphy"); - if (IS_ERR_OR_NULL(res->hdmiphy)) { + if (IS_ERR(res->hdmiphy)) { DRM_ERROR("failed to get clock 'hdmiphy'\n"); goto fail; }