From patchwork Mon Dec 24 08:33:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13689 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id A9DA723EC8 for ; Mon, 24 Dec 2012 08:42:23 +0000 (UTC) Received: from mail-vb0-f51.google.com (mail-vb0-f51.google.com [209.85.212.51]) by fiordland.canonical.com (Postfix) with ESMTP id 64F65A18DC6 for ; Mon, 24 Dec 2012 08:42:23 +0000 (UTC) Received: by mail-vb0-f51.google.com with SMTP id fq11so7136529vbb.38 for ; Mon, 24 Dec 2012 00:42:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=ytPD0h3b0uG31itOoqH+l7AUbyfaXCABHPZkJWULMCU=; b=EP2bCrBL6trvvrb1O6W/nTNqZ+e7Rh3VFc7rAQF12Nmg4eFdKVdUcUx5g5T938zMfr BTLRLwSxziFhbNZ3ivbtvt/mjALtB8XFTcVUTYE7RCev+1iKFHtt4SY8aFb863zzKera MbX1JsRh394omz9NuEbnXJrHxoU82hI3+/gl0prIzcCFc9E9FMFgvWgigP7My0LAd7wh GLYkhYkGkvKZJgIiDV6SF0jLGKnx74itQ2vwaJPFQGzeEWnY1LkdDXd4ECRol6SgYAGX ofCdIEQu69N00QZ/aod35mCG8nJ/fgG7YRfXVgvZ8Dih67Wd47tmSWb6kAyA9gMhjHjT biEA== X-Received: by 10.52.70.205 with SMTP id o13mr27753962vdu.75.1356338542898; Mon, 24 Dec 2012 00:42:22 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.49.133 with SMTP id u5csp184122ven; Mon, 24 Dec 2012 00:42:22 -0800 (PST) X-Received: by 10.66.79.134 with SMTP id j6mr39838153pax.11.1356338541944; Mon, 24 Dec 2012 00:42:21 -0800 (PST) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by mx.google.com with ESMTPS id i7si20158593pay.305.2012.12.24.00.42.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:21 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.45 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.45; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.45 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f45.google.com with SMTP id bg2so3957423pad.4 for ; Mon, 24 Dec 2012 00:42:21 -0800 (PST) X-Received: by 10.66.89.199 with SMTP id bq7mr61324524pab.26.1356338541444; Mon, 24 Dec 2012 00:42:21 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id pv8sm11959096pbc.26.2012.12.24.00.42.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:20 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, airlied@linux.ie, Eunchul Kim Subject: [PATCH 06/10] drm/exynos: Remove redundant NULL check in exynos_drm_rotator.c Date: Mon, 24 Dec 2012 14:03:47 +0530 Message-Id: <1356338031-23674-7-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> References: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmr7WMWPS1OsGhLCUvijUvHeFy19x3NyVT+DTiBe1PKrLenOW9cd2NF1NNVNvfo09iKt7KQ devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index 0f168449..4505163 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -655,11 +655,6 @@ static int __devinit rotator_probe(struct platform_device *pdev) platform_get_device_id(pdev)->driver_data; rot->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!rot->regs_res) { - dev_err(dev, "failed to find registers\n"); - return -ENOENT; - } - rot->regs = devm_request_and_ioremap(dev, rot->regs_res); if (!rot->regs) { dev_err(dev, "failed to map register\n");