From patchwork Mon Dec 24 08:33:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13686 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id BF84823EC8 for ; Mon, 24 Dec 2012 08:42:13 +0000 (UTC) Received: from mail-vb0-f46.google.com (mail-vb0-f46.google.com [209.85.212.46]) by fiordland.canonical.com (Postfix) with ESMTP id 79C1DA18DC6 for ; Mon, 24 Dec 2012 08:42:13 +0000 (UTC) Received: by mail-vb0-f46.google.com with SMTP id b13so7248345vby.33 for ; Mon, 24 Dec 2012 00:42:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=gYAwfCU6huYj6Jv5Es7QWxxRY3oDwBHf3KlKMdUOl/c=; b=Tj+RIru10xyeKkz8vEBYKc4vL6MmBphvclbnSspVlQ1qdPX7up1aoIpaN1L5qt1UcB xPdifW/Ra9F5srL9ycvUqY8KU6vlOgqYCUmm7PvM1fGhpTBP2IUAJauYKahVgcclFgPR OCCK9pqynSHJo52bRMUOvOO8XufHEoV+GR8OtUnL/PGkQ0cimRYYsslkzdIXlBbnrCrk V4psVcw+g1LLTLLxQ0/7gkxzPgcIA6ecJKEC8OYWp2IhXnUnzepLfKBr+cQFpw7D84yj OqJb82uUSK7vw3heyDiFBNMLcZV2RdMzu+HSF6xEkQqmAZj6kBwFjv+TgiM3aeIIoAZ+ 4tfw== X-Received: by 10.220.157.9 with SMTP id z9mr31983869vcw.45.1356338533005; Mon, 24 Dec 2012 00:42:13 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.49.133 with SMTP id u5csp184116ven; Mon, 24 Dec 2012 00:42:12 -0800 (PST) X-Received: by 10.68.137.131 with SMTP id qi3mr64841913pbb.114.1356338532040; Mon, 24 Dec 2012 00:42:12 -0800 (PST) Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by mx.google.com with ESMTPS id tp3si19740125pbc.265.2012.12.24.00.42.11 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:11 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.49 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.49; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.49 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f49.google.com with SMTP id un15so3877620pbc.36 for ; Mon, 24 Dec 2012 00:42:11 -0800 (PST) X-Received: by 10.66.52.102 with SMTP id s6mr61387331pao.6.1356338531405; Mon, 24 Dec 2012 00:42:11 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id pv8sm11959096pbc.26.2012.12.24.00.42.08 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:10 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, airlied@linux.ie, Eunchul Kim Subject: [PATCH 03/10] drm/exynos: Remove redundant NULL check Date: Mon, 24 Dec 2012 14:03:44 +0530 Message-Id: <1356338031-23674-4-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> References: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlFFMyNA7N5RZ4NDkZ9323zR8VPK39BvG/8zCAVUIL0bDfVO+ecnEbjxoQp2jYujfMcFhQ8 devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index ab75150..972aa70 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1801,12 +1801,6 @@ static int __devinit fimc_probe(struct platform_device *pdev) /* resource memory */ ctx->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!ctx->regs_res) { - dev_err(dev, "failed to find registers.\n"); - ret = -ENOENT; - goto err_clk; - } - ctx->regs = devm_request_and_ioremap(dev, ctx->regs_res); if (!ctx->regs) { dev_err(dev, "failed to map registers.\n");