From patchwork Mon Nov 19 05:27:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 12910 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 839C923FC8 for ; Mon, 19 Nov 2012 05:33:52 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 11DADA18436 for ; Mon, 19 Nov 2012 05:33:51 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so5972622iej.11 for ; Sun, 18 Nov 2012 21:33:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=d8l3OlfhWtoaLbWXi5IQs/aNHvNgvha1UHIbqoORGKw=; b=fnQsvmqEXFGn7CyYQJGY+EdbXIpdH8Cqe+kc/mNKW5H7G6f3bYK/cyUVn059SoYIa4 vZBFSAmjKA1kRAQCqOnDlPiNjURIhCmeizEY5kuh7/LsmAoPw9Q3n4pPqoNBMqAbDY3k JK4LZ4Jg7X8IHmBYT2XNxrEdvK5yF56BxmIpKcTjr5Z/31EABUs7GUyWl6zTfiwjuNhr abOxYUzo/Xp68LyiirIkyH3uRYRAfyC4zjxCwq93MVorgwYjWBEJwvIhd1mM8/5O97Z1 UnBn4BQto3QPtI7JDj1PDdKRpymRUoj4cR2w2gRXVwOl+nGE0HB+y6IitGVKiHZc5g/D rk0Q== Received: by 10.50.173.34 with SMTP id bh2mr5565514igc.70.1353303231528; Sun, 18 Nov 2012 21:33:51 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp117370igt; Sun, 18 Nov 2012 21:33:51 -0800 (PST) Received: by 10.66.87.133 with SMTP id ay5mr32821404pab.59.1353303230914; Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx.google.com with ESMTPS id j9si11981053paw.328.2012.11.18.21.33.50 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.54; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f54.google.com with SMTP id wz12so3338185pbc.13 for ; Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received: by 10.66.89.9 with SMTP id bk9mr32624080pab.67.1353303230477; Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id se4sm5605309pbb.13.2012.11.18.21.33.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Nov 2012 21:33:49 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, airlied@gmail.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] drm/udl: Add missing static storage class specifiers in udl_connector.c Date: Mon, 19 Nov 2012 10:57:43 +0530 Message-Id: <1353302863-5462-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmxBNRBqJaKTEHkWGOTOIQI6TkP/Kqa+UFOJUYfO5PUBn6+b7Sk0cQYGtEXw1IwicaL5OTc Fixes the following sparse warnings: drivers/gpu/drm/udl/udl_connector.c:80:20: warning: symbol 'udl_best_single_encoder' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:93:5: warning: symbol 'udl_connector_set_property' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:106:35: warning: symbol 'udl_connector_helper_funcs' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:112:28: warning: symbol 'udl_connector_funcs' was not declared. Should it be static? Signed-off-by: Sachin Kamat Reviewed-by: Alex Deucher --- drivers/gpu/drm/udl/udl_connector.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c index b3b2ced..25b93de 100644 --- a/drivers/gpu/drm/udl/udl_connector.c +++ b/drivers/gpu/drm/udl/udl_connector.c @@ -84,7 +84,8 @@ udl_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector) +static struct drm_encoder* +udl_best_single_encoder(struct drm_connector *connector) { int enc_id = connector->encoder_ids[0]; struct drm_mode_object *obj; @@ -97,8 +98,9 @@ struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector) return encoder; } -int udl_connector_set_property(struct drm_connector *connector, struct drm_property *property, - uint64_t val) +static int udl_connector_set_property(struct drm_connector *connector, + struct drm_property *property, + uint64_t val) { return 0; } @@ -110,13 +112,13 @@ static void udl_connector_destroy(struct drm_connector *connector) kfree(connector); } -struct drm_connector_helper_funcs udl_connector_helper_funcs = { +static struct drm_connector_helper_funcs udl_connector_helper_funcs = { .get_modes = udl_get_modes, .mode_valid = udl_mode_valid, .best_encoder = udl_best_single_encoder, }; -struct drm_connector_funcs udl_connector_funcs = { +static struct drm_connector_funcs udl_connector_funcs = { .dpms = drm_helper_connector_dpms, .detect = udl_detect, .fill_modes = drm_helper_probe_single_connector_modes,