From patchwork Mon Aug 6 06:46:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 10497 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 340D223F3F for ; Mon, 6 Aug 2012 06:47:53 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 03BF7A18566 for ; Mon, 6 Aug 2012 06:47:52 +0000 (UTC) Received: by ghbg10 with SMTP id g10so420767ghb.11 for ; Sun, 05 Aug 2012 23:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=g4O4vuV64ExWsmudSqR2LE6lxfxncGvdZ/LlpBdW7so=; b=AQKI8/PbOb3SHDATfyZcmotI62L59bjT5uylP1edoBWndEIZI+Fh61iFpsK6bzF9ex j9cQEUVxryhtk/5YuQ+2AfsPilGqXU5Ej9hrYAiAXM2sQ3O+iFfthMpEXnlcwfydo/qr UCIi1o0FpeJGm5EMFZSxR4Ys6mcmg9QXGUZf2C/9BCOWb3inHmUHEudtQmBKOquIh9YL axQw0KhfxsEUUG5MPpLaAvnKnqOzvBZNEHkOKeLpqDcjZ+0qoQC14DC8KMeQn/NmoNwE Np4+iGLsRUNbnNBI8Q6fERbuVdrCBQU1tejz2lq4OqEExVHMWMOxU8/8nn6ZzrJK9IOv 88Zw== Received: by 10.50.219.226 with SMTP id pr2mr4479151igc.51.1344235671960; Sun, 05 Aug 2012 23:47:51 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp424397igz; Sun, 5 Aug 2012 23:47:51 -0700 (PDT) Received: by 10.66.81.3 with SMTP id v3mr15962010pax.62.1344235671428; Sun, 05 Aug 2012 23:47:51 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id ms7si1694356pbb.88.2012.08.05.23.47.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 23:47:51 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md12so3840459pbc.37 for ; Sun, 05 Aug 2012 23:47:51 -0700 (PDT) Received: by 10.68.200.98 with SMTP id jr2mr16504170pbc.81.1344235671184; Sun, 05 Aug 2012 23:47:51 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ql6sm8331600pbc.61.2012.08.05.23.47.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 23:47:50 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, airlied@linux.ie, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/5] drm/exynos: Remove redundant check in exynos_hdmi.c file Date: Mon, 6 Aug 2012 12:16:16 +0530 Message-Id: <1344235580-3030-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> References: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnFZ1fK/GuRgRdVheMMp+Uj6iZirogQlsj5GMd8efsZsVz+7KmGSm6UKfB+hUc5IRosonWX devm_request_and_ioremap function checks the validity of the pointer returned by platform_get_resource. Hence an additional check in the probe function is not necessary. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 409e2ec..bb504cb 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2312,11 +2312,6 @@ static int __devinit hdmi_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - DRM_ERROR("failed to find registers\n"); - ret = -ENOENT; - goto err_resource; - } hdata->regs = devm_request_and_ioremap(&pdev->dev, res); if (!hdata->regs) {