| Message ID | 20210602143300.2330146-1-lee.jones@linaro.org |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote: > Some off these patches have been knocking around for a while. > > Who will hoover them up please? > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (26): > drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header > drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant > kernel-doc header > drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header > drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc > header > drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc > headers > drm/sti/sti_hda: Provide missing function names > drm/sti/sti_tvout: Provide a bunch of missing function names > drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' > drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable > 'cmd_enc' > drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc > abuses > drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues > drm/msm/msm_gem: Demote kernel-doc abuses > drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' > drm/msm/dp/dp_link: Fix some potential doc-rot > drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference > static > drm/amd/display/dc/dce/dce_transform: Remove superfluous > re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, > drm/xlnx/zynqmp_disp: Fix incorrectly named enum > 'zynqmp_disp_layer_id' > drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' > drm/ttm/ttm_tt: Demote non-conformant kernel-doc header > drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse > drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse > drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc > format > drm/exynos/exynos7_drm_decon: Fix incorrect naming of > 'decon_shadow_protect_win()' > drm/exynos/exynos_drm_ipp: Fix documentation for > 'exynos_drm_ipp_get_{caps,res}_ioctl()' > drm/vboxvideo/hgsmi_base: Place function names into headers > drm/vboxvideo/modesetting: Provide function names for prototype > headers Except for msm (Rob Clark promised on irc he'll pick them up for 5.14 soon) and amd (Alex is on top of things I think) I picked them all up and merged into drm-misc-next. Thanks, Daniel > > .../drm/amd/display/dc/dce/dce_transform.h | 3 +- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 +-- > drivers/gpu/drm/mediatek/mtk_disp_color.c | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +-- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +-- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 --- > .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++---------- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 +-- > drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- > drivers/gpu/drm/msm/dp/dp_link.c | 6 ++-- > drivers/gpu/drm/msm/msm_gem.c | 4 +-- > .../gpu/drm/nouveau/nvkm/subdev/mc/tu102.c | 6 ++-- > .../drm/panel/panel-raspberrypi-touchscreen.c | 2 +- > drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +- > drivers/gpu/drm/sti/sti_hda.c | 6 ++-- > drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 4 +-- > drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- > drivers/gpu/drm/sti/sti_tvout.c | 18 +++++------ > drivers/gpu/drm/ttm/ttm_tt.c | 2 +- > drivers/gpu/drm/vboxvideo/hgsmi_base.c | 19 +++++++---- > drivers/gpu/drm/vboxvideo/modesetting.c | 20 +++++++----- > drivers/gpu/drm/vgem/vgem_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- > 26 files changed, 80 insertions(+), 82 deletions(-) > > Cc: Adam Jackson <ajax@redhat.com> > Cc: Ajay Kumar <ajaykumar.rs@samsung.com> > Cc: Akshu Agarwal <akshua@gmail.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Alistair Popple <apopple@nvidia.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Ben Widawsky <ben@bwidawsk.net> > Cc: Chandan Uddaraju <chandanu@codeaurora.org> > Cc: Christian Koenig <christian.koenig@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Cc: Eric Anholt <eric@anholt.net> > Cc: Fabien Dessenne <fabien.dessenne@st.com> > Cc: freedreno@lists.freedesktop.org > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Huang Rui <ray.huang@amd.com> > Cc: Hyun Kwon <hyun.kwon@xilinx.com> > Cc: Inki Dae <inki.dae@samsung.com> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > Cc: Krishna Manikandan <mkrishn@codeaurora.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Cc: Kuogee Hsieh <khsieh@codeaurora.org> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Leo Li <sunpeng.li@amd.com> > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-media@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Mauro Rossi <issor.oruam@gmail.com> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: nouveau@lists.freedesktop.org > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Sean Paul <sean@poorly.run> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com> > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Vincent Abriou <vincent.abriou@st.com> > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
On Thu, 03 Jun 2021, Daniel Vetter wrote: > On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote: > > Some off these patches have been knocking around for a while. > > > > Who will hoover them up please? > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (26): > > drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header > > drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant > > kernel-doc header > > drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header > > drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc > > header > > drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc > > headers > > drm/sti/sti_hda: Provide missing function names > > drm/sti/sti_tvout: Provide a bunch of missing function names > > drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' > > drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable > > 'cmd_enc' > > drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc > > abuses > > drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues > > drm/msm/msm_gem: Demote kernel-doc abuses > > drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' > > drm/msm/dp/dp_link: Fix some potential doc-rot > > drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference > > static > > drm/amd/display/dc/dce/dce_transform: Remove superfluous > > re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, > > drm/xlnx/zynqmp_disp: Fix incorrectly named enum > > 'zynqmp_disp_layer_id' > > drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' > > drm/ttm/ttm_tt: Demote non-conformant kernel-doc header > > drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse > > drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse > > drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc > > format > > drm/exynos/exynos7_drm_decon: Fix incorrect naming of > > 'decon_shadow_protect_win()' > > drm/exynos/exynos_drm_ipp: Fix documentation for > > 'exynos_drm_ipp_get_{caps,res}_ioctl()' > > drm/vboxvideo/hgsmi_base: Place function names into headers > > drm/vboxvideo/modesetting: Provide function names for prototype > > headers > > Except for msm (Rob Clark promised on irc he'll pick them up for 5.14 > soon) and amd (Alex is on top of things I think) I picked them all up and > merged into drm-misc-next. Superstar! Thanks Daniel. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On 02/06/2021 17:32, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/msm_gem.c:364: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > drivers/gpu/drm/msm/msm_gem.c:763: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/msm_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index 56df86e5f7400..15434deb19334 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -372,7 +372,7 @@ static void del_vma(struct msm_gem_vma *vma) > kfree(vma); > } > > -/** > +/* > * If close is true, this also closes the VMA (releasing the allocated > * iova range) in addition to removing the iommu mapping. In the eviction > * case (!close), we keep the iova allocated, but only remove the iommu > @@ -773,7 +773,7 @@ void msm_gem_purge(struct drm_gem_object *obj) > 0, (loff_t)-1); > } > > -/** > +/* > * Unpin the backing pages and make them available to be swapped out. > */ > void msm_gem_evict(struct drm_gem_object *obj) > -- With best wishes Dmitry
Some off these patches have been knocking around for a while. Who will hoover them up please? This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (26): drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers drm/sti/sti_hda: Provide missing function names drm/sti/sti_tvout: Provide a bunch of missing function names drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues drm/msm/msm_gem: Demote kernel-doc abuses drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' drm/msm/dp/dp_link: Fix some potential doc-rot drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' drm/ttm/ttm_tt: Demote non-conformant kernel-doc header drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps,res}_ioctl()' drm/vboxvideo/hgsmi_base: Place function names into headers drm/vboxvideo/modesetting: Provide function names for prototype headers .../drm/amd/display/dc/dce/dce_transform.h | 3 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 +-- drivers/gpu/drm/mediatek/mtk_disp_color.c | 3 +- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +-- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +-- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 --- .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++---------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 +-- drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- drivers/gpu/drm/msm/dp/dp_link.c | 6 ++-- drivers/gpu/drm/msm/msm_gem.c | 4 +-- .../gpu/drm/nouveau/nvkm/subdev/mc/tu102.c | 6 ++-- .../drm/panel/panel-raspberrypi-touchscreen.c | 2 +- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 6 ++-- drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 4 +-- drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- drivers/gpu/drm/sti/sti_tvout.c | 18 +++++------ drivers/gpu/drm/ttm/ttm_tt.c | 2 +- drivers/gpu/drm/vboxvideo/hgsmi_base.c | 19 +++++++---- drivers/gpu/drm/vboxvideo/modesetting.c | 20 +++++++----- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 26 files changed, 80 insertions(+), 82 deletions(-) Cc: Adam Jackson <ajax@redhat.com> Cc: Ajay Kumar <ajaykumar.rs@samsung.com> Cc: Akshu Agarwal <akshua@gmail.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Alistair Popple <apopple@nvidia.com> Cc: amd-gfx@lists.freedesktop.org Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Ben Widawsky <ben@bwidawsk.net> Cc: Chandan Uddaraju <chandanu@codeaurora.org> Cc: Christian Koenig <christian.koenig@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: Eric Anholt <eric@anholt.net> Cc: Fabien Dessenne <fabien.dessenne@st.com> Cc: freedreno@lists.freedesktop.org Cc: Hans de Goede <hdegoede@redhat.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: Hyun Kwon <hyun.kwon@xilinx.com> Cc: Inki Dae <inki.dae@samsung.com> Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Krishna Manikandan <mkrishn@codeaurora.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Kuogee Hsieh <khsieh@codeaurora.org> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-mediatek@lists.infradead.org Cc: linux-media@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: Mauro Rossi <issor.oruam@gmail.com> Cc: Michal Simek <michal.simek@xilinx.com> Cc: nouveau@lists.freedesktop.org Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Clark <robdclark@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Sean Paul <sean@poorly.run> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Stephen Boyd <swboyd@chromium.org> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Vincent Abriou <vincent.abriou@st.com> -- 2.31.1