| Message ID | 20201112190039.2785914-1-lee.jones@linaro.org |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
On Thu, Nov 12, 2020 at 2:07 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:685: warning: Function parameter or member 'backoff' not described in 'amdgpu_cs_parser_fini' > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1655: warning: Function parameter or member 'map' not described in 'amdgpu_cs_find_mapping' > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Jerome Glisse <glisse@freedesktop.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 8d2878e950dab..594a0108e90fa 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -676,6 +676,7 @@ static int amdgpu_cs_sync_rings(struct amdgpu_cs_parser *p) > * cs_parser_fini() - clean parser states > * @parser: parser structure holding parsing context. > * @error: error number > + * @backoff: indicator to backoff the reservation > * > * If error is set than unvalidate buffer, otherwise just free memory > * used by parsing context. > @@ -1644,6 +1645,7 @@ int amdgpu_cs_wait_fences_ioctl(struct drm_device *dev, void *data, > * @parser: command submission parser context > * @addr: VM address > * @bo: resulting BO of the mapping found > + * @map: Placeholder to return found BO mapping > * > * Search the buffer objects in the command submission context for a certain > * virtual memory address. Returns allocation structure when found, NULL > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. NB: Hopefully the other sets turn up in -next soon, so they can be rebased and any stragglers re-submitted. Lee Jones (30): drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params drm/via/via_dma: Remove set but unused variable 'agp_base' drm/v3d/v3d_sched: Demote non-conformant kernel-doc header drm/amd/amdgpu/amdgpu_kms: Fix misnaming of parameter 'dev' drm/amd/amdgpu/amdgpu_fence: Fix some issues pertaining to function documentation drm/exynos/exynos7_drm_decon: Supply missing description for param 'ctx' drm/exynos/exynos_drm_fimd: Add missing description for param 'ctx' drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused drm/vc4/vc4_hdmi: Remove set but unused variable 'ret' drm/amd/amdgpu/amdgpu_ttm: Demote non-conformant kernel-doc headers, fix slightly lacking ones drm/atmel-hlcdc/atmel_hlcdc_crtc: Apply correct formatting to struct docs drm/amd/amdgpu/amdgpu_ring: Fix a bunch of function misdocumentation drm/amd/amdgpu/amdgpu_display: Remove pointless header drm/atmel-hlcdc/atmel_hlcdc_plane: Staticise local function 'atmel_hlcdc_plane_setup_scaler()' drm/atmel-hlcdc/atmel_hlcdc_plane: Fix documentation formatting and add missing description drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers drm/amd/amdgpu/amdgpu_cs: Add a couple of missing function param descriptions drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers drm/rockchip/dw-mipi-dsi-rockchip: Demote non-conformant kernel-doc headers drm/rockchip/rockchip_rgb: Consume our own header drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description drm/rockchip/rockchip_lvds: Fix struct document formatting drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits' drm/sti/sti_hdmi: Move 'colorspace_mode_names' array to where its used drm/mediatek/mtk_disp_color: Fix formatting and provide missing member description drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member description drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 -- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 11 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 12 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 60 ++++++++++--------- .../gpu/drm/amd/amdgpu/atombios_encoders.c | 3 +- drivers/gpu/drm/armada/armada_overlay.c | 2 +- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 +- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 7 ++- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 + drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 + drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 +- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +-- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 4 +- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 + drivers/gpu/drm/savage/savage_bci.c | 11 ---- drivers/gpu/drm/sti/sti_hdmi.c | 6 ++ drivers/gpu/drm/sti/sti_hdmi.h | 6 -- drivers/gpu/drm/v3d/v3d_gem.c | 2 + drivers/gpu/drm/v3d/v3d_sched.c | 2 +- drivers/gpu/drm/vc4/vc4_debugfs.c | 4 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +- drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 +- drivers/gpu/drm/vc4/vc4_v3d.c | 4 +- drivers/gpu/drm/via/via_dma.c | 2 - include/drm/drm_atomic.h | 1 + 30 files changed, 91 insertions(+), 94 deletions(-) Cc: Ajay Kumar <ajaykumar.rs@samsung.com> Cc: Akshu Agarwal <akshua@gmail.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: "Christian König" <christian.koenig@amd.com> Cc: Chris Zhong <zyw@rock-chips.com> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: Eric Anholt <eric@anholt.net> Cc: Eunchul Kim <chulspro.kim@samsung.com> Cc: "Heiko Stübner" <heiko@sntech.de> Cc: Inki Dae <inki.dae@samsung.com> Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com> Cc: Jerome Glisse <glisse@freedesktop.org> Cc: Jinyoung Jeon <jy0.jeon@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-media@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: Luben Tuikov <luben.tuikov@amd.com> Cc: Ludovic Desroches <ludovic.desroches@microchip.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Mark Yao <mark.yao@rock-chips.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Nickey Yang <nickey.yang@rock-chips.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: nouveau@lists.freedesktop.org Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: report to <xorg-driver-ati@lists.x.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Sandy Huang <hjc@rock-chips.com> Cc: Sangmin Lee <lsmin.lee@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Vincent Abriou <vincent.abriou@st.com>